Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221209150503.11875-1-ajye_huang@compal.corp-partner.google.com> <eca17001-93ff-d379-1ab2-2927f1831e78@linux.intel.com>
In-Reply-To: <eca17001-93ff-d379-1ab2-2927f1831e78@linux.intel.com>
From:   Ajye Huang <ajye_huang@compal.corp-partner.google.com>
Date:   Sat, 10 Dec 2022 01:06:38 +0800
Message-ID: <CALprXBayJtWRe9J+q7EahgpXrRy_B-tMAf0KXbDtWa+=4RKyHA@mail.gmail.com>
Subject: Re: [PATCH v1] ASoC: Intel: sof_nau8825: add support for nau8825 with
 amp nau8318
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Akihiko Odaki <akihiko.odaki@gmail.com>,
        Yong Zhi <yong.zhi@intel.com>,
        ye xingchen <ye.xingchen@zte.com.cn>,
        Muralidhar Reddy <muralidhar.reddy@intel.com>,
        "balamurugan . c" <balamurugan.c@intel.com>,
        Libin Yang <libin.yang@intel.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Cezary Rojewski <cezary.rojewski@intel.com>,
        David Lin <CTLIN0@nuvoton.com>, Brent Lu <brent.lu@intel.com>,
        Takashi Iwai <tiwai@suse.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        alsa-devel@alsa-project.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Pierre

On Fri, Dec 9, 2022 at 11:52 PM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:

> This looks inconsistent with the commit message. There are separate
> Kconfigs for different codecs.
>
> SND_SOC_NAU8315
> SND_SOC_NAU8825
>
> Which is it?
>

Sorry about confusing you, I think it is better to change the title as
ASoC: Intel: sof_nau8825: add combination of nau8825 headset codec
with nau8318 Amp.

And add some information about Nuvoton chips in the comment message.
***
The nau8315 and nau8318 are both Nuvoton Amp chips. They use the same
Amp driver nau8315.c. The acpi_device_id for nau8315 is "NVTN2010",
for nau8318 is "NVTN2012".
The nau8825 is one of Nuvoton headset codec, and its acpi_device_id is
"10508825".
***

>
> Deep sigh...
>
> This ACPI HID is already used to match with the 8815, so this is not
> going to work if we confuse two independent drivers...
>
> sound/soc/codecs/nau8315.c:
>
> #ifdef CONFIG_ACPI
> static const struct acpi_device_id nau8315_acpi_match[] = {
>         { "NVTN2010", 0 },
>         { "NVTN2012", 0},
>         {},
> };
> MODULE_DEVICE_TABLE(acpi, nau8315_acpi_match);
> #endif
>
> How does this identify a NAU8825?
>

The NAU8825 Is headset codec, we added a new combination of nau8825
headset codec + nau8318 amp in the machine driver.


>
> > +             .dai_name = "nau8315-hifi",
>
> and again this makes a reference to 8815.
>

Because the Amp driver is the same file nau8315.c , so nau8318 use the
same dai_name "nau8315-hifi"


> I will stop the review here.
>
> NAK for this v1. Please clarify which codec you are using and make sure
> all references are consistent.
>
>

I apologize for the unclear comment message, please give me any
suggestions if needed, and I will send v2 for review.
thanks.