Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3090885rwb; Fri, 9 Dec 2022 09:50:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf7xb7Rwh0OqzLGXN7tk2hB2LBsERYPtLGEKZujFHoR81lZ7jsUwKNrr+xdPbnz0jxVk3s7G X-Received: by 2002:a17:907:a409:b0:7b8:947e:61c3 with SMTP id sg9-20020a170907a40900b007b8947e61c3mr7639270ejc.77.1670608222025; Fri, 09 Dec 2022 09:50:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670608222; cv=none; d=google.com; s=arc-20160816; b=HHzt1I0PPPmBOZRXTE+BvPFE8WMZoaemvpWRdZcrBdoPNX0tVv7T0hxwd/uUotWBLC Oh7ii8rwFDJF0pm58BLQV3fQpoWyLyB7D9teXzBmEmsFfHrft8q/2nBzM1dlTlOQ1dCT ufv/CvxzOPrfyYfZTmpzg3S3BXZF5ZjT+l52EYNae+rhmPgL6BHQOBVCTeRqsDw32D/B XLNZ9f96OzGxjbucfMr7VUF6/prWfMosdJWTp4EvhWIhRHfgcTFNWUIK90+6LAij35Ku xKm8eD5FsIPnqmH98ipwavFjKB06Hp71jCjjpC4/F5zsWDzXekTI4sZykf4I1Cl7eXVq FAlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=E5dou/fIw4t1TpJn5uz+6TpGu7v7uQ0gbWVgq2BkWFU=; b=sQDipKK649EldNSMUKPz5/dK9sa9/PR7DBtM1zhw+hWMznJ/3OpgGL8U/HTuH8juMH 4c4LOprPuCqXjjGibtikg8pi/pyTfunAcU6b6P3dP1b4RftriHzVUXy/SqlozdCdlI9D GT8xeHZeosPIVAaBaYnhz9pkGLI63wrjIe1hyX2Vge7x1oyen0mvoyvdUoKIbUOFbpuy KucdEpGPdjtNFF4oNMUkXxN6vARJWKcx54+lgf37w9MzYZYmMo9yT5Fa8dMaAQf+Fg0a gjoRVzul0lAEO7XL8qjFSuP+R4pYniF9F/KN3Dtnn/pbYmRpjf2JukR0BoOHNq66dqgV MaEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y20-20020a056402271400b00461f44d7bfcsi2104101edd.573.2022.12.09.09.50.04; Fri, 09 Dec 2022 09:50:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229556AbiLIRNL (ORCPT + 74 others); Fri, 9 Dec 2022 12:13:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbiLIRNJ (ORCPT ); Fri, 9 Dec 2022 12:13:09 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C2E326AA4 for ; Fri, 9 Dec 2022 09:13:07 -0800 (PST) Received: from martin by viti.kaiser.cx with local (Exim 4.89) (envelope-from ) id 1p3gvo-0001Cy-Ii; Fri, 09 Dec 2022 18:13:04 +0100 Date: Fri, 9 Dec 2022 18:13:04 +0100 From: Martin Kaiser To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, Amarula patchwork , Arnd Bergmann , Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Russell King , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/1] ARM: imx: add missing of_node_put() Message-ID: <20221209171304.teg463mwnteigmmp@viti.kaiser.cx> References: <20221208165404.1512014-1-dario.binacchi@amarulasolutions.com> <20221208165404.1512014-2-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221208165404.1512014-2-dario.binacchi@amarulasolutions.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: Martin Kaiser X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thus wrote Dario Binacchi (dario.binacchi@amarulasolutions.com): > Calling of_find_compatible_node() returns a node pointer with refcount > incremented. Use of_node_put() on it when done. > The patch fixes the same problem on different i.MX platforms. > Fixes: 8b88f7ef31dde ("ARM: mx25: Retrieve IIM base from dt") > Fixes: 94b2bec1b0e05 ("ARM: imx27: Retrieve the SYSCTRL base address from devicetree") > Fixes: 3172225d45bd9 ("ARM: imx31: Retrieve the IIM base address from devicetree") > Fixes: f68ea682d1da7 ("ARM: imx35: Retrieve the IIM base address from devicetree") > Fixes: ee18a7154ee08 ("ARM: imx5: retrieve iim base from device tree") > Signed-off-by: Dario Binacchi Reviewed-by: Martin Kaiser Thanks, Martin