Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Dec 2022 10:57:05 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Miaohe Lin <linmiaohe@huawei.com>,
        David Hildenbrand <david@redhat.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Jann Horn <jannh@google.com>,
        John Hubbard <jhubbard@nvidia.com>,
        James Houghton <jthoughton@google.com>,
        Rik van Riel <riel@surriel.com>,
        Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH v3 0/9] mm/hugetlb: Make huge_pte_offset() thread-safe
 for pmd unshare
Message-ID: <Y5OFAfYA9sNr3m6Q@monkey>
References: <20221209170100.973970-1-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221209170100.973970-1-peterx@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pmSOTCq/tNX1+h1fAB9vjiWOkKC+ZrAHs80ZZcjnyBIye2xDzyD5wjZzJAXb?=
 =?us-ascii?Q?K8v0sl41t0Y54nKwPM1FVJJcFwYA1qIv8TOpou/ZeFDfrhG20nsYn3llXuWS?=
 =?us-ascii?Q?GHkBU0sCt6ITqpbRuv/T9ZnNH/25hJbjbX1Nq/MCiyCZp1dsdtAGccAs+TnK?=
 =?us-ascii?Q?Ha4/PKytUodaovEW5k7Ex85f3yMBHF85kz8FOElTETYQ4b8UpT4z9XyEbzrf?=
 =?us-ascii?Q?/AjFjDT/2apNYGLVJyV+Bzf/Q1wiX/PlbOWg5EX9Wqgzs37w9vPZSkjeqVqW?=
 =?us-ascii?Q?x/tgnn3602/2SPUj/Fu1eCHn5d8UxOEgnb20Il4IbHTlC99+d1wwuKBqkkxD?=
 =?us-ascii?Q?nu3XguuGLgxwpwsXAnAEsgA01TszLodZzF5Jznu2iIxQaJIfExRqz0csx0XT?=
 =?us-ascii?Q?5Mj3QSE3PXzYsCVZZV0qEukayP6dgx0Zr0/4qF2Ro0+P3zjdly8bT3U5Vx/8?=
 =?us-ascii?Q?YbI865gMdBTaf7YGnv1W6ySuoKbmnQuxznuvr4wNC+h6ElS1sg643H0bj+tf?=
 =?us-ascii?Q?PCRbLr6juApmsRe6c2eCDRE8S1Dq3NDl3F2dEWVYpFw45Y1Bee7IBsw9LjuY?=
 =?us-ascii?Q?ea0eGePDRHHQMq528ctAy1tFhiGO33Dor7U6btMqnItDZ/A/40uG0V+e6mx4?=
 =?us-ascii?Q?f3hYl8wbJzsYLYeocwGs0xyMSLUZeDWe3KtnIIC9pmPJuu5d2BTtsZxD0bnI?=
 =?us-ascii?Q?3uBRfrXeYhA++1/W67vdHawrPlDAiC+QFtQGlDOZb/cnY2du7AveSazlR0Zf?=
 =?us-ascii?Q?Nn0T8HhahJXZPNYrd5165PQykQfxssXhKLXJpDdqtOGa/oXekTeMYx/rzie3?=
 =?us-ascii?Q?2iIKPAoIzvit58iQqMLw8BLAktDyEaKBwQDQwswyw2DnDEwjufWaDUYY1WSl?=
 =?us-ascii?Q?ebCdv4EwUkT5U33rfD73l7WvXCyuGMEVSd9mFjVSevepfQg/driEHzlYQHx0?=
 =?us-ascii?Q?ItedrLBmKsLBhqHUac6zuqg2CH5GZ+DapvsLygvJ/oJQxf+4FzPKPwzoXZ+V?=
 =?us-ascii?Q?qLtC1ib4VC/dvW3O5Ym7YOttWU9LPVVqzCZbU13NSebbA0HSBkftRt+a53XL?=
 =?us-ascii?Q?RnJNeAfwNpTQLI6odF/Zvv+2ojlgujWpb6EZZyg1XiafHtWBGW29eigoW3Zr?=
 =?us-ascii?Q?nvlFYO6SE1em5UBoHjNfELYi9s1ULWNzDSAbbKDUxcDkVXukjsd7PrNdI4l7?=
 =?us-ascii?Q?Fks5JrvUSgB84RuSEy0Z/tZsd87NfsQ2DIUp+2iOSntVUZmQoepnYqg0XTud?=
 =?us-ascii?Q?hvm5SvW5dmaONNl+Iofeg9Ek3rTIp794BvpiQPtowY5thyWMKZGGC7VQ1Aua?=
 =?us-ascii?Q?DFzJ1pdFClM2x04mTrS6UvJz3eUzC5XbHMMnc6QNSr0BmZrmi+YsiUR+ak6G?=
 =?us-ascii?Q?6YqL/zQN4/9KNPHZYdY0P7+JxQ7YK+gmSP2btiQbEdC5oNLMYrv29dB5bRCO?=
 =?us-ascii?Q?B+2aTLTHcIFzvr15tTFO+dL7EdeBEkUGP15R5GZEz840FwEL35ZPwJuZA+Kp?=
 =?us-ascii?Q?V/IkbhqWhB/vOIwgG4fUDEQdXsqy0aaq+gtKRJcqdyk7VsRbtSpApvO8Mmim?=
 =?us-ascii?Q?y+hhoSG4DlJxtK8D9hqdyxsOfpY9yUodm4fYMRzrU/7z1+exZug2b3ZSZoGq?=
 =?us-ascii?Q?dA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ccd3f119-bdb4-4dff-bcc5-08dada172bc4
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 18:57:08.2731
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AJXOZMoFSdvghMQwSEumoTxKwEglJmGjhXv94HNTHXVqY5feLDCQs/I9OfftDwlnYgmZoh016SMDJ5bc+9ixEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6057
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-09_11,2022-12-08_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=842 bulkscore=0
 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2212090153
X-Proofpoint-ORIG-GUID: 4MPK0hwWeoftBlGSTq2_3xdo0ouO_GuX
X-Proofpoint-GUID: 4MPK0hwWeoftBlGSTq2_3xdo0ouO_GuX
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/09/22 12:00, Peter Xu wrote:
> Based on latest mm-unstable (dbccafc6e992).
> 
> This can be seen as a follow-up series to Mike's recent hugetlb vma lock
> series for pmd unsharing, but majorly covering safe use of huge_pte_offset.
> 
> Changelog for v2->v3:
> - Added a-bs and r-bs
> - In walk_hugetlb_range() hooks, don't release vma lock for cond_resched()

Thanks for your continued work on this Peter!

As a followup to that discussion about releasing vma lock for cond_resched(),
I do not have a strong opinion.  Glad you kept my r-b.
-- 
Mike Kravetz