Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3379495rwb; Fri, 9 Dec 2022 13:46:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf4YKFRpSScEJazuAGUq6p9GyH42zphI26HV2i4jib0j/PjL0gQjAEWjb75f91XAcSvwdOmJ X-Received: by 2002:a05:6402:299b:b0:468:fd17:aeb9 with SMTP id eq27-20020a056402299b00b00468fd17aeb9mr5854483edb.0.1670622391000; Fri, 09 Dec 2022 13:46:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670622390; cv=none; d=google.com; s=arc-20160816; b=DqulUfKqtBrKmqpDpp6c1iow1tK+vIjWfQd4wTRcaHgJgxxlK5hkzyncgDTkVtAWLA lN9yjOK+DoIAADzthfBoa76X4/S+foluiCx2y7rzUTFfCfAmLGLOX69EiFgWIIdAs0Pe QwuhQyCDYFAkegWcIqyAfeu5hRXLEZNsx4alS4tzdI59+EMwTZlwmSagyt0IToVXvvjS Z1xkGqeDOWAHyeg4qs/L8efdEhg2a0Lb3yq3gUqdiYk8YS0zsz1NFmtBX0DULHTOQJVU x9hv/hsLmGs5KXFJ4yL96+OXjLXyR+V20mOLTN+6D9igLW4HjO0AGutQ1k09kF6SoWqV TvgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=yVZDsIodbaqFI1nTBuoWDv3vRwUyTMgQb4PFT5DUgAw=; b=w2U9s6ytmJgaN0qm2t1m70W9INWFICMirImGeeT4BpGYJXJHXL/pjTHcNkYBudFJKj epjNXc+DYln1gxNrrp3/Bcr4Ee1XmQZVjbYA5e521PATcz9hbDVIRlvXy7zM+sDE4LEk y3f0QoZkMYEcz4fMcz6LXMQzs6O408NI7on73B19SO/PRq+zwS2Y2knvzPiiKv5dcaSt VX9MATUpQ04YbpsYbRIo92d9Dtx6qU8AbvuH+49vr16gyVlBsVnRm3nyV+25wKACuORZ cfDJ+DOn/sKvu/58sCf6HBlVgdqRQT+oc8l/78M01yTFT/0bjwDxFXG5sPHLuRKehT2T VsHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v10-20020a056402348a00b004511d552be3si2702786edc.4.2022.12.09.13.46.11; Fri, 09 Dec 2022 13:46:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbiLIU5W convert rfc822-to-8bit (ORCPT + 74 others); Fri, 9 Dec 2022 15:57:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbiLIU5U (ORCPT ); Fri, 9 Dec 2022 15:57:20 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33163A848C for ; Fri, 9 Dec 2022 12:57:19 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E648EB828CF for ; Fri, 9 Dec 2022 20:57:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F44BC433D2; Fri, 9 Dec 2022 20:57:15 +0000 (UTC) Date: Fri, 9 Dec 2022 15:57:13 -0500 From: Steven Rostedt To: Gautam Menghani Cc: mhiramat@kernel.org, akpm@linux-foundation.org, shy828301@gmail.com, zokeefe@google.com, vbabka@suse.cz, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] mm/khugepaged: add tracepoint to collapse_file() Message-ID: <20221209155713.1ea9c199@gandalf.local.home> In-Reply-To: <20221202201807.182829-1-gautammenghani201@gmail.com> References: <20221202201807.182829-1-gautammenghani201@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 3 Dec 2022 01:48:07 +0530 Gautam Menghani wrote: > Currently, is_shmem is not being captured. Capturing is_shmem is useful > as it can indicate if tmpfs is being used as a backing store instead of > persistent storage. Add the tracepoint in collapse_file() named > "mm_khugepaged_collapse_file" for capturing is_shmem. > > Signed-off-by: Gautam Menghani > --- From a tracing point of view: Reviewed-by: Steven Rostedt (Google) -- Steve