Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Dec 2022 14:14:41 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     <ira.weiny@intel.com>, Dan Williams <dan.j.williams@intel.com>
CC:     Ira Weiny <ira.weiny@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
        <linux-acpi@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: RE: [PATCH V3 4/8] cxl/mem: Trace DRAM Event Record
Message-ID: <6393b35111f0_579c12947f@dwillia2-xfh.jf.intel.com.notmuch>
References: <20221208052115.800170-1-ira.weiny@intel.com>
 <20221208052115.800170-5-ira.weiny@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221208052115.800170-5-ira.weiny@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rlI4kyMlzjhf/D8mGCb2VwC67GDgWzdH8t6PDrH88DVEmm6PMDA3Lajfb6c9?=
 =?us-ascii?Q?0/ukVF2UCzdYO6f64U92DsLnerkoXLqUNKuqCxUZ9re7KflvEoMkb2vSMH2j?=
 =?us-ascii?Q?wJLyw32HUt4ClywSUYKx6Ei4gQNcJaUaEdw+Y0ROgoB/V720gJDL2Q+wCKUw?=
 =?us-ascii?Q?Vrl8NsmoghCc55MhzmoFTp1AIglYrp+Hl3tpmtp74qJPEoJhI+J1jFfqIz18?=
 =?us-ascii?Q?7BmtvpP5Kr3FSDfJg3W7naqnQgR0IyimePDR7erm0FJcDOBEshkeBww0klLK?=
 =?us-ascii?Q?hWlsTr/vhXPI8laKq5AdZdyhjGlaBcFd+u7VGHULt0+7sE2iIP06zhKyBuZK?=
 =?us-ascii?Q?tsUdtHnX7JAQiL1ud1new3SzIpeSbu83DpJgrWhl4E3SqNyu0qQVOU8CQF3I?=
 =?us-ascii?Q?W78z8v3YuQOdaavWK1KE9Sv7bNkUjSkuz50aS6YPt9HFIAA5OFKqewgFxTD3?=
 =?us-ascii?Q?TOhRgI5hnqpMbOch2konrtEkcpF4yte96fDEqq0jBXaJMoV6xV8GhYGFvFB3?=
 =?us-ascii?Q?UooYFuTBuY5Lpm3DwBjVucwtsGlQsZrmnZAGYR904yvRUlYTvo6EjZs9taWE?=
 =?us-ascii?Q?HeHmI3WZQcmpPMD/Nh9H2Hw4esRXkJjRT0A2LrcnsAQvRZtyth2m9WqcSI8t?=
 =?us-ascii?Q?ba79qh6M2TmZuEfCqPHdU2RVkOfdEhIVubWOHX7SX3q7uXgkozZHJKsPAA73?=
 =?us-ascii?Q?1Fh5sGJyDE0eiH3YZcfj725zxVOmB+YRnSCdyn1FLgTQiCrLJp7igFxTIiAR?=
 =?us-ascii?Q?HKZ6cVCqrt2wCXAeiVSHA4YlUZ8BGiz+nSGLX+Vui5FSPzo9FIrS9qKUFcXM?=
 =?us-ascii?Q?03zXqXeBSqELXc9QpShvw3HY7soVs28MPAR52kCx9Zld2Acqs8U75kvHK1Vr?=
 =?us-ascii?Q?eGr3DGs/MJdQakAtjWSJ1MnJa8IYBe+mrWFjkBTZeDI5UXk4ZmjRSfWKOs1k?=
 =?us-ascii?Q?ym1bxJRW3fmRIhLoo9Unc9Xf1S41A90OpSMvNb3Laxr4uiFUEL88d/NwyvT5?=
 =?us-ascii?Q?bUKwEYY8shpUCQRXfNpT1nh1F0o3rcObNirg72AAFDi53F3FRYd3IXIOl4Jw?=
 =?us-ascii?Q?ToKFa1pKCnlyHAqQnpw97uha42sTeVZUYACG5ODfhu3FnjN7hhIKH5tC3KeC?=
 =?us-ascii?Q?vBPbMfiaZPMR7hhK18RzRQA2Axdgzwzc/ointmOhDtOyFuUt/v2V1gAxuG17?=
 =?us-ascii?Q?uVdooBkkzAhaJatsT56u+ulLXcRY2j1keMeSh0QBI0g/9eYHIV+YHijR04f+?=
 =?us-ascii?Q?+M//vT34Foa40Gdabp3KGARtKwVTbBTPMrFr6LxkQarInQeIcZvl7YOocHKD?=
 =?us-ascii?Q?DHPMGBN+Y69WGpmQKGf8sJkwbPp35tgL5p14Zo3EJD7fZC45t+rjVai69tBj?=
 =?us-ascii?Q?u8S9i7pGufhXHo41uSHs8M5n7+wGjr9bbC7AHOa0sarRJWc3QsR0d6/M9Ckg?=
 =?us-ascii?Q?L0C5xqtBXwm1a0E24r45aGtuXvWiEu2xDXWZrGMcf9uqCeRAX4NxOqDwT40V?=
 =?us-ascii?Q?QjXUdZzcokWTbDN7pciNivP1SgKYP+acq1P9JeDOMoEi5mEl6X1uLPUC8YHq?=
 =?us-ascii?Q?Jy6G0Ul4hC03kYN2h1e2Dx7etQLM6YCEg0OqPY7fOTvZpCA1zRxWNzWeNw5L?=
 =?us-ascii?Q?RA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a911bda3-e5e5-4bb8-6bf2-08dada32c60a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 22:14:43.3700
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1gHRDHYFZns+ohqB07LPCyU6mkwy1xDU8ZL6jWQGWcBnsAXbbLBNQc1PEF7ObocfYI1wBd8Q3Co08webckK5OWEF4X1jFNE0gL5t5lAF1BM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4551
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

ira.weiny@ wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> CXL rev 3.0 section 8.2.9.2.1.2 defines the DRAM Event Record.
> 
> Determine if the event read is a DRAM event record and if so trace the
> record.
> 
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> ---
> Changes from v2:
> 	Dan
> 		Move tracing to cxl core
> 		Remove trace_*_enabled() calls
> 		Pass struct device to trace points
> 
> Changes from RFC v2:
> 	Output DPA flags as a separate field.
> 	Ensure field names match TP_print output
> 	Steven
> 		prefix TRACE_EVENT with 'cxl_'
> 	Jonathan
> 		Formatting fix
> 		Remove reserved field
> 
> Changes from RFC:
> 	Add reserved byte data
> 	Use new CXL header macros
> 	Jonathan
> 		Use get_unaligned_le{24,16}() for unaligned fields
> 		Use 'else if'
> 	Dave Jiang
> 		s/cxl_dram_event/dram
> 		s/cxl_evt_dram_rec/cxl_event_dram
> 	Adjust for new phys addr mask
> ---
>  drivers/cxl/core/mbox.c  | 13 ++++++
>  drivers/cxl/core/trace.h | 92 ++++++++++++++++++++++++++++++++++++++++
>  drivers/cxl/cxlmem.h     | 23 ++++++++++
>  3 files changed, 128 insertions(+)
> 
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index 0d8c66f1cdc5..2fa4645f0ed9 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -726,6 +726,14 @@ static const uuid_t gen_media_event_uuid =
>  	UUID_INIT(0xfbcd0a77, 0xc260, 0x417f,
>  		  0x85, 0xa9, 0x08, 0x8b, 0x16, 0x21, 0xeb, 0xa6);
>  
> +/*
> + * DRAM Event Record
> + * CXL rev 3.0 section 8.2.9.2.1.2; Table 8-44
> + */
> +static const uuid_t dram_event_uuid =
> +	UUID_INIT(0x601dcbb3, 0x9c06, 0x4eab,
> +		  0xb8, 0xaf, 0x4e, 0x9b, 0xfb, 0x5c, 0x96, 0x24);
> +
>  static void cxl_trace_event_record(const struct device *dev,
>  				   enum cxl_event_log_type type,
>  				   struct cxl_event_record_raw *record)
> @@ -738,6 +746,11 @@ static void cxl_trace_event_record(const struct device *dev,
>  
>  		trace_cxl_general_media(dev, type, rec);
>  		return;
> +	} else if (uuid_equal(id, &dram_event_uuid)) {
> +		struct cxl_event_dram *rec = (struct cxl_event_dram *)record;
> +
> +		trace_cxl_dram(dev, type, rec);
> +		return;

I think I mentioned this before, but rather than a "return" in every
branch just make the 'unknown' case the final else in this if block.

With that feel free to add:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>