Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Dec 2022 14:52:01 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     James Houghton <jthoughton@google.com>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Peter Xu <peterx@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Zach O'Keefe <zokeefe@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Yang Shi <shy828301@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 07/47] hugetlb: add
 CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING
Message-ID: <Y5O8Eewl0v6CSmt6@monkey>
References: <20221021163703.3218176-1-jthoughton@google.com>
 <20221021163703.3218176-8-jthoughton@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221021163703.3218176-8-jthoughton@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7Rk25RV4iWgc2sjEsfmlqnGPlUrHAt5I/NfTOLD8ZmaDYeyh/MKz5OYBMrKh?=
 =?us-ascii?Q?abYs6KpiBwuSNeA1s1g7egHEneau++meWy/jVsJs5jxwDDvijchSi+M8wI0B?=
 =?us-ascii?Q?5FgHHkzNwa5FJfLVIuUzFQuohmClsj/hRDKKcIYdD1RPQv2rzFiu3fSW6B5H?=
 =?us-ascii?Q?Eh1SZQgOepd8BugGvWjFHRp8bM/CtoeO53ugmDifmzbsXzeCNTQsjSnETLoi?=
 =?us-ascii?Q?WV4fQg/5BXkADtsGuswfj9PzxROEJyoKFC3n8W+I6YYlpdUNOd7BqKQ1IRU0?=
 =?us-ascii?Q?1/G73hSxu+lA3eNTTqzvumS6l07G2BrnzZ5yfY3TKZaVeHAxtNGHl0Z0Ewej?=
 =?us-ascii?Q?capaoNZkXt0ZYHw1aqFf0/fSSF2UdSL0/+6XXF6rAIIHzdLSpgbyL5dv42Ve?=
 =?us-ascii?Q?AKWfieGLZToVUXvlpBTSGaq+Fxj48UgwZeS50Jt5GC9Vuml5GY5bvqfvYgha?=
 =?us-ascii?Q?sZJBKvn4dOlifRyT1PHBhxQE6hjc6+XINy8RrcqZnpGhyTRCVGfIDAkq1w2u?=
 =?us-ascii?Q?0mvO1tEAZy0LBL507x5BM245FvccpNT+wRX4rI7/JvR5TYtt05Pa1LDXZFGd?=
 =?us-ascii?Q?NCZm5j/aqr98g2QYfSWe2ElHCp6wV/H6Vcbm+n85N0PE0ogYOsb0R47F3P8a?=
 =?us-ascii?Q?ORyF+CnW3qJ0vV5OSRLuqSH/KPNus9xGIX014zFe5eW4OqiTuM7mgXEATN1L?=
 =?us-ascii?Q?qaFRXYRP6OVCRAWEu17SaarjUvVdbjEM+5KSZF6PuzexRf13DVzbijOjGTBJ?=
 =?us-ascii?Q?4pPQXdMGvSZt+SO9p96y+yUoWYWrdXaTVIzVqXBym3FOiykWuhELwWJ+hewo?=
 =?us-ascii?Q?Ht1sqfxTqzwUucqA4LkYng7uAygdG20w3UcL/LlZE332K2OWo39KM1JPpT23?=
 =?us-ascii?Q?0VBmKUKiBKhYD7OOE2slH+hopwWjd/kmutyO0X8fzA/P2oa0s8q6pMAgvBHr?=
 =?us-ascii?Q?HqgC4IKgC+wbayFS9gS9197+ugYJugi9qjk2VQi+jDXsp/q9EQkNieHgzyDu?=
 =?us-ascii?Q?9m2ckIP7kw73Cd/oxpzC4K8jMpkmt3EOUGQEKnC4B/0nQxyAmDYfalhdIHFV?=
 =?us-ascii?Q?APa2qoEaQybPbsWZ2I2G7tHoqUXD2fwUFXAh9zKhv0+GkvYiWhdF3jYbN69D?=
 =?us-ascii?Q?pi2v9bmSUQaCMAEUcJOiizL2U/Vs17utJWQJP0C1YobX1FXPw37AoIMH5HdO?=
 =?us-ascii?Q?Xgjmp/flSb9y6WpRQP7iGtsvPq84SmypydLeJsgsOTVVf4Re5DcGRjWbMGS8?=
 =?us-ascii?Q?4LhGPEiTpY2ALxRQoyPEByWDJU/Ob0LQYH/pHQLb+4QU3itRVpgaW2VrNhHI?=
 =?us-ascii?Q?VKH8T+dSSiktwA6Z88JNuwEsHW9DI/6v1R3rjMnR+aBAqAQLtwRaqrHMnHcN?=
 =?us-ascii?Q?IugwTNNtpLeIU6UF2II9HENGB8yAkeKZpQ6UIseVlCDImBf9FtTlihBoxrEo?=
 =?us-ascii?Q?GNnhge+WZRHszWrRFiUFZ9BW7OKrofvvGn3fqTAZIV7TMfvQyhk2QAzGiMTc?=
 =?us-ascii?Q?O0cBDAVWCG7uN0NlWgiRtiW67HZaKlp9g1vEZvbmU+gvUn+xSNeh6IbsuKKy?=
 =?us-ascii?Q?ifcAQrVJw+ha9EWq8MBEwMb2Lf1NFRFzLUhNsxiLJaWeGRt6D6uL0QnSkSiw?=
 =?us-ascii?Q?Hg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9829fb5-b95e-4444-1c56-08dada37fda1
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 22:52:04.1784
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kD70Br41nM/S9UadFNv10NOjDu57UEts09XSqrQaE87aRpXkEWmJK9QcMZYz9QeGXt9EJjq4egdTMn8fGv4lCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR10MB6950
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-09_13,2022-12-08_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0
 suspectscore=0 mlxlogscore=864 malwarescore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2212090187
X-Proofpoint-GUID: eWZMFmlIO-eeDfoTIR-9w6cDTMA3vTuC
X-Proofpoint-ORIG-GUID: eWZMFmlIO-eeDfoTIR-9w6cDTMA3vTuC
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/21/22 16:36, James Houghton wrote:
> This adds the Kconfig to enable or disable high-granularity mapping.
> Each architecture must explicitly opt-in to it (via
> ARCH_WANT_HUGETLB_HIGH_GRANULARITY_MAPPING), but when opted in, HGM will
> be enabled by default if HUGETLB_PAGE is enabled.
> 
> Signed-off-by: James Houghton <jthoughton@google.com>
> ---
>  fs/Kconfig | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 2685a4d0d353..ce2567946016 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -267,6 +267,13 @@ config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON
>  	  enable HVO by default. It can be disabled via hugetlb_free_vmemmap=off
>  	  (boot command line) or hugetlb_optimize_vmemmap (sysctl).
>  
> +config ARCH_WANT_HUGETLB_HIGH_GRANULARITY_MAPPING
> +	bool
> +
> +config HUGETLB_HIGH_GRANULARITY_MAPPING
> +	def_bool HUGETLB_PAGE
> +	depends on ARCH_WANT_HUGETLB_HIGH_GRANULARITY_MAPPING

Might also need to make this depend on CONFIG_ARCH_WANT_HUGE_PMD_SHARE
as the vma local allocation will only happen in this case.

-- 
Mike Kravetz

> +
>  config MEMFD_CREATE
>  	def_bool TMPFS || HUGETLBFS
>  
> -- 
> 2.38.0.135.g90850a2211-goog
>