Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 10 Dec 2022 03:55:48 +0100
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@collabora.com, Tony Lindgren <tony@atomide.com>,
        Rob Herring <robh@kernel.org>
Subject: Re: [RFC 1/1] ARM: Drop !ARCH_MULTIPLATFORM dependency from Cortex
 A8/9 erratas
Message-ID: <20221210025548.ssinevgkyjzf3622@mercury.elektranox.org>
References: <20221209182000.549179-1-sebastian.reichel@collabora.com>
 <Y5OCTseqVQ+AcMqm@shell.armlinux.org.uk>
 <b050a5b5-ca13-4ae2-baa3-41a3118e5e8a@app.fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="lxi3meb7xp3kuwb6"
Content-Disposition: inline
In-Reply-To: <b050a5b5-ca13-4ae2-baa3-41a3118e5e8a@app.fastmail.com>
Precedence: bulk


--lxi3meb7xp3kuwb6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Dec 09, 2022 at 10:36:17PM +0100, Arnd Bergmann wrote:
> On Fri, Dec 9, 2022, at 19:45, Russell King (Oracle) wrote:
> > On Fri, Dec 09, 2022 at 07:20:00PM +0100, Sebastian Reichel wrote:
> >> All the erratas for more recent CPUs (Cortex A15/A12/A17) do not
> >> require !ARCH_MULTIPLATFORM, since there is runtime detection of
> >> effected CPUs in arch/arm/mm/proc-v7.S.
> >>=20
> >> Errata config options for the older Cortex A8/A9 CPUs have the
> >> !ARCH_MULTIPLATFORM dependency, but the CPUs are also runtime
> >> detected. Since there is runtime detection, it should be fine
> >> to enable the erratas for a multi platform kernel.
> >>=20
> >> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> >> ---
> >> For me the most likely explanation that this has not yet happened is
> >> me missing an important detail, so I sent it as RFC. If you point it
> >> out I will try to document the reason.
> >
> > IIRC, the reason these are marked with !ARCH_MULTIPLATFORM is for when
> > the kernel is running in the non-secure world - the accessed registers
> > may prevent platforms booting. However, it was a long time ago and I
> > don't remember clearly now.
>=20
> The git log confirms your memory, this is the description of
> commit 62e4d357aae0 ("ARM: 7609/1: disable errata work-arounds
> which access secure registers"):
>=20
>     In order to support secure and non-secure platforms in multi-platform
>     kernels, errata work-arounds that access secure only registers need to
>     be disabled. Make all the errata options that fit in this category
>     depend on !CONFIG_ARCH_MULTIPLATFORM.
>    =20
>     This will effectively remove the errata options as platforms are
>     converted over to multi-platform.
>    =20
>     Signed-off-by: Rob Herring <rob.herring@calxeda.com>
>     Acked-by: Tony Lindgren <tony@atomide.com>
>     Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
>=20
> As far as I understand, these are all boot time chicken bits that
> should already be set up by the boot loader before entering the
> kernel.=20

Ah, I should have spent more time in the git history instead of
trying to search the mailing list :( I will propose a patch adding
a sentence to the config option helptexts, so that one does not need
to go through the git history to understand the requirement and
correct solution:

This errata workaround requires access to secure registers and thus
is not available on multiplatform kernels. The workaround should be
applied by the bootloader instead.

> Sebastian, are you aware of any particular machines that ship
> without the workaround code in the bootloader or in secure world?

No. I'm investigating sporadic GPU hungs on i.MX6QP on a customer
device and just noticed a couple of erratas missing in the .config.
They might already be enabled in the bootloader (and otherwise
definitely can be enabled there).

Thanks for the fast feedback!

-- Sebastian

--lxi3meb7xp3kuwb6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmOT9TAACgkQ2O7X88g7
+ppiNA//arTKXNw4LBK1Wu93pe1pmtNlmDCX4maNOyTXxN048VgcmY61+irtpFxQ
rBFHj0FCwq3ZraMY8rYCFiceN4xFSOnZn5SEnPYvCWVkix1bqg2OYhkmt07lAxdh
L5vLSMYZHd/OqbT58DLT2xvFrVsN8w4oSKSFnUDlJM7g7l1o1Hy12/zzyYAzvs/w
WSic75C5CGUM+ahre1t3/pQkt4EqjPGkxGHfEGx7kTa31IwWxY0+1lfRHB0r0I9X
yRmV82v9PUyr9d3446igSfCL8POxxMYgcK9Bf1MFXbxpa8x/v+vVXteaCYRvm5KZ
04Ex4GPX0dXJQkMegG/px1XVoOCBjzMMeG2vCMBCata6AD022aW557LmC3ckWFFf
3/vFGKMw47naZp+b5Uc94QzSTL/8NI7PKuYfdQfR5B/T26kghAYSOfucVvftA6PS
+PmHfDd+B0UsEai+BhjMFvsNM9d+evAfJQK/KK5vNNsAf1fWy7TyAPVN0JiPlOia
KT7a3e5PYiuj0Yk8EeEzwwVjyiDG7NfqLhB2CO9bgLKN+tBl4N+H/G0AHqPeI+qA
XqoqLdUUAe0ddm2UWAFOsMCjufa99+zXL0ss94Lt4PYt5y2BSXnQaXfXHbS8g9XO
ipD0XK3ey2C/zOD6A8ZoD/okz1/b+p+qOX61xziXT0SfsAeZrJY=
=GDGJ
-----END PGP SIGNATURE-----

--lxi3meb7xp3kuwb6--