Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9b57549f-b74a-25f5-e645-f2602199f35b@linaro.org>
Date:   Sat, 10 Dec 2022 15:25:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [RFC PATCH] arm64: dts: qcom: Use plural _gpios node label for
 PMIC gpios
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        phone-devel@vger.kernel.org
Cc:     ~postmarketos/upstreaming@lists.sr.ht,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@somainline.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Martin Botka <martin.botka@somainline.org>,
        Jami Kettunen <jami.kettunen@somainline.org>,
        Luca Weiss <luca@z3ntu.xyz>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221209220450.1793421-1-marijn.suijten@somainline.org>
 <714ac62a-7bab-e16e-e3b6-bdd86e422699@linaro.org>
Content-Language: en-US
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <714ac62a-7bab-e16e-e3b6-bdd86e422699@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10.12.2022 11:50, Krzysztof Kozlowski wrote:
> On 09/12/2022 23:04, Marijn Suijten wrote:
>> The gpio node in PMIC dts'es define access to multiple GPIOs.  Most Qcom
>> PMICs were already using the plural _gpios label to point to this node,
>> but a few PMICs were left behind including the recently-pulled
>> pm(i)8950.
>>
>> Rename it from *_gpio to *_gpios for pm6125, pm6150(l), pm8005,
>> pm(i)8950, and pm(i)8998.
>>
>> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
>>
>> ---
>>
>> This was brought up for discussion in [1] but hasn't seen any relevant
>> reply, unfortunately.
> 
> This is just a label, it does not matter. Why changing all exisitng
> files? I don't think it was a part of previous discussions...
> 
> To me it is unneeded churn.
IMHO it's beneficial, as when working on different platforms I have to
waste time checking or being told by the compiler that &pm8xxx_gpios
doesn't exist and then I have to think why and realize it's just not
named consistently..

Konrad
> 
>>
>> [1]: https://lore.kernel.org/linux-arm-msm/20221104234435.xwjpwfxs73puvfca@SoMainline.org/
>> ---
>>  arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts  |  8 ++++----
>>  .../dts/qcom/msm8998-oneplus-cheeseburger.dts    |  4 ++--
>>  .../boot/dts/qcom/msm8998-oneplus-common.dtsi    |  6 +++---
>>  .../qcom/msm8998-sony-xperia-yoshino-maple.dts   |  4 ++--
>>  .../dts/qcom/msm8998-sony-xperia-yoshino.dtsi    | 16 ++++++++--------
>>  .../arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts |  4 ++--
>>  arch/arm64/boot/dts/qcom/pm6125.dtsi             |  4 ++--
>>  arch/arm64/boot/dts/qcom/pm6150.dtsi             |  4 ++--
>>  arch/arm64/boot/dts/qcom/pm6150l.dtsi            |  4 ++--
>>  arch/arm64/boot/dts/qcom/pm8005.dtsi             |  4 ++--
>>  arch/arm64/boot/dts/qcom/pm8950.dtsi             |  4 ++--
>>  arch/arm64/boot/dts/qcom/pm8998.dtsi             |  4 ++--
>>  arch/arm64/boot/dts/qcom/pmi8950.dtsi            |  4 ++--
>>  arch/arm64/boot/dts/qcom/pmi8998.dtsi            |  4 ++--
>>  arch/arm64/boot/dts/qcom/sc7180-idp.dts          |  4 ++--
>>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi     |  4 ++--
>>  arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi       |  4 ++--
>>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts       | 16 ++++++++--------
>>  arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi   |  4 ++--
>>  .../boot/dts/qcom/sdm845-oneplus-common.dtsi     |  6 +++---
>>  .../arm64/boot/dts/qcom/sdm845-shift-axolotl.dts |  4 ++--
>>  .../boot/dts/qcom/sdm845-sony-xperia-tama.dtsi   |  2 +-
>>  .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi |  4 ++--
>>  .../boot/dts/qcom/sdm845-xiaomi-polaris.dts      |  4 ++--
>>  .../dts/qcom/sm6125-sony-xperia-seine-pdx201.dts |  2 +-
>>  25 files changed, 64 insertions(+), 64 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts b/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts
>> index 310f7a2df1e8..0e273938b59d 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts
>> +++ b/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts
>> @@ -113,7 +113,7 @@ gpio-keys {
>>  			    <&cam_snapshot_pin_a>;
>>  		button-vol-up {
>>  			label = "Volume Up";
>> -			gpios = <&pm8998_gpio 6 GPIO_ACTIVE_LOW>;
>> +			gpios = <&pm8998_gpios 6 GPIO_ACTIVE_LOW>;
>>  			linux,input-type = <EV_KEY>;
>>  			linux,code = <KEY_VOLUMEUP>;
> 
> Best regards,
> Krzysztof
>