Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>
To:     Guo Ren <guoren@kernel.org>
Cc:     arnd@arndb.de, palmer@rivosinc.com, tglx@linutronix.de,
        peterz@infradead.org, luto@kernel.org, conor.dooley@microchip.com,
        heiko@sntech.de, jszhang@kernel.org, lazyparser@gmail.com,
        falcon@tinylab.org, chenhuacai@kernel.org, apatel@ventanamicro.com,
        atishp@atishpatra.org, palmer@dabbelt.com,
        paul.walmsley@sifive.com, mark.rutland@arm.com,
        zouyipeng@huawei.com, bigeasy@linutronix.de,
        David.Laight@aculab.com, chenzhongjin@huawei.com,
        greentime.hu@sifive.com, andy.chiu@sifive.com, ben@decadent.org.uk,
        linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-riscv@lists.infradead.org, Guo Ren <guoren@linux.alibaba.com>
Subject: Re: [PATCH -next V10 04/10] riscv: entry: Convert to generic entry
In-Reply-To: <CAJF2gTTE_ZtKR6YTDEpF5uXHxUkuZ1PsZoL2Nf3NXpJWca9W7Q@mail.gmail.com>
References: <20221208025816.138712-1-guoren@kernel.org>
 <20221208025816.138712-5-guoren@kernel.org>
 <87tu26w6gn.fsf@all.your.base.are.belong.to.us>
 <CAJF2gTTE_ZtKR6YTDEpF5uXHxUkuZ1PsZoL2Nf3NXpJWca9W7Q@mail.gmail.com>
Date:   Sat, 10 Dec 2022 17:05:47 +0100
Message-ID: <871qp7tfac.fsf@all.your.base.are.belong.to.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Guo Ren <guoren@kernel.org> writes:

>> >  - Little modification on ret_from_fork & ret_from_kernel_thread
>>
>> What changes?
>  ENTRY(ret_from_fork)
> +       call schedule_tail
> +       move a0, sp /* pt_regs */
>         la ra, ret_from_exception
> -       tail schedule_tail
> +       tail syscall_exit_to_user_mode
>  ENDPROC(ret_from_fork)
>
>  ENTRY(ret_from_kernel_thread)
>         call schedule_tail
>         /* Call fn(arg) */
> -       la ra, ret_from_exception
>         move a0, s1
> -       jr s0
> +       jalr s0
> +       move a0, sp /* pt_regs */
> +       la ra, ret_from_exception
> +       tail syscall_exit_to_user_mode
>  ENDPROC(ret_from_kernel_thread)

Thanks for clearing that up! It's more useful to have a descriptive
text, than just "these functions were changed". (Why instead of what)


Cheers,
Bj=C3=B6rn