Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 10 Dec 2022 10:02:43 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
Cc:     linux-renesas-soc@vger.kernel.org,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        John Crispin <john@phrozen.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Marek Vasut <marex@denx.de>,
        Sean Wang <sean.wang@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>,
        Alvin =?utf-8?Q?=C5=A0ipraga?= <alsi@bang-olufsen.dk>,
        Linus Walleij <linus.walleij@linaro.org>,
        UNGLinuxDriver@microchip.com,
        Woojung Huh <woojung.huh@microchip.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        George McCollister <george.mccollister@gmail.com>,
        Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v5 net-next 04/10] dt-bindings: net: dsa: utilize base
 definitions for standard dsa switches
Message-ID: <Y5TJw+zcEDf2ItZ5@euler>
References: <20221210033033.662553-1-colin.foster@in-advantage.com>
 <20221210033033.662553-5-colin.foster@in-advantage.com>
 <1df417b5-a924-33d4-a302-eb526f7124b4@arinc9.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1df417b5-a924-33d4-a302-eb526f7124b4@arinc9.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmxyVG95TXhQZFVIeHdJV0JzUXdqZkFsbVVxYmxYeHZub1JOU1hMUEQxM0Ir?=
 =?utf-8?B?ZTdMTGZINDlqMWxKQ3JNWEkxSjYrWmJ3S3dscXAzRWpvODAvb0dIbzRmazI2?=
 =?utf-8?B?SnVORUFjajBDT3dhajhUQW96VzNrMWVIYWJxc1liUmRlL1Z4VTBLc1AvbHJk?=
 =?utf-8?B?ZFJsRW1pdDdndzZFdWV3Y052NzJ5M1QwYTdSbTJLOGYydkhWM0loRXVROHA0?=
 =?utf-8?B?U2MvSHRsQjhUeVVFK2x1Ryt1QTEwVnFmR0NVYUZtREs2T09nMHFtK3lhVnFs?=
 =?utf-8?B?aURGOURTMWJlTmEwYjFRbkt5cDhVd3k3OWNoOUNzNklkR1NuQlVFamlUV3ZZ?=
 =?utf-8?B?VEtZdG8rTUlhdmZ3K3doeE5aM3hsbGdoTW9zSmtCSlRudVB6ejFKdXJKRjlU?=
 =?utf-8?B?ZisxV00yclN1NjZ3a0JBVzBlTUJVWC9MamgrUmlqejZMUUo5MkszbVRFejR5?=
 =?utf-8?B?ZW4wRkZiNUxoaWxJeHJCSTVjajNYQng0bDZoci9QNVFYZk8yanNUblhHY2hS?=
 =?utf-8?B?TGN5R0poMUVmeTZQQVJEOGtxSUZkRWpXNUtScUJmcTRsTk5wZkxtZXRTMWxX?=
 =?utf-8?B?V0VLVjVSQUhheENKYXo2QTRuZTkzQVp4M2ZzZU93VXlsMlNFRzNGYmFydWkv?=
 =?utf-8?B?NUJnTE5ZbkdnZEFrRFFUTUJCSG04RkdYeXBUcXZpZEg1N2gwL211MjV1djhD?=
 =?utf-8?B?Y2RxTWJMNkQ2T0R5WW54WENnN1B6MUtEUG5iK3dkUmF0MFI5NVNpRW1ndmdy?=
 =?utf-8?B?ejRrR1M0a0dwSktHWk9mclJBWGNyTmNxYjkrVG5Gb1NSN01KbFZjWGJBN3BV?=
 =?utf-8?B?TU52cWxGNUxiKyttcG83OUpoY2xrbmdqSjFUM0ppOUNRS3ZHQzQzSlJ2dllh?=
 =?utf-8?B?cDByN1NKZ0o1OUNQOUMyUzhKVlU4UHd6NlBMWjNXclFyL2dVZXhGbmNldEpo?=
 =?utf-8?B?RnIzTWtYSmd4clZJODBBd084TU5zSW45SXEydSs4YU0xaGJmUFhQWmFDR1NM?=
 =?utf-8?B?NUplaXJXZEpia25uRVEzNGtsZEdyV2tLWXE1czIwQ1ZpaTl3K2tFd0pFWVU0?=
 =?utf-8?B?d25XK1RjYlpSL0EwT0g5YWp6ODlnNlFRM0c2UlBScmtlTk1wYXhDaE1qY2hx?=
 =?utf-8?B?ZEtEa1doRy9rcmkyUnVQK2k4bUJHMWpKTVU1LzZBZjZWUkhnMnBLUHQ0dTQw?=
 =?utf-8?B?ZzEvM08rWFdSNUxzSG44bVhmdWRTVk0xeUVwUDdPUmJZdDYwUkp4dmVSYTRh?=
 =?utf-8?B?MlIvbDVUd3BEc1NwNENXcGdLRnZFbVZxUEE4dk10THAySksxTDNUODUwbzl0?=
 =?utf-8?B?amZ1Y3BmcU1wTDBKWHYyYitCZWdXMVNYeHo1b0RraWdKYlY1Kzhjci9kdU1J?=
 =?utf-8?B?dDFNM2tnRnJNdnJqbWpQZ29NbWUrRUhlYW9uSjJ2d05zb2JoakdSc1lnSlpR?=
 =?utf-8?B?bEhONUpNSnlpVWMyTmJTUE40NTlsa0VKaWR4aXduTGdtZGhIbDBCZUE5cGFs?=
 =?utf-8?B?cHBDVGIwQlp5b0tIUW11L0cxNVp3MHVWS01xUElLUHk3RVZOeGpsK3EzYXU0?=
 =?utf-8?B?K3NmU3h2NjU2MGI5L2ZPRVd2TW9XSmhGdE1oUENTcWxMeEkzYnoxYXlKV25l?=
 =?utf-8?B?eGdvWjdyY3c0MmJmOUtBdFpLdWJPWlpIQTJ5UlA1dHF2WGxqbGNEVjRVaVRF?=
 =?utf-8?B?SkZYRXc4cGJkZTNEN1RPNEpDWDg1WVpOQmFZOTkrUXFPY2pQSE10akw1dEY1?=
 =?utf-8?B?dy80dUhrbjMrZTVOeWNVWXNXMW1HeWZnWW5vK0RoTkloZ2J6ZjhzTFhpaWxE?=
 =?utf-8?B?cEJxNmQwKzFNRFg1K1FkVWdWL2VPcTl6N0FQVlhJcTlYMjlRQ1dSUDBEd3Jy?=
 =?utf-8?B?SDJ6R1JWVllUUXNFd01PMHI0LzdNYWFsaDdTc2JmdmJWV09hNVJrRVltbW9Y?=
 =?utf-8?B?aGlKeFFkV1Q0dmRZWkFZSks2eGxOWWRkOWwyd1ljbm5oSWpRcHZ1T0E4YkNn?=
 =?utf-8?B?WGNRRGVRQUNQajVrM0FuUDRzYjBEN2YvcWRBQ2JuQlVSd1JCSktGU0xES2RO?=
 =?utf-8?B?U29iMHd5WS9hLytUVWI4SFk4T01VbGxCNTFRSW5GaTBqNGQ1aC9Ga3hPSmVk?=
 =?utf-8?B?SEZ2bC83dkFSaGF0S24xSjUzNHdOQjA2ME1SalJLeTc4dzZjYU1QeEJhOFV6?=
 =?utf-8?Q?w2lqkCsEecPypWoX1kbvVAY=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6178d276-0e66-4845-30a4-08dadad8beec
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2022 18:02:47.9474
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ALMRrMXxxxA12SIhVkR1cYWFqESdCSPJ4muZ31MxZTdQ8QJlnvSs0ywX66GT9ksohlII1+z86he4D2uviyNJOi2jLo/QBv82/tm3neIm404=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4897
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arınç,
On Sat, Dec 10, 2022 at 07:24:42PM +0300, Arınç ÜNAL wrote:
> On 10.12.2022 06:30, Colin Foster wrote:
> > DSA a/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> > @@ -58,4 +58,26 @@ oneOf:
> >   additionalProperties: true
> > +$defs:
> > +  ethernet-ports:
> > +    description: A DSA switch without any extra port properties
> > +    $ref: '#/'
> > +
> > +    patternProperties:
> > +      "^(ethernet-)?ports$":
> > +        type: object
> > +        additionalProperties: false
> > +
> > +        properties:
> > +          '#address-cells':
> > +            const: 1
> > +          '#size-cells':
> > +            const: 0
> > +
> > +        patternProperties:
> > +          "^(ethernet-)?port@[0-9]+$":
> > +            description: Ethernet switch ports
> > +            $ref: dsa-port.yaml#
> > +            unevaluatedProperties: false
> 
> I've got moderate experience in json-schema but shouldn't you put 'type:
> object' here like you did for "^(ethernet-)?ports$"?

I can't say for sure, but adding "type: object" here and removing it
from mediatek,mt7530.yaml still causes the same issue I mention below.

Rob's initial suggestion for this patch set (which was basically the
entire implementation... many thanks again Rob) can be found here:
https://lore.kernel.org/netdev/20221104200212.GA2315642-robh@kernel.org/

From what I can tell, the omission of "type: object" here was
intentional. At the very least, it doesn't seem to have any effect on
warnings.

> 
> > +
> >   ...
> > diff --git a/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml b/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml
> > index 73b774eadd0b..748ef9983ce2 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml
> > @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> >   title: Hirschmann Hellcreek TSN Switch Device Tree Bindings
> >   allOf:
> > -  - $ref: dsa.yaml#
> > +  - $ref: dsa.yaml#/$defs/ethernet-ports
> >   maintainers:
> >     - Andrew Lunn <andrew@lunn.ch>
> > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> > index f2e9ff3f580b..20312f5d1944 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> > @@ -157,9 +157,6 @@ patternProperties:
> >       patternProperties:
> >         "^(ethernet-)?port@[0-9]+$":
> >           type: object
> 
> This line was being removed on the previous version. Must be related to
> above.

Without the 'object' type here, I get the following warning:

Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml: patternProperties:^(ethernet-)?ports$:patternProperties:^(ethernet-)?port@[0-9]+$: 'anyOf' conditional failed, one must be fixed:
        'type' is a required property
        '$ref' is a required property
        hint: node schemas must have a type or $ref
        from schema $id: http://devicetree.org/meta-schemas/core.yaml#
./Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml: Error in referenced schema matching $id: http://devicetree.org/schemas/net/dsa/mediatek,mt7530.yaml
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
/home/colin/src/work/linux_vsc/linux-imx/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml: ignoring, error in schema: patternProperties: ^(ethernet-)?ports$: patternProperties: ^(ethernet-)?port@[0-9]+$


I'm testing this now and I'm noticing something is going on with the
"ref: dsa-port.yaml"


Everything seems to work fine (in that I don't see any warnings) when I
have this diff:


diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
index 20312f5d1944..db0122020f98 100644
--- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yam
@@ -156,8 +156,7 @@ patternProperties:

     patternProperties:
       "^(ethernet-)?port@[0-9]+$":
-        type: object
-
+        $ref: dsa-port.yaml#
         properties:
           reg:
             description:
@@ -165,7 +164,6 @@ patternProperties:
               for user ports.

         allOf:
-          - $ref: dsa-port.yaml#
           - if:
               required: [ ethernet ]
             then:


This one has me [still] scratching my head...


> 
> > -        description: Ethernet switch ports
> > -
> > -        unevaluatedProperties: false
> >           properties:
> >             reg:
> 
> Arınç