Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Sat, 10 Dec 2022 08:37:57 -1000
From:   Tejun Heo <tj@kernel.org>
To:     "lilingfeng (A)" <lilingfeng3@huawei.com>
Cc:     linux-kernel@vger.kernel.org, jack@suse.cz, bingjingc@synology.com,
        ebiggers@google.com, james.smart@broadcom.com, houtao1@huawei.com,
        yi.zhang@huawei.com, yangerkun@huawei.com, yukuai3@huawei.com
Subject: Re: [PATCH-next] lib: parser: optimize match_NUMER apis to use local
 array
Message-ID: <Y5TSBUxQPhvngK7J@slm.duckdns.org>
References: <20221209063434.1566682-1-lilingfeng3@huawei.com>
 <Y5No5kMNGGJkmcPn@slm.duckdns.org>
 <8ed91647-f429-493e-b4e1-1f6bf11c228b@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8ed91647-f429-493e-b4e1-1f6bf11c228b@huawei.com>
Precedence: bulk

Hello,

On Sat, Dec 10, 2022 at 10:51:11AM +0800, lilingfeng (A) wrote:
> Thank you for your advice. But I think match_number() is aimed to turn the
> string to num, so maybe it's better to return an error code rather than
> using match_stlcpy() to truncate it to give a wrong num when the string
> is too long to store.

Yeah, so, you check the the returned length and return an error code if the
returned value is too long for the buffer. That's how this family of
functions get error-checked.

> > > +{
> > > +	size_t len = s->to - s->from;
> > > +
> > > +	if (!s->from)
> > > +		return -EINVAL;
> > If we use match_strlcpy() we lose the above null check but given that other
> > match_*() functions aren't doing it, this likely shouldn't matter.
> 
> Like this:
> match_strdup
> ?kmemdup_nul
> ? if (!s) // null check has been done here
> ?? return NULL
> So I think null check may be necessary.

I mean, it's there now but other match functions don't, so it's unlikely
that the NULL check is necessary unless we're saying "parsing this type
string can encounter NULL inputs but these don't". That said, it doesn't
really matter. If you wanna keep the NULL check, do so before calling
strlcpy.

Thanks.

-- 
tejun