Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kevin Groeneveld <kgroeneveld@lenbrook.com>
To:     Abel Vesa <abelvesa@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Cc:     Kevin Groeneveld <kgroeneveld@lenbrook.com>
Subject: [PATCH] clk: imx: pll14xx: fix recalc_rate for negative kdiv
Date:   Sat, 10 Dec 2022 15:38:35 -0500
Message-Id: <20221210203835.9714-1-kgroeneveld@lenbrook.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Qi48sSSIWt6igGaRX4ZJ6rf/NHO4KqIB02YoLHtXao8GV11eMt2YPG8zlAA9?=
 =?us-ascii?Q?2ymLdJKxJtThRyDGmpjGhtK1+MAOOLx69vk+FcS2BLzU50CTxySXHOzipoHo?=
 =?us-ascii?Q?OA1piOWAMrLqVd7f1hxh20qFcmdqDjDttRtB42pw1qpM51/xWB7qwwjtQcUV?=
 =?us-ascii?Q?BnKT7815NjJvtaidZwnWC7wGD9VL+Y9QyO6ruvTOJSbZURJN22hBXGX5CfH6?=
 =?us-ascii?Q?3zh4d+yVlocQjOi9d9O4kuvuObfEzfmRPTSPuSVLHvdzZV9096CadslQmV3U?=
 =?us-ascii?Q?3PYA9dXCn8Ba5sq1nVQYuJSC8J9Vv1zUZCwNW7++sWzE1NCYlMwz5+LZ0ykO?=
 =?us-ascii?Q?O0cTQpliOSFjp7oKhtWWd8Qk7WNF/kbhfGX830m7G2Fk+pV9z4+3jwMbvYDV?=
 =?us-ascii?Q?6pQEjyCIcOogpv8xsb6jwElrWm+FIO9CtXjZh/Au7siZszBwuvVKkrMxAiN7?=
 =?us-ascii?Q?bP+iPGvWrmRmdyGzi+WzR2Acjd/27/1tkJ0LRPq8/aglqC1276LrTZ6N1DPy?=
 =?us-ascii?Q?C8xB4JZUQ1scV6zL5Z0LNDjljvbXdAig8AifSUZzHugj2LQfPmL6CTG/MwjP?=
 =?us-ascii?Q?RLW/ryGCK7Yff64O56GOhRmadothTKjEb6Fayh/EQfoDuq1uS7KGWx4an46a?=
 =?us-ascii?Q?a8Gyq+0Nb33Yfnc2Olhzebs97O45Y2VL64FfvI1GJ7T8R75EiACnkqePQS7f?=
 =?us-ascii?Q?mltUzirDcnbnxg6HoFRaABjFLz2VUkd/6TBZXFBqaN94cbymlaTsUGHQZtj4?=
 =?us-ascii?Q?0ySEJ7Cqpg6mHwRwh+8/vEVG1A+JNRvuULeyhH+bcqqyQmG4WX+NaftlL+21?=
 =?us-ascii?Q?pap/u2PyT0zRvVJ4ulcnDwvQcXMGci4a11Om8HdY/N6aNTIc+8A572psTvTe?=
 =?us-ascii?Q?GpnoOk3WIfPH3ZWIu/lZ4RFowarPQC/IZwwNu949es7wLwhz94pcb/NTFalC?=
 =?us-ascii?Q?lvz3DaHvlUmJE2wQk+Y0+Hz2mFy6Ps9zleTjiuR0QKBDvcqoiqn1/XC+cD5a?=
 =?us-ascii?Q?xt4J6azrxUpCRID6zVWLQZvjw1EcwgWo2R6bfoBv/S6rWw3BSoWRlgXwFxfp?=
 =?us-ascii?Q?CWEbuof6qT+0mSYTpRxxhJwahqb76FjqV6NW82dAhScytAV0SUYeg50xVMUw?=
 =?us-ascii?Q?CPVW35yyEN5s9nbg3qi4dRPHssuYJEVzlAGSze3HGGq2dlXcUYnEMzkALhNP?=
 =?us-ascii?Q?Vdug8iMSJs7hAOi8c8j21xGzxayKlImwEo203io67zgx1RbaonaSv38RkkMo?=
 =?us-ascii?Q?prRsqQF4oR2MxTwAbiNLotdYuFplfomVfuumXYeXX4fxvql1ILTD6rGtvGD2?=
 =?us-ascii?Q?1BCdeHWwDAtMgkuFXRIJttTRW+LABgE3kDGF3OoopwQcsunZEXYVav+eP6fs?=
 =?us-ascii?Q?cdo2iQg7jVcCwJoFsr+1eUUb10mNsL0Iz1CC0957Jz9PDeMwOISlMnUcGlWZ?=
 =?us-ascii?Q?yWlVbHixEOGpP+Rtag98MixIEv5D7j6pX0f2g2eigxaUB4rXwephxgtu3/du?=
 =?us-ascii?Q?uCRB2Ng8cPxwTYexQj3eJmV7d+MATARaFQleYuKHAIcgFz+0KbO14vMh/deH?=
 =?us-ascii?Q?0VEoAVAZqUxjk/4PsI2tI49e1M9LJ3mHmpZdRZ5fwNWFfz/hrLQK9P50UkTm?=
 =?us-ascii?Q?yQ=3D=3D?=
X-OriginatorOrg: lenbrook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1804bd33-8a29-46fd-45f9-08dadaee9ed4
X-MS-Exchange-CrossTenant-AuthSource: YT4PR01MB9670.CANPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2022 20:39:22.9067
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3089fb55-f9f3-4ac8-ba44-52ac0e467cb6
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KrrYT9iI9yUiud26KlrbYTwUjaLtJkULtiZHB34faijrdNpF/xRDfzL12eDN8dcp1zDWNRKippJI895LMvmHeSAAb8E0b2Ic41D3Monuryo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB5880
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

kdiv is a signed 16 bit value in the DEV_CTL1 register. Commit
53990cf9d5b4 ("clk: imx: pll14xx: consolidate rate calculation") changed
the kdiv variable from a short int to just int. When the value read from
the DIV_CTL1 register is assigned directly to an int the sign of the value
is lost resulting in incorrect results when the value is negative. Adding
a s16 cast to the register value fixes the issue.

Fixes: 53990cf9d5b4 ("clk: imx: pll14xx: consolidate rate calculation")
Signed-off-by: Kevin Groeneveld <kgroeneveld@lenbrook.com>
---
 drivers/clk/imx/clk-pll14xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c
index 1d0f79e9c346..d12194d17b10 100644
--- a/drivers/clk/imx/clk-pll14xx.c
+++ b/drivers/clk/imx/clk-pll14xx.c
@@ -254,7 +254,7 @@ static unsigned long clk_pll14xx_recalc_rate(struct clk_hw *hw,
 
 	if (pll->type == PLL_1443X) {
 		pll_div_ctl1 = readl_relaxed(pll->base + DIV_CTL1);
-		kdiv = FIELD_GET(KDIV_MASK, pll_div_ctl1);
+		kdiv = (s16)FIELD_GET(KDIV_MASK, pll_div_ctl1);
 	} else {
 		kdiv = 0;
 	}
-- 
2.17.1