Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221204043530.1673752-1-jiucheng.xu@amlogic.com> <6e0dcfa8-6855-cc80-5e23-443d44cae07b@linaro.org>
In-Reply-To: <6e0dcfa8-6855-cc80-5e23-443d44cae07b@linaro.org>
From:   Chris Healy <cphealy@gmail.com>
Date:   Sat, 10 Dec 2022 12:47:13 -0800
Message-ID: <CAFXsbZr8yLOy2MnhX2SaCECY38DHcfpS1pOu3tZvt3xNBuH6HQ@mail.gmail.com>
Subject: Re: [PATCH] arm64: defconfig: Add Meson DDR PMU as module
To:     neil.armstrong@linaro.org
Cc:     Jiucheng Xu <jiucheng.xu@amlogic.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Jianxin Pan <jianxin.pan@amlogic.com>,
        Kelvin Zhang <kelvin.zhang@amlogic.com>,
        Chris Healy <healych@amazon.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        "linux-amlogic@lists.infradead.org" 
        <linux-amlogic@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Dec 5, 2022 at 12:40 AM Neil Armstrong
<neil.armstrong@linaro.org> wrote:
>
> +CC linux-amlogic@lists.infradead.org
>
> On 04/12/2022 05:35, Jiucheng Xu wrote:
> > Add Meson DDR PMU to defconfig so that build errors are caught.
> >
> > Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com>
> > ---
> >   arch/arm64/configs/defconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 0b6af3348e79..f2324b54a6ba 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1265,6 +1265,7 @@ CONFIG_ARM_DMC620_PMU=m
> >   CONFIG_QCOM_L2_PMU=y
> >   CONFIG_QCOM_L3_PMU=y
> >   CONFIG_HISI_PMU=y
> > +CONFIG_MESON_DDR_PMU=m

Given that the other vendor specific PMU counter drivers are being
configured as built-in, perhaps it makes more sense to do the same
with the new MESON DDR PMU driver and also set it to "y"?

> >   CONFIG_NVMEM_IMX_OCOTP=y
> >   CONFIG_NVMEM_IMX_OCOTP_SCU=y
> >   CONFIG_NVMEM_MTK_EFUSE=y
>