Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 10 Dec 2022 22:02:48 +0100
From:   Nicolas Schier <nicolas@fjasle.eu>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Alexander Lobakin <alexandr.lobakin@intel.com>,
        linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH v3 3/5] kbuild: add read-file macro
Message-ID: <Y5Tz+MBfYMVkqAn3@fjasle.eu>
References: <20221126225624.751661-1-masahiroy@kernel.org>
 <20221126225624.751661-3-masahiroy@kernel.org>
 <20221207154044.2181347-1-alexandr.lobakin@intel.com>
 <20221207162208.2200189-1-alexandr.lobakin@intel.com>
 <CAK7LNAQbGaXDRzeByOcJhMX4y-ShA6Qtpcqhr4gNZ5t8vX-PPw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK7LNAQbGaXDRzeByOcJhMX4y-ShA6Qtpcqhr4gNZ5t8vX-PPw@mail.gmail.com>
UI-OutboundReport: notjunk:1;M01:P0:AhPU3HFi/yg=;BQgylnf9syDxKYtQpyLisUDJliE
 Vg9P3oFbpoaClJSTdY7aCKIoHWJPNRQwl0jSjwqbPRnGM4gyxrxwfM8O+tJLRGQTlNv293Ynx
 4r/Smwn0AQ3RcCW9Sgjx0S3MOAwIv00+x1XBDDnvNPe3ElqIcE/xAEsjHckaf2W8XGNJ3HHUL
 7dzsHMGEadqDR8lOgyHtp7rCQ8u2rrUEMir1egY1BiSYbzV0liuFSyrEJpfHdzdOLl9GmjfHk
 qw9TOH8jIFZxYP8qdbOxCPLz1HnNBEvXsHi87pctdTKPBmvVe39RtRj37ogqD5sI49/sbSs4s
 4MIhctyGL921dxFkyR4To24N9F+0u8qbx1I78rDrQcA3Ne3Mj2af3HoLqkjLCHNyjd161WSWT
 uAFuY4Ma4aDtJgfSwv9MonNHZ4KkZqfQjIXNy6x8PHOl8t8ba1xQSwaCI2RHbbqhIH6+4yNYm
 vt2tcbZovCbfgp4RXp4EF/6j4hhSDCWVIGlJ+maVGWvzFDwz4vpFMiob2VzNXLI5mcnjJQ0rL
 422JdlZl8FNKYkfRmhSxz0+Jv2og+VqDwFA7R79/NwlhYegEhufxVs2+nJogUnEUrXwfIQKZT
 BZwOLI9iLgIOrmM6qNtFxdPiSy9b+bRsMNM+BdSUdhLpU481ny5Jh3JfHy6uRRP7c+D3J0MOI
 uWiU0f0GePIokuJPZ1gTi9zi3Zh5QrUdN0+AZXRorg==
Precedence: bulk

On Sat, Dec 10, 2022 at 11:10:12PM +0900 Masahiro Yamada wrote:
> On Thu, Dec 8, 2022 at 1:25 AM Alexander Lobakin
> <alexandr.lobakin@intel.com> wrote:
> >
> > From: Alexander Lobakin <alexandr.lobakin@intel.com>
> > Date: Wed, 7 Dec 2022 16:40:44 +0100
> >
> > > From: Masahiro Yamada <masahiroy@kernel.org>
> > > Date: Sun, 27 Nov 2022 07:56:22 +0900
> > >
> > > > Since GNU Make 4.2, $(file ...) supports the read operater '<', which
> > > > is useful to read a file without forking any process. No warning is
> > > > shown even if the input file is missing.
> >
> > [...]
> >
> > > Great stuff. Used it in my upcoming series to simplify things, works
> > > as expected.
> > >
> > > sed-syms = $(subst $(space),\|,$(foreach file,$(sym-files-y),$(call read-file,$(file))))
> > >
> > > The only thing that came to my mind while I was implementing the
> > > oneliner above: maybe add ability to read multiple files? For now,
> > > I used a foreach, could it be somehow incorporated into read-file
> > > already?
> >
> > Oh, nevermind. This one also works:
> >
> > sed-syms = $(subst $(space),\|,$(call read-file,$(sym-files-y)))
> >
> > So I believe read-file works for an arbitrary number of files.
> 
> 
> 
> Really?
> 
> 
> In my understanding, $(call read-file, foo bar) reads a single file "foo bar".
> (a space in the file name).

yes, except for make < 4.2, due to:

read-file = $(shell cat $1 2>/dev/null)