Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <be3f9f0f68ce371b1a3837d21146daa25ebe77a0.camel@codeconstruct.com.au>
Subject: Re: [RFC PATCH v2 2/3] regmap: mmio: allow reset control in a MMIO
 regmap
From:   Jeremy Kerr <jk@codeconstruct.com.au>
To:     Mark Brown <broonie@kernel.org>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Philipp Zabel <p.zabel@pengutronix.de>
Date:   Sun, 11 Dec 2022 10:23:26 +0800
In-Reply-To: <Y5MvOp7kLoEJfwkk@sirena.org.uk>
References: <20221209013309.407879-1-jk@codeconstruct.com.au>
         <20221209013309.407879-3-jk@codeconstruct.com.au>
         <Y5MvOp7kLoEJfwkk@sirena.org.uk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.1-1 
MIME-Version: 1.0
Precedence: bulk

Hi Mark,

> > A syscon device may need to be taken out of reset before functioning
> > - this change adds a facility to attach a reset control to a mmio
> > regmap, and performs the necessary deassert/assert operations on the
> > reset controller on attach/detach.
>=20
> Managment of reset feels like something that should be done at a
> higher level - typically reset also implies losing all the register
> contents which means it should be somewhere above the cache layer.

Yep, that makes sense. I'll rework to do the reset controller handling
in the syscon layer instead - unless there are any objections to that?

Cheers,


Jeremy