Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <361c0911-7133-4d28-436e-1dfab2b807a8@wanadoo.fr>
Date:   Sun, 11 Dec 2022 07:54:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 3/3] regulator: axp20x: Add support for AXP1530 variant
Content-Language: fr
To:     martin.botka@somainline.org
Cc:     angelogioacchino.delregno@somainline.org, broonie@kernel.org,
        devicetree@vger.kernel.org, jamipkettunen@somainline.org,
        jtrmal@gmail.com, konrad.dybcio@somainline.org,
        krzysztof.kozlowski+dt@linaro.org, lee@kernel.org,
        lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
        marijn.suijten@somainline.org, martin.botka1@gmail.com,
        paul.bouchara@somainline.org, robh+dt@kernel.org,
        takuya@takuya.tech, wens@csie.org
References: <20221209234654.1082522-1-martin.botka@somainline.org>
 <20221209234654.1082522-4-martin.botka@somainline.org>
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <20221209234654.1082522-4-martin.botka@somainline.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 10/12/2022 à 00:46, Martin Botka a écrit :
> AXP1530 has a few regulators that are controlled via I2C Bus.
> 
> Add support for them.
> 
> Signed-off-by: Martin Botka <martin.botka-KtrmGDJU8+nZ+VzJOa5vwg@public.gmane.org>
> ---
>   drivers/regulator/axp20x-regulator.c | 44 ++++++++++++++++++++++++++++
>   1 file changed, 44 insertions(+)
> 
> diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
> index d260c442b788..ca422311a996 100644
> --- a/drivers/regulator/axp20x-regulator.c
> +++ b/drivers/regulator/axp20x-regulator.c

[...]

> @@ -1252,6 +1292,10 @@ static int axp20x_regulator_probe(struct platform_device *pdev)
>   		drivevbus = of_property_read_bool(pdev->dev.parent->of_node,
>   						  "x-powers,drive-vbus-en");
>   		break;
> +		case AXP1530_ID:

Nit: indentation.

> +		regulators = axp1530_regulators;
> +		nregulators = AXP1530_REG_ID_MAX;
> +		break;
>   	default:
>   		dev_err(&pdev->dev, "Unsupported AXP variant: %ld\n",
>   			axp20x->variant);