Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 11 Dec 2022 12:12:16 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc:     <ye.xingchen@zte.com.cn>, <andriy.shevchenko@linux.intel.com>,
        <lars@metafoo.de>, <u.kleine-koenig@pengutronix.de>,
        <petrm@nvidia.com>, <olteanv@gmail.com>,
        <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: bma180: Convert to use sysfs_emit_at() API
Message-ID: <20221211121216.33006598@jic23-huawei>
In-Reply-To: <20221207095614.z4gv3q76hfx47qs2@CAB-WSD-L081021>
References: <202212071003192805636@zte.com.cn>
        <20221207095614.z4gv3q76hfx47qs2@CAB-WSD-L081021>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 7 Dec 2022 12:56:14 +0300
Dmitry Rokosov <ddrokosov@sberdevices.ru> wrote:

> On Wed, Dec 07, 2022 at 10:03:19AM +0800, ye.xingchen@zte.com.cn wrote:
> > From: ye xingchen <ye.xingchen@zte.com.cn>
> > 
> > Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> > should only use sysfs_emit() or sysfs_emit_at() when formatting the
> > value to be returned to user space.
> > 
> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>  
> 
> I think it would be better, if you provide one cover letter as 0/3 patch
> and three nested real patches to each iio/accel driver which you want to
> rework: adxl372, bma180, mma8452. Or fix all iio drivers (no only accel)
> and send all of these changes as nested patches for one cover letter.
> 
> Please refer to https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> 
> and use the following commands to generate such patches hierarchy:
> 
> $ git format-patch --cover-letter -o patches ...
> $ git send-email \     
>       --annotate \               
>       --to="john.doe@kernel.org" \               
>       --cc="linux-iio@vger.kernel.org" \
>       --cc="linux-kernel@vger.kernel.org" \
>       --smtp-debug 1 \                  
>       patches/*

Second this comment - also mark it at least v3 as some of these
patches will be on their 3rd version.

One major advantage of such a series is that a reply to the cover letter
can be used to indicate that someone is giving a tag for all the patches
underneath it.  Right now they'd have to reply to every single email.

So please send a v3 with all the similar IIO patches under a single cover
letter.  Make sure to gather tags from earlier versions.

Thanks,

Jonathan

> 
> > ---
> >  drivers/iio/accel/bma180.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
> > index eb697eeb4301..9e3e5dfdded7 100644
> > --- a/drivers/iio/accel/bma180.c
> > +++ b/drivers/iio/accel/bma180.c
> > @@ -488,8 +488,7 @@ static ssize_t bma180_show_avail(char *buf, const int *vals, unsigned int n,
> >  	for (i = 0; i < n; i++) {
> >  		if (!vals[i])
> >  			continue;
> > -		len += scnprintf(buf + len, PAGE_SIZE - len,
> > -			micros ? "0.%06d " : "%d ", vals[i]);
> > +		len += sysfs_emit_at(buf, len, micros ? "0.%06d " : "%d ", vals[i]);
> >  	}
> >  	buf[len - 1] = '\n';
> > 
> > -- 
> > 2.25.1  
>