Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 11 Dec 2022 12:15:06 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     ye.xingchen@zte.com.cn, lars@metafoo.de, linmq006@gmail.com,
        u.kleine-koenig@pengutronix.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: magnetometer: bmc150_magn: Convert to use
 sysfs_emit_at() API
Message-ID: <20221211121506.4d694c74@jic23-huawei>
In-Reply-To: <CAHp75VfJx84-J2GdOWQAPAtMhPVS3X-dEuHYQqyP4a0WjDsgdQ@mail.gmail.com>
References: <202212071549349412843@zte.com.cn>
        <CAHp75VfJx84-J2GdOWQAPAtMhPVS3X-dEuHYQqyP4a0WjDsgdQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 7 Dec 2022 10:46:14 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Wed, Dec 7, 2022 at 9:49 AM <ye.xingchen@zte.com.cn> wrote:
> >
> > From: ye xingchen <ye.xingchen@zte.com.cn>
> >
> > Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> > should only use sysfs_emit() or sysfs_emit_at() when formatting the
> > value to be returned to user space.  
> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmai.com>
> 
> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> > ---
> >  drivers/iio/magnetometer/bmc150_magn.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c
> > index 06d5a1ef1fbd..1398684a7f30 100644
> > --- a/drivers/iio/magnetometer/bmc150_magn.c
> > +++ b/drivers/iio/magnetometer/bmc150_magn.c
> > @@ -598,8 +598,7 @@ static ssize_t bmc150_magn_show_samp_freq_avail(struct device *dev,
> >         for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); i++) {
> >                 if (bmc150_magn_samp_freq_table[i].freq > data->max_odr)
> >                         break;
> > -               len += scnprintf(buf + len, PAGE_SIZE - len, "%d ",
> > -                                bmc150_magn_samp_freq_table[i].freq);
> > +               len += sysfs_emit_at(buf, len, "%d ", bmc150_magn_samp_freq_table[i].freq);
> >         }

I'd prefer we keep the line break before the last parameter.

Generally in IIO at least, preference is for < 80 chars except where readability is
significantly enhanced by a longer line.  That's not true in this case.

Jonathan


> >         /* replace last space with a newline */
> >         buf[len - 1] = '\n';
> > --
> > 2.25.1  
> 
> 
>