Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 11 Dec 2022 18:14:41 +0100
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     Kees Cook <keescook@chromium.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     linux-hardening@vger.kernel.org,
        Nick Desaulniers <ndesaulniers@google.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel test robot <lkp@intel.com>,
        Romain Perier <romain.perier@gmail.com>, llvm@lists.linux.dev,
        Tom Rix <trix@redhat.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Daniel Palmer <daniel@thingy.jp>, linux-rtc@vger.kernel.org
Subject: Re: [PATCH v2] rtc: msc313: Fix function prototype mismatch in
 msc313_rtc_probe()
Message-ID: <167077884687.347026.2422549159298910618.b4-ty@bootlin.com>
References: <20221202184525.gonna.423-kees@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221202184525.gonna.423-kees@kernel.org>
Precedence: bulk

On Fri, 2 Dec 2022 10:45:30 -0800, Kees Cook wrote:
> With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG),
> indirect call targets are validated against the expected function
> pointer prototype to make sure the call target is valid to help mitigate
> ROP attacks. If they are not identical, there is a failure at run time,
> which manifests as either a kernel panic or thread getting killed.
> 
> msc313_rtc_probe() was passing clk_disable_unprepare() directly, which
> did not have matching prototypes for devm_add_action_or_reset()'s
> callback argument. Refactor to use devm_clk_get_enabled() instead.
> 
> [...]

Applied, thanks!

[1/1] rtc: msc313: Fix function prototype mismatch in msc313_rtc_probe()
      commit: 21b8a1dd56a163825e5749b303858fb902ebf198

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com