Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 11 Dec 2022 23:14:35 +0100
From:   Jean Delvare <jdelvare@suse.de>
To:     Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= 
        <u.kleine-koenig@pengutronix.de>
Cc:     Sean Young <sean@mess.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pwm@vger.kernel.org
Subject: Re: [PATCH] media: rc: Drop obsolete dependencies on COMPILE_TEST
Message-ID: <20221211231435.43c4f361@endymion.delvare>
In-Reply-To: <20221211205648.hdv5haufqwfoxzu2@pengutronix.de>
References: <20221121170911.7cd72bfc@endymion.delvare>
        <20221211205648.hdv5haufqwfoxzu2@pengutronix.de>
Organization: SUSE Linux
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hallo Uwe,

On Sun, 11 Dec 2022 21:56:48 +0100, Uwe Kleine-K=C3=B6nig wrote:
> On Mon, Nov 21, 2022 at 05:09:11PM +0100, Jean Delvare wrote:
> > --- linux-6.0.orig/drivers/media/rc/pwm-ir-tx.c
> > +++ linux-6.0/drivers/media/rc/pwm-ir-tx.c
> > @@ -120,7 +120,7 @@ static struct platform_driver pwm_ir_dri
> >  	.probe =3D pwm_ir_probe,
> >  	.driver =3D {
> >  		.name	=3D DRIVER_NAME,
> > -		.of_match_table =3D of_match_ptr(pwm_ir_of_match),
> > +		.of_match_table =3D pwm_ir_of_match,
> >  	},
> >  };
> >  module_platform_driver(pwm_ir_driver); =20
>=20
> That hunk makes sense even without the Kconfig change. ACPI makes use of
> .of_match_table, so
>=20
> 	.of_match_table =3D of_match_ptr(pwm_ir_of_match),
>=20
> is (almost?) always wrong.

Should we just get rid of this macro altogether then?

(Somehow I have a strange feeling that we already had this
discussion...)

--=20
Jean Delvare
SUSE L3 Support