Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5885862rwb; Sun, 11 Dec 2022 14:43:41 -0800 (PST) X-Google-Smtp-Source: AA0mqf4BKVYcp48qfOGdb0iawZ4dnlG/3Lqu6vyZn8PzOl6gfkWiFbMJIOQsEhG2qUKoPVQ3fwJU X-Received: by 2002:a17:906:4e9a:b0:7c0:b292:e56b with SMTP id v26-20020a1709064e9a00b007c0b292e56bmr10319774eju.68.1670798621594; Sun, 11 Dec 2022 14:43:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670798621; cv=none; d=google.com; s=arc-20160816; b=Zncxj3cQizIBhYMxLauE2XRZw6xTVSzcIy8+o4v34A5lEMj21luFDxX5Pa2GK65NGi vnVscMBP6/LSXaXLDub/NieVZjcNbSXbNhLEyGtX1NLtKE/TAFLQqBLjiYDutqCnU2S2 WaDKaDAcLj7x8ElYFLU0Z60H/qg6Q4R37B2HXWTBjy7YqsRTzjDzaT67csI/J/PmFdVs bI6JTMPzSoKACDYf0PntnFuLWIFAGUcGulbOekAjMkZMhx13dRfXs+O0SNSe4zzignO/ J3xkSkI7Av9ZKhuR9MVII9d3/pLjZYHafbqFTI1WeTP1Xdt9UBtF3V3gslevz8kvuFQa nmgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=pSMLLAxVMXnoWPwPea+ElcFQc/uDEfReQyP/onbm6ts=; b=b5memtItC5KZNRUVMAZKaiyIOVaO5T6xZivKx8ftXqKbDAKDwFrYgN/hfBjwOopGW2 HeFXC7HGegYCsAl+cPSZxsUdpYEGh5N4mewIN9SuEymDyE+P26gAB7JGQfTQteQLbT5H n6iqLi4DguaZM/WoWJwE18aPu6R3RV+9OpDq7PoGz4790rRU/S+VGMrvS0uIGn+JpxvF e4EQGmGveaL+Wy/syDoNtj9lo0+FzS16ec6//3X4WwCUXHB9Qr7E2RFvohTWPHELQb9h KlFDSHpa4LLL6W3DrDwKp4p6QBEDV9nEMC52BJWJyaMdfef4xY1U5IR6M/TUrDptF61Q YhCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KnQFdeff; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ss26-20020a170907c01a00b0078de51e1c3dsi3869800ejc.840.2022.12.11.14.43.21; Sun, 11 Dec 2022 14:43:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KnQFdeff; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230344AbiLKWXL (ORCPT + 76 others); Sun, 11 Dec 2022 17:23:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230310AbiLKWXD (ORCPT ); Sun, 11 Dec 2022 17:23:03 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 029CB7677 for ; Sun, 11 Dec 2022 14:21:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670797273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pSMLLAxVMXnoWPwPea+ElcFQc/uDEfReQyP/onbm6ts=; b=KnQFdeff+5chuWd8wsL2UplGeNRbISEO8JDrxjyVb37wIm6usnAlT/ncf2eEIOb/JnzMnk DJ3SHnOhkn8D2v4S4i8DT9XGbCqt3oZWTCURmc8mRlCFBCdPm/ooCglxnriX258cC7w4yw 3WyZzZWqF6GoSnTpSCk5lmLCvEzDGWI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-589-cZw5i59hMJqVW7MRZaco6g-1; Sun, 11 Dec 2022 17:21:07 -0500 X-MC-Unique: cZw5i59hMJqVW7MRZaco6g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ED062101A52A; Sun, 11 Dec 2022 22:21:06 +0000 (UTC) Received: from llong.com (unknown [10.22.16.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1F8101121331; Sun, 11 Dec 2022 22:21:06 +0000 (UTC) From: Waiman Long To: Jens Axboe , Tejun Heo , Josef Bacik , Zefan Li , Johannes Weiner , Andrew Morton Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, =?UTF-8?q?Michal=20Koutn=C3=BD?= , "Dennis Zhou (Facebook)" , Waiman Long Subject: [PATCH-block v2 0/3] blk-cgroup: Fix potential UAF & miscellaneous cleanup Date: Sun, 11 Dec 2022 17:20:55 -0500 Message-Id: <20221211222058.2946830-1-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org v2: - Remove unnecessary rcu_read_{lock|unlock} from cgroup_rstat_css_cpu_flush() in patch 3. It was found that blkcg_destroy_blkgs() may be called with all blkcg references gone. This may potentially cause user-after-free and so should be fixed. The last 2 patches are miscellaneous cleanups of commit 3b8cc6298724 ("blk-cgroup: Optimize blkcg_rstat_flush()"). Waiman Long (3): bdi, blk-cgroup: Fix potential UAF of blkcg blk-cgroup: Don't flush a blkg if destroyed blk-cgroup: Flush stats at blkgs destruction path block/blk-cgroup.c | 26 ++++++++++++++++++++++++++ include/linux/cgroup.h | 1 + kernel/cgroup/rstat.c | 18 ++++++++++++++++++ mm/backing-dev.c | 8 ++++++-- 4 files changed, 51 insertions(+), 2 deletions(-) -- 2.31.1