Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Sun, 11 Dec 2022 16:17:06 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     torvalds@linux-foundation.org, mingo@redhat.com,
        peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com, ast@kernel.org,
        daniel@iogearbox.net, andrii@kernel.org, martin.lau@kernel.org,
        joshdon@google.com, brho@google.com, pjt@google.com,
        derkling@google.com, haoluo@google.com, dvernet@meta.com,
        dschatzberg@meta.com, dskarlat@cs.cmu.edu, riel@surriel.com,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
        kernel-team@meta.com
Subject: Re: [PATCH] sched_ext: use msecs_to_jiffies consistently
Message-ID: <Y5aPImWzkhIY0CuR@slm.duckdns.org>
References: <alpine.DEB.2.22.394.2212112334020.29296@hadrien>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2212112334020.29296@hadrien>
Precedence: bulk

On Sun, Dec 11, 2022 at 11:43:30PM +0100, Julia Lawall wrote:
> The watchdog's timeout is processed by msecs_to_jiffies when it is
> checked, but not when the delay for running the watchdog is set.  The
> watchdog will thus run at a time that is later than that time at which it
> is checked that it has run, and the scheduler aborts.
> 
> Add the needed calls to msecs_to_jiffies.
> 
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> 
> ---
> 
> Another solution would be to use jiffies everywhere.

Yeah, that was how David Vernet implemented it in the first place and I
insisted on using non-jiffies unit, which clearly seems like a mistake. I
think the right thing to do here is using jiffies for everything.

Thanks.

-- 
tejun