Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6264713rwb; Sun, 11 Dec 2022 22:31:14 -0800 (PST) X-Google-Smtp-Source: AA0mqf7K+UKdpzLQvMNiQ3Ly5u/Kd3bMoRZiTS0ykcceNTbgbGp/5QWWQSiSesH+nt8o9wM9kB7b X-Received: by 2002:a17:906:5f82:b0:7c0:dac7:36ea with SMTP id a2-20020a1709065f8200b007c0dac736eamr12512821eju.66.1670826673871; Sun, 11 Dec 2022 22:31:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670826673; cv=none; d=google.com; s=arc-20160816; b=OaDkKt0qZElM9hYY2hMkFBfxLhOPgvONeJ6ECUydCF1pFXYMDvZ1hZu6+fOGQ4yaA6 XtRW7u4Dwad3ACr1NX2zcQth6OfAfhvCSqDdfDniNBHfrzOrervtN2OTiIR1rYNMMvHs KFaWY0kjq9GGdGVqUgBkvlOQ3g4EvaDKAJtadOkLdjwVuwWW9wDsEBQ9XcF4CaKazERS 7Co3pyB1tBXoHmVBuwavWhz/8W0bgx9xIzpzVDks5DkVN/kjVSrOg+6SsWarQsa0zjFT sAXnmH5E+9RZYvE/80qWOvmujsKxA21ZtqS2Czwo21vMbN+2yCcHLtwEQgWffiC5CKYv QAjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0bUyP4Wcynq8EDAYfjGPh5sKyxyy+JRtBVzEHfazEj0=; b=eoRjREXLm0cWrIw1AnYzdee7K8Z33+wuMPebSwNnxwltoAqk6pGid1pnysZKftzBiG IJ3070V2vGDhppDhK5VOLdByH9TwK3BG4ZP4Oqc6BEWCkQH6765mBzNfxg/bJr9KkZEo n6IStaCbsXYYB/QV5j6NNAjx4llnRUnmwG3lmetJAGhfFvz9FYIlnbgChJDAE8PvLtct 4dYz9WD33RrMwhslaB3eJHQNmVcUeYjxyi0bt4RQP0pN7ZoJCO4APLrr1dVLj897uxDS uIKhqpDKanGmxs7YOXQonh1agR109P5FhxrFuqOC0Sc+K3gv0brc1LvmGpnb95lRuJD5 /duA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WM0p9cjR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fj3-20020a1709069c8300b0073d71124609si5386843ejc.182.2022.12.11.22.30.55; Sun, 11 Dec 2022 22:31:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WM0p9cjR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231281AbiLLGMJ (ORCPT + 77 others); Mon, 12 Dec 2022 01:12:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231249AbiLLGMF (ORCPT ); Mon, 12 Dec 2022 01:12:05 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8059CE20; Sun, 11 Dec 2022 22:12:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6C2B4B80B72; Mon, 12 Dec 2022 06:12:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F0E0C433EF; Mon, 12 Dec 2022 06:12:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670825522; bh=HNQ+jgM7nK49r0QXRAxcWzevnlOGKXqz3QgiETxRhHc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WM0p9cjRA54uIuhCbl3bNcjmtBqXqjXOC3mdqoTPMfXNGFGVY+p2LjDHubsqAvGNB dtfxv2dYaZK0bzf5t8f37JjGjSbnHHD6vnwMO8yrTT4w13cgZukg1Dg/Y2fB2b3TAR 5LSj2GE832dWK6oLrVDYpmOMou+L9g4VWVxl5Pls= Date: Mon, 12 Dec 2022 07:11:58 +0100 From: Greg Kroah-Hartman To: Andrew Donnellan Cc: Nayna , Nayna Jain , linuxppc-dev@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-efi@vger.kernel.org, linux-security-module , linux-kernel@vger.kernel.org, Michael Ellerman , npiggin@gmail.com, christophe.leroy@csgroup.eu, Dov Murik , George Wilson , Matthew Garrett , Dave Hansen , Benjamin Herrenschmidt , Paul Mackerras , Russell Currey , Stefan Berger , "Serge E. Hallyn" , "Ritesh Harjani (IBM)" Subject: Re: [PATCH 2/4] fs: define a firmware security filesystem named fwsecurityfs Message-ID: References: <20221106210744.603240-1-nayna@linux.ibm.com> <20221106210744.603240-3-nayna@linux.ibm.com> <8447a726-c45d-8ebb-2a74-a4d759631e64@linux.vnet.ibm.com> <20221119114234.nnfxsqx4zxiku2h6@riteshh-domain> <6f2a4a5f-ab5b-8c1b-47d5-d4e6dca5fc3a@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 12, 2022 at 11:58:56AM +1100, Andrew Donnellan wrote: > On Wed, 2022-11-23 at 13:57 -0500, Nayna wrote: > > > > Given there are no other exploiters for fwsecurityfs and there should > > be > > no platform-specific fs, would modifying sysfs now to let userspace > > create files cleanly be the way forward? Or, if we should strongly > > consider securityfs, which would result in updating securityfs to > > allow > > userspace creation of files and then expose variables via a more > > platform-specific directory /sys/kernel/security/pks? We want to pick > > the best available option and would find some hints on direction > > helpful > > before we develop the next patch. > > Ping - it would be helpful for us to know your thoughts on this. sysfs is not for userspace creation of files, you all know this :) greg k-h