Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221211144722.754398-1-tegongkang@gmail.com> <f04435d8-9af3-1fde-c2bf-fadd045b10a1@gmail.com>
In-Reply-To: <f04435d8-9af3-1fde-c2bf-fadd045b10a1@gmail.com>
From:   Kang Minchul <tegongkang@gmail.com>
Date:   Mon, 12 Dec 2022 16:19:56 +0900
Message-ID: <CA+uqrQBfS4J7r==za_82ddErGXVK+smJaMjbhPq6DByDWYyC-g@mail.gmail.com>
Subject: Re: [PATCH] net: ipa: Remove redundant dev_err()
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Alex Elder <elder@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2022=EB=85=84 12=EC=9B=94 12=EC=9D=BC (=EC=9B=94) =EC=98=A4=EC=A0=84 1:34, =
Heiner Kallweit <hkallweit1@gmail.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1=
:
>
> On 11.12.2022 15:47, Kang Minchul wrote:
> > Function dev_err() is redundant because platform_get_irq_byname()
> > already prints an error.
> >
> > Signed-off-by: Kang Minchul <tegongkang@gmail.com>
> > ---
> >  drivers/net/ipa/gsi.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
> > index 55226b264e3c..585cfd3f9ec0 100644
> > --- a/drivers/net/ipa/gsi.c
> > +++ b/drivers/net/ipa/gsi.c
> > @@ -1967,11 +1967,8 @@ int gsi_init(struct gsi *gsi, struct platform_de=
vice *pdev, bool prefetch,
> >
> >       /* Get the GSI IRQ and request for it to wake the system */
> >       ret =3D platform_get_irq_byname(pdev, "gsi");
> > -     if (ret <=3D 0) {
> > -             dev_err(gsi->dev,
> > -                     "DT error %d getting \"gsi\" IRQ property\n", ret=
);
> > +     if (ret <=3D 0)
>
> According to the function description it can't return 0.
> You can further simplify the code.
> And you patch should be annotated net-next.

Thanks for your feedback!
I just amended and sent v2.

Regards,
Kang Minchul