Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6421767rwb; Mon, 12 Dec 2022 01:25:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf6Stbk2dlBadiUOXKpdO+zPcJTF3zEla8JUIRYsCO2kZwgiwoA2QM2pH8loZQMTl66DIin5 X-Received: by 2002:a17:906:3fd5:b0:7aa:491c:6cdf with SMTP id k21-20020a1709063fd500b007aa491c6cdfmr13939423ejj.18.1670837132232; Mon, 12 Dec 2022 01:25:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670837132; cv=none; d=google.com; s=arc-20160816; b=lY0qfKAiJIrXQH4ZZHS367UoXmDykqmFWUToYIXWmFR13M+qUDOttqVu9xI1XCxqbi Xxcbcbznt1Bs5mVdZd+kWeuUaJ9GQaW22gcDAl+X8Pk5qt0W/HF+9euWl8vb233gGx7q ceppL87ufO0g+GB9MRhcZcena7JjfiHRkByY+qajKDDgAPIDotLNVKedyv2QlnezbAqz a9pIrPoCcB9jA6uQfyZ+w2WuV7aN2DLvBzgy1/2FJeveP+GP/ghFQlatodKi0KLLyRBj qydJ89nRgtuHwscllwxZkaDex2ef5fVdXykFH6nMvvGgkiaYw6Pd7SP11GrE2+YpDXb0 y+qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=VeLsSPeiIosSzdRjG1SrluMNOuGe1WZhhr+Ihy1nnrs=; b=FR4LL5AT7tI1yDaadFqf8T6iw7lDXhvd6/yig5XGgljGQA7mY9BgrSJ74+QDTV5obK zquS4HmNxwZ3eNYOF7cPi5Sku862E6FNZyyntxfxPi/rsticA5o4YYvt8rf2gByIiQLv tVCdIRKhwnlk67z/JNSr6M0wQO+Ng0koRNOKrStP9vywubHKboRu6cDpeF0+qnNYrW6N 7UTenxNSFV4Z8+xz2v45Bzu9G3cKr2bmbo7dX75daAXnTuh9hR+YNmhqezQ/ghSAdPFM iwFuhWjbLwu8hTTbxsNl7Box+phntMNROGEX+E7raXtArIAI5ITAxq+sXdgHoMObgt3U KQaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NSC7eTO0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qk20-20020a1709077f9400b007c0a7bc2854si1862734ejc.410.2022.12.12.01.25.14; Mon, 12 Dec 2022 01:25:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NSC7eTO0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231420AbiLLJJF (ORCPT + 76 others); Mon, 12 Dec 2022 04:09:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231202AbiLLJIz (ORCPT ); Mon, 12 Dec 2022 04:08:55 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0D35DD2; Mon, 12 Dec 2022 01:08:54 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 65A42B80A4A; Mon, 12 Dec 2022 09:08:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63287C433EF; Mon, 12 Dec 2022 09:08:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670836132; bh=+syCpe53ksZ1wk/P+ti6joXMTLfEgJsQad42fqKxD3g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NSC7eTO0arSVlDUtvmnWkmHX8oKugfq1mHlKbrZuU/v1ILMrnZ5E++3Mpa3Hc9fuI /dbB8VZSGb89vmfi9DfHkC7EIhEetA5vvbQZHdCUkC87ddQhd9pGHa3mboMXsTysOT XgPzcRlO2WqYieGyv8jZJPL0XcnZvcsbsW1kOW9YzOOh4zRXk/Nah0HMLxTuu/0Txo Tgv41hTvIY0aMCYyHr+NC0xyLlO4UwtIn2ZZlXbBWP/Kbb/KEwP2Su2GoCcXASjuLN 9B2UNexqwTGaca0T3dLRP3M4sf8XPFryN/rdmEOBaFZ7EoaWikTcpAFikcBpcoEUte KfpjN9KykJUEg== Message-ID: <0a42d725-ce95-216f-6078-877590be1d09@kernel.org> Date: Mon, 12 Dec 2022 11:08:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] memory: omap-gpmc: fix wait pin validation Content-Language: en-US To: "B. Niedermayr" , linux-next@vger.kernel.org, Tony Lindgren , Krzysztof Kozlowski Cc: Rob Herring , "open list:OMAP GENERAL PURPOSE MEMORY CONTROLLER SUPPORT" , "open list:MEMORY CONTROLLER DRIVERS" References: <20221209123147.591982-1-benedikt.niedermayr@siemens.com> From: Roger Quadros In-Reply-To: <20221209123147.591982-1-benedikt.niedermayr@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/2022 14:31, B. Niedermayr wrote: > From: Benedikt Niedermayr > > This bug has been introduced after switching from -1 to UINT_MAX > for GPMC_WAITPIN_INVALID. > > The bug leads to an error when the optional gpmc,wait-pin > dt-property is not used: > > ... > gpmc_cs_program_settings: invalid wait-pin (-1) > ... > > Signed-off-by: Benedikt Niedermayr > Fixes: 8dd7e4af5853 ("memory: omap-gpmc: fix coverity issue "Control flow issues"") > Cc: Rob Herring Acked-by: Roger Quadros