Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Dec 2022 09:59:48 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     John Stultz <jstultz@google.com>, linux-kernel@vger.kernel.org,
        Brian Masney <bmasney@redhat.com>,
        Bjorn Andersson <andersson@kernel.org>,
        Douglas Anderson <dianders@chromium.org>,
        Peter Robinson <pbrobinson@redhat.com>,
        Enric Balletbo i Serra <eballetbo@redhat.com>,
        Steev Klimaszewski <steev@kali.org>,
        Rob Herring <robh@kernel.org>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        linux-arm-msm@vger.kernel.org,
        Saravana Kannan <saravanak@google.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v2 1/4] driver core: Make driver_deferred_probe_timeout a
 static variable
Message-ID: <Y5bthMXYH1MuD9VY@kroah.com>
References: <20221116115348.517599-1-javierm@redhat.com>
 <20221116115348.517599-2-javierm@redhat.com>
 <CANDhNCoa+LRu8B4+M+uU4_m2kd=HriO0SyNP=n=XpXwXG2k9LA@mail.gmail.com>
 <549800ec-6da2-64ad-62a6-c8e4a35dc212@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <549800ec-6da2-64ad-62a6-c8e4a35dc212@redhat.com>
Precedence: bulk

On Mon, Dec 12, 2022 at 09:50:16AM +0100, Javier Martinez Canillas wrote:
> Hello Greg,
> 
> On 11/17/22 20:14, John Stultz wrote:
> > On Wed, Nov 16, 2022 at 3:54 AM Javier Martinez Canillas
> > <javierm@redhat.com> wrote:
> >>
> >> It is not used outside of its compilation unit, so there's no need to
> >> export this variable.
> >>
> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> >> ---
> >>
> >> (no changes since v1)
> >>
> >>  drivers/base/dd.c             | 6 ++----
> >>  include/linux/device/driver.h | 1 -
> >>  2 files changed, 2 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> >> index 3dda62503102..040b4060f903 100644
> >> --- a/drivers/base/dd.c
> >> +++ b/drivers/base/dd.c
> >> @@ -257,13 +257,11 @@ static int deferred_devs_show(struct seq_file *s, void *data)
> >>  DEFINE_SHOW_ATTRIBUTE(deferred_devs);
> >>
> >>  #ifdef CONFIG_MODULES
> >> -int driver_deferred_probe_timeout = 10;
> >> +static int driver_deferred_probe_timeout = 10;
> >>  #else
> >> -int driver_deferred_probe_timeout;
> >> +static int driver_deferred_probe_timeout;
> >>  #endif
> >>
> >> -EXPORT_SYMBOL_GPL(driver_deferred_probe_timeout);
> >> -
> > 
> > Yeah, I added the EXPORT for the regulator code to use it in
> > dca0b44957e5 but that got backed out when setting
> > driver_deferred_probe_timeout to 30s was reverted, and this bit was
> > forgotten.
> > 
> > Thanks for catching this!
> > 
> > Acked-by: John Stultz <jstultz@google.com>
> >
> 
> Could you please pick this patch? Is a fix independent of the other
> patches in the series and it has already been acked by John.

It is the middle of the merge window and I can't take anything now until
after 6.2-rc1 is out.  I also really can't take individual patches out
of a patch series easily, so please just resend it as a single patch
when 6.2-rc1 is out.

thanks,

greg k-h