Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Dec 2022 11:59:55 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Jianglei Nie <niejianglei2021@163.com>
Cc:     ojeda@kernel.org, geert+renesas@glider.be,
        linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3] auxdisplay: hd44780: Fix potential memory leak in
 hd44780_remove()
Message-ID: <Y5b7m/aijyJEuyoI@smile.fi.intel.com>
References: <20221129081542.5890-1-niejianglei2021@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221129081542.5890-1-niejianglei2021@163.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Nov 29, 2022 at 04:15:42PM +0800, Jianglei Nie wrote:
> hd44780_probe() allocates a memory chunk for hd with kzalloc() and
> makes "lcd->drvdata->hd44780" point to it. When we call hd44780_remove(),
> we should release all relevant memory and resource. But "lcd->drvdata
> ->hd44780" is not released, which will lead to a memory leak.
> 
> We should release the "lcd->drvdata->hd44780" in hd44780_remove() to fix
> the memory leak bug.

Miguel, can this be somehow moved forward?

-- 
With Best Regards,
Andy Shevchenko