Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <95864fee-ade9-d3a8-8dba-01afc4e4d87c@redhat.com>
Date:   Mon, 12 Dec 2022 10:36:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v1 1/1] platform/mellanox: mlxbf-pmc: Fix event typo
Content-Language: en-US
To:     James Hurley <jahurley@nvidia.com>, jdelvare@suse.com,
        linux@roeck-us.net, linux-kernel@vger.kernel.org,
        markgross@kernel.org, vadimp@nvidia.com,
        platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org
Cc:     David Thompson <davthompson@nvidia.com>,
        Shravan Kumar Ramani <shravankr@nvidia.com>
References: <aadacdbbd3186c55e74ea9456fe011b77938eb6c.1670535330.git.jahurley@nvidia.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <aadacdbbd3186c55e74ea9456fe011b77938eb6c.1670535330.git.jahurley@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 12/9/22 15:35, James Hurley wrote:
> Had a duplicate event typo, so just fixed the 1 character typo.
> 
> Fixes: 1a218d312e65 ("platform/mellanox: mlxbf-pmc: Add Mellanox BlueField PMC driver")
> Signed-off-by: James Hurley <jahurley@nvidia.com>
> Reviewed-by: David Thompson <davthompson@nvidia.com>
> Reviewed-by: Shravan Kumar Ramani <shravankr@nvidia.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
>  drivers/platform/mellanox/mlxbf-pmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/mellanox/mlxbf-pmc.c b/drivers/platform/mellanox/mlxbf-pmc.c
> index 65b4a819f1bd..c2c9b0d3244c 100644
> --- a/drivers/platform/mellanox/mlxbf-pmc.c
> +++ b/drivers/platform/mellanox/mlxbf-pmc.c
> @@ -358,7 +358,7 @@ static const struct mlxbf_pmc_events mlxbf_pmc_hnfnet_events[] = {
>  	{ 0x32, "DDN_DIAG_W_INGRESS" },
>  	{ 0x33, "DDN_DIAG_C_INGRESS" },
>  	{ 0x34, "DDN_DIAG_CORE_SENT" },
> -	{ 0x35, "NDN_DIAG_S_OUT_OF_CRED" },
> +	{ 0x35, "NDN_DIAG_N_OUT_OF_CRED" },
>  	{ 0x36, "NDN_DIAG_S_OUT_OF_CRED" },
>  	{ 0x37, "NDN_DIAG_E_OUT_OF_CRED" },
>  	{ 0x38, "NDN_DIAG_W_OUT_OF_CRED" },