Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6498296rwb; Mon, 12 Dec 2022 02:43:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf4JpUE1uuCimP6W894A7tEz3jT+nsCcrPXoeKA4AKb8ZXnj8KVVL9WcZO43AlFxafyFi2E/ X-Received: by 2002:a17:906:434f:b0:7ae:7ea:c76b with SMTP id z15-20020a170906434f00b007ae07eac76bmr490286ejm.32.1670841783329; Mon, 12 Dec 2022 02:43:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670841783; cv=none; d=google.com; s=arc-20160816; b=UuNaMBcSfjtaXQl724yY4eUGkgyqYhWbF+w8lUjEDS+69kQ9unmOph4GB2xK6+lfzZ jLsbF7+bxrxf7kT4LJYVo3oiM778RSvmB7nfnWojzP07YZpj0d3BjTop0O/+L5+JnD8r qOZ7e69BUR34KHZVZcMY8us29bghg5gOkOlgHNPPjEB4Pn7qoMp35on6kmqJ4kzJGRwg fn/ekjWfLb69wT/zjB99sxcqagukpx2KNqVAco7mX8cFO61IETxqBR5EMHi6IMYfzwRm spORoOtL31d0sbI267G+UpaYelyrOmlS7ZTlsMr7douu8IiLCzVXUe0g9HpyI2s2Iesl OTpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ZkzRg4u725kPYHWW9hJ6hM/nk88CRoqJl3MqMvbMeys=; b=CWYSlBi0TXDdpHQy6uyc78MFY3nC2K7CrmCV33TjJDgjnjf8JBiu6ggDO2+bLhmUOt TQ7SMpwuYNjGvCBJJ7T4iQsXd07z6AHBSs1wVVDzGgyXPWDGh82mFxPwYPAD+JVlNZQ8 SzcLbv9PlYsADrvwBWX9AZOfYiCIxc5A9i2F5Ra1BFmdutjxm7cj+s0ecIlFml6tKOll l8K5XSLWGoebIgnMuY/2DDXGCM4qg0lKtjyPQNDLzebjlnSmIYydFVm3053szateEqfO MeKAPWMai8/i04YmPCjyKLQ8QaqW353KKiFNig5Xvr+uW7CCpFlsRgCPE7VmUumrHnT0 LAVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kU0gy2TK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fq32-20020a1709069da000b0077ef3eece57si4317587ejc.144.2022.12.12.02.42.42; Mon, 12 Dec 2022 02:43:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kU0gy2TK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231896AbiLLKXL (ORCPT + 75 others); Mon, 12 Dec 2022 05:23:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231819AbiLLKXJ (ORCPT ); Mon, 12 Dec 2022 05:23:09 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEC6CDC7 for ; Mon, 12 Dec 2022 02:23:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5EF5A60F92 for ; Mon, 12 Dec 2022 10:23:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1EDAC433EF; Mon, 12 Dec 2022 10:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670840586; bh=eaA9Ecx2vK5nM7LogognJdRgdhZwRl/7vGOtUmN82A8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kU0gy2TKFN6jg5sLVps40wqHVutxGRXqfBqb/rLzTqgUHBOtXVqqnMpO+V55hJlSr ouAwqDsMgVDYVERAh4gJwKBLTcLnkVdt+4MnM/coe5p+s2y3JRZbqeCMCYYuBujDaJ P0GeeJqVfI2ogYRoOYtgGdQvxJ2tuPuV0JVRyh0015S4tcbUFw9mXqWdjaVmbEOWC/ Gc0MtMQiKXOvDU1hE/QlQoI0EJSyntXHZGyK2pz70//F/TmrEPMF02nUBBpEu3y9aR pgK8RNKB0Hyr6C6osHJ3Xzcz7VfeAe4X0rSJKw32QBxBqMatjoppyrvxg0CmwQ8/0j l6cEXMIgFrWuA== Message-ID: <5cc534fc-1192-887a-91e1-2f1c2283b212@kernel.org> Date: Mon, 12 Dec 2022 18:23:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] f2fs: add iostat support for FS_DISCARD_IO Content-Language: en-US To: Yangtao Li , jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20221212054706.65579-1-frank.li@vivo.com> From: Chao Yu In-Reply-To: <20221212054706.65579-1-frank.li@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/12/12 13:47, Yangtao Li wrote: > Just like other data we count uses the number of bytes as the basic > unit, but discard uses the number of cmds as the statistical unit. In > fact, the discard command contains the number of blocks. In order to > avoid breaking its usage of application, let's keeping FS_DISCARD > as it is, and add FS_DISCARD_IO to account discard bytes. > > Suggested-by: Chao Yu > Signed-off-by: Yangtao Li Reviewed-by: Chao Yu Thanks,