Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Dec 2022 18:14:58 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Yuan, Perry" <Perry.Yuan@amd.com>
Cc:     "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Huang, Shimmer" <Shimmer.Huang@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        "Karny, Wyes" <Wyes.Karny@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 08/13] cpufreq: amd-pstate: add frequency dynamic
 boost sysfs control
Message-ID: <Y5b/IvbeIq4d56nd@amd.com>
References: <20221208111852.386731-1-perry.yuan@amd.com>
 <20221208111852.386731-9-perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221208111852.386731-9-perry.yuan@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/k6GY9tnTKZzlC+oRXB1TXO7r5HNgoYjENWFjoRXfvIPQJHIpTqbAOUZoPIz?=
 =?us-ascii?Q?iOqA4/IL8KMRusoKIVHAvEMNUEmzUlbftC7P9gIbqt+emvonMqrB+XFotD/I?=
 =?us-ascii?Q?R9bmqdUVndBXrssgQiztm9t8Wok5nchEDg7y67Nkm+au3RVHIevZExucMdL+?=
 =?us-ascii?Q?i1h44Th7TfafAegPToIkYn4BAGB6VYQl4f1duOBcgFdcsnDrWEwQcZ6bOOIH?=
 =?us-ascii?Q?zDPKQxvlTm5Hjk7JtzSooVfDMLOXml8i5vz6F6Fwu3VOvy3fxAzbIpsLndAG?=
 =?us-ascii?Q?ULiKJ34jHqOh42J1JNBBeYHhtg0F5qsoC/YrL8escRaQmJm41zr0Yq7u3Y9k?=
 =?us-ascii?Q?uuEwahNZm7vy2KKdjZ2akBi5/PyR6IJtt0zogwX56oQKnEh97kbrlEJeA63x?=
 =?us-ascii?Q?wbMqKPZjsTnVxchg3QYlW9grnqwvAcHTifHeguacHx6jadn6jqagL9J3OxmZ?=
 =?us-ascii?Q?4MYWDT073ciuuI7gQHSAnbPh4N8aqXUYeYbco8zhnV6AKKDp0ZWtB7E+Evlr?=
 =?us-ascii?Q?uPhmOlmL4UDRImCarAQsDrYTM2ouCXUBu3lKJtdHGVlIIsvjxdtGqp7C99Fl?=
 =?us-ascii?Q?8OlyWTivMnBFmHSepMFrYZiN+eAodnI3p9g2INtJoGniu4SI8Q53LWmhKKGF?=
 =?us-ascii?Q?yzihmF0HDy+DD0IMOjjXx1vz8yhwHZOJbwfgL4f9r7KuI+yoqRNiMs90lswL?=
 =?us-ascii?Q?TlZ8B7RFAzYj3Ln48EHXNbq95C4ocJxNPlpIPkRA+HboneSCqNpyUtm/mgrW?=
 =?us-ascii?Q?oLGGL0uqXjpAFmmzQ2loH45Kh/kJJGoY3MgyAHG8gFM2TziFtcKWjp8Gc8Wm?=
 =?us-ascii?Q?fskKGJoSb56l4ZNSMKxVgs2Kt+tZOflw4Sn3PxdAJbNrSqBB4Xc6Yo/ZOJZ2?=
 =?us-ascii?Q?xkOT85b33kBC1WF6k5XjKhNbNuh1oAywt5WOuppqxKiQynFer1n/DwK+gTub?=
 =?us-ascii?Q?avRHxf4IDV5QkUNxTu2mJZ07PauGQbMwEZ7brGSMeDcSz/I1zb8sy56CDMdq?=
 =?us-ascii?Q?+5lTa9DXcl+vc4Zgw/OH30CN1VLYmiMc5ulEavlg+cZjCUhfzyq6qSecN+xm?=
 =?us-ascii?Q?/He/1cWQ0p8cDDOu8mQwRd5T06YuGihQ3Mv7ygOVSMM6aYi54SeHzswjrtM2?=
 =?us-ascii?Q?bQqJSk2VH1DN82Vsx5/64VN2TC3eE0fyZXpcmFQatdnZrtLfMRxtg0Bt4eFV?=
 =?us-ascii?Q?iI8LShYC1QP3ekFGctxt5RJFAMut5Yk0L1lG2et58ow14Fz74fNkIC34T5ZB?=
 =?us-ascii?Q?FK1swbGFpsRlLIngqsHgKI9IubNudeVR3QrbQnOESV7cKTegw8ub1jcwdhEq?=
 =?us-ascii?Q?weMfYP3qYo8Rok1aTdy9p6OT6Brs8LJ7Mn1ozYYoE/Cvlqf0kcyNjR7oc/Tt?=
 =?us-ascii?Q?RLPz20crxBO6WlrcnL4OKT/2j3nOeLf+3vgDoLImjDCz2PaBVm1E5jQVpHUZ?=
 =?us-ascii?Q?ycasw5XnB3u5Tgy4rXG0vKsJxl2QtMm7wAzSRC6/1RkXY4XVzP31sb6W6pmo?=
 =?us-ascii?Q?xlY5AFnc5wnQKN1w4y8+kKJtnjqywh2ay+NMetIZkEjYIotZgdSCHaug8U+q?=
 =?us-ascii?Q?m/1z2FfXphAxMvofgupnx0S4UrEVdVPHQF6N/92F?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12ad0991-4297-4e5d-ce99-08dadc29c7be
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2022 10:15:23.3505
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U2H4YptSeYgO47ujXbC17GQd8WgQPd4DnL457++nnZGiLjoexrhvMp49qXS0CY/407SDiOPdqWOsQ6UAK/cNzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7379
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 08, 2022 at 07:18:47PM +0800, Yuan, Perry wrote:
> From: Perry Yuan <Perry.Yuan@amd.com>
> 
> Add one sysfs entry to control the CPU cores frequency boost state
> The attribute file can allow user to set max performance boosted or
> keeping at normal perf level.
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 67 ++++++++++++++++++++++++++++++++++--
>  1 file changed, 65 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index ea9255bdc9ac..4cd53c010215 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -69,6 +69,7 @@ static struct amd_pstate_params global_params;
>  
>  static DEFINE_MUTEX(amd_pstate_limits_lock);
>  static DEFINE_MUTEX(amd_pstate_driver_lock);
> +struct kobject *amd_pstate_kobj;
>  
>  static bool cppc_boost __read_mostly;
>  
> @@ -768,12 +769,46 @@ static ssize_t show_energy_performance_preference(
>  	return sysfs_emit(buf, "%s\n", energy_perf_strings[preference]);
>  }
>  
> +static void amd_pstate_update_policies(void)
> +{
> +	int cpu;
> +
> +	for_each_possible_cpu(cpu)
> +		cpufreq_update_policy(cpu);
> +}
> +
> +static ssize_t show_cppc_dynamic_boost(struct kobject *kobj,
> +				struct kobj_attribute *attr, char *buf)
> +{
> +	return sysfs_emit(buf, "%u\n", cppc_boost);
> +}
> +
> +static ssize_t store_cppc_dynamic_boost(struct kobject *a,
> +				       struct kobj_attribute *b,
> +				       const char *buf, size_t count)
> +{
> +	bool new_state;
> +	int ret;
> +
> +	ret = kstrtobool(buf, &new_state);
> +	if (ret)
> +		return -EINVAL;
> +
> +	mutex_lock(&amd_pstate_driver_lock);
> +	cppc_boost = !!new_state;
> +	amd_pstate_update_policies();
> +	mutex_unlock(&amd_pstate_driver_lock);

This patch should wait that after we confirm the iowait boost necessity for
amd-pstate.

Thanks,
Ray

> +
> +	return count;
> +}
> +
>  cpufreq_freq_attr_ro(amd_pstate_max_freq);
>  cpufreq_freq_attr_ro(amd_pstate_lowest_nonlinear_freq);
>  
>  cpufreq_freq_attr_ro(amd_pstate_highest_perf);
>  cpufreq_freq_attr_rw(energy_performance_preference);
>  cpufreq_freq_attr_ro(energy_performance_available_preferences);
> +define_one_global_rw(cppc_dynamic_boost);
>  
>  static struct freq_attr *amd_pstate_attr[] = {
>  	&amd_pstate_max_freq,
> @@ -791,6 +826,15 @@ static struct freq_attr *amd_pstate_epp_attr[] = {
>  	NULL,
>  };
>  
> +static struct attribute *pstate_global_attributes[] = {
> +	&cppc_dynamic_boost.attr,
> +	NULL
> +};
> +
> +static const struct attribute_group amd_pstate_global_attr_group = {
> +	.attrs = pstate_global_attributes,
> +};
> +
>  static inline void update_boost_state(void)
>  {
>  	u64 misc_en;
> @@ -1404,9 +1448,28 @@ static int __init amd_pstate_init(void)
>  
>  	ret = cpufreq_register_driver(default_pstate_driver);
>  	if (ret)
> -		pr_err("failed to register amd pstate driver with return %d\n",
> -		       ret);
> +		pr_err("failed to register driver with return %d\n", ret);
> +
> +	amd_pstate_kobj = kobject_create_and_add("amd-pstate", &cpu_subsys.dev_root->kobj);
> +	if (!amd_pstate_kobj) {
> +		ret = -EINVAL;
> +		pr_err("global sysfs registration failed.\n");
> +		goto kobject_free;
> +	}
> +
> +	ret = sysfs_create_group(amd_pstate_kobj, &amd_pstate_global_attr_group);
> +	if (ret) {
> +		pr_err("sysfs attribute export failed with error %d.\n", ret);
> +		goto global_attr_free;
> +	}
> +
> +	return ret;
>  
> +global_attr_free:
> +	kobject_put(amd_pstate_kobj);
> +kobject_free:
> +	cpufreq_unregister_driver(default_pstate_driver);
> +	kfree(cpudata);
>  	return ret;
>  }
>  device_initcall(amd_pstate_init);
> -- 
> 2.34.1
>