Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <efca6b26-fb20-ae38-0fc4-8612f1ee150b@suse.com>
Date:   Mon, 12 Dec 2022 11:19:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] USB: drop misleading usb_set_intfdata() kernel doc
To:     Johan Hovold <johan@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221211120626.12210-1-johan@kernel.org>
Content-Language: en-US
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20221211120626.12210-1-johan@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkxhYmtiMUptK2hSMlM3c3FvUjZFOFZHK2Y1bWpmOUVIb0o1ZGk0VVQwc3A5?=
 =?utf-8?B?dTVzdnNZbm1EaFcxZEM0dUVIbWkzT3FuZ3Zhc0Eza29MMHZ3aHprdG04djVl?=
 =?utf-8?B?MzhoSEZWaUU3Z1ovdFg3ai8yWEQ4SmVLY2VUZFdNTVdZZDd1V1hjT0JUVE56?=
 =?utf-8?B?RGlXbVV3ZDdQdDNoaFk1OTVYNHhadjl5TnRsd2kzOE9Hd2hFYjRuV3RGSkM3?=
 =?utf-8?B?OTd4Q01ma05kYktMbzNLYlhKMnphaEZWS2dweU1TRTZzWEk1RHNoTENTRS8x?=
 =?utf-8?B?UHJWT3R1VmtFMTZULzBqL3JDQlVhamJzS0FGcGcrdUsvQ29KODBBMnJIbmU4?=
 =?utf-8?B?bEtqWmkzeDJlWldtUUx1emZ5Z0NleTRMUjFSTGZwNzhXMEFQUnpDS3hteVVy?=
 =?utf-8?B?VGlabktlV1RrcXdhK2gzWjRyR1dVd1dhTnBhK0xscXRYSXNsaXNJRGx3Umt5?=
 =?utf-8?B?Y3piU3NRRDhyS0ljMDdJV0JDNjJENXljVjJSZktvbWxnU0tNUWdyV2UvOXZK?=
 =?utf-8?B?Ty9jMGUyY2pWWmp2R0ZwaVp5NU4wRno3SVhWclBuY1JTTnYvL0JuYmRGVnRM?=
 =?utf-8?B?VXNOOE5BeVFBY29TTkxRbzRCbytPYUVIZFZoSWZXK3E3NEhLa3pNUUp1SUZh?=
 =?utf-8?B?b21YM1YzVDJwVG9oRHh1U2x3R2JMNXNWNm8xWEdZbVk0MUw3ZjVmejFINkIw?=
 =?utf-8?B?MGlmOHZ3NnRQdjJLM01mOWhLYTFLN0hSZk1nYi93aUx6aEIxUHhxN0t2Q1Yy?=
 =?utf-8?B?cURaM3dHZ2ZmSGxuUVdLYTBzakczandSS0lBclN1T0dqczV2eVowQU1ubFJR?=
 =?utf-8?B?OUdBbjROd1dSOEJMd0xnQVRtaHc0MG5PWW1pOWJXMzJxZUZXUVEydzlXYWNU?=
 =?utf-8?B?K3lQeVZQRUE5UWV2YmJuQnk1aGcrSTI0d0NQZUIzSHpFR1o2b25TbUpOWndp?=
 =?utf-8?B?NWU1ZGJWSmZyNU5jM0VtZ0ZOL2E5VkkyMWZLSmsvTGUrakhTaERrbDN6c1p1?=
 =?utf-8?B?ckNuUXpYL2RTVlBjZTE2dzUzVkd6T2hQQjl0NFhvZHVoVmVwbUMyeUY0RUNl?=
 =?utf-8?B?ZVVOSFFtZjlLT0dQOEdleVczaTRLdnpQRW4xMXpPdFIrZ3lIYmhYYlVaUmF5?=
 =?utf-8?B?MkxtVzNUdVpVNXFqb3I4dytiVDMwdUkyRmVkZURyY29vVlNodFJEeDY3N3N6?=
 =?utf-8?B?QVIyb0VGdUM3eExlNEtuS1FHTHNXdjBqK3ZSZDBKMExrQ2RsN1drZ0NJQUhD?=
 =?utf-8?B?Mm1ySzFlTGV1NWgyWnVVMWlUdmtsY09TbUZLT09lWHZDVk1Mc1huSVcvdGV3?=
 =?utf-8?B?OEZWZmMzNWdXUGt4Z0sreFZhNUR4cHZYdWZDU1IwYUdqTkZzdms0ZjhVL1pR?=
 =?utf-8?B?cXVVbEovM0grUGJLWVlORXRXcTM0QWs3eGtyS1ZYckhreFF1N1ZyL2dHZFFk?=
 =?utf-8?B?M01na1k5Ri9aOEd0WHRiVUdDSHA4b2gySkI1cWhERmJEbjhiNVdCdmI5WkJq?=
 =?utf-8?B?bzVIeEVySEVFTGFLMzlCbEVFbkdSeFBIS2o4UmJvY0d3RUgwN1NYVTFaMzQv?=
 =?utf-8?B?ZTl2M1kwMGFIRVJoRC93Yko0a2hVNklxUi9RMjZNQ1RyalBCaHZCUUhJTTlt?=
 =?utf-8?B?eUNCS3N4SHhuWlZOLzh2Q2FKenllM0JVMC82QUFYVzVOOEVSbFV1WUZIV0ZY?=
 =?utf-8?B?dGNkcThyRzVtTWE4NWxnc3dTWXg2R3pmNURUR2xoUURudGF0NnNGMFVRNjdF?=
 =?utf-8?B?WUxzaTdzUzIzZkVUVXQ2ZHlKOE43MS9PNzBzY1lHUlpUOVRLREJkUzVTS0Nt?=
 =?utf-8?B?MzhhekZwcDRYSUttVHlvdWVBakFOZTM3dU1SRzJQVXMyeWRPbmtYVUExbzVq?=
 =?utf-8?B?UGpMVHVoanI5MlhOdzlmVllwVHhmendXQklqcUJObm1kK3NyRXQ0b1B5L3JX?=
 =?utf-8?B?djhDclBJYitQOThDc2RPNXlwYU9DYm9maThpbmV4REtWZUVRS0s3V3NhSFNn?=
 =?utf-8?B?ZzcwNVV0MldBVCtoajROclMxT0ljemlwQk81MDFobzloVk5KUDNUdkZ4Z0Vm?=
 =?utf-8?B?eXJVbng5Um5NTm81Zmx0QkRhRGdMQ3hSNUZ0MFVSTmtUSFZZWDloV04rMVRl?=
 =?utf-8?B?Mi9BWEliQUZLRGNSL3NtN2VHNFdNU1RuQjZNU2NjUXFKNWRYejkvcXkwM1p1?=
 =?utf-8?Q?XlmhNOJX7iKn8CEyC+7wqJTbn6AioGgdQDS14CTuvv2s?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9bdff9f-2a83-4b5b-e8a5-08dadc2a4aaf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2022 10:19:02.9250
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SmVQhseMu6LL9JelfKeYyMFQ8FGl+dkFhQBri8c6jW4fG39+VbmjbfUu0pUNL0OaPxOwU/xYCge3OVG89ezw/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7237
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11.12.22 13:06, Johan Hovold wrote:

> Due to a misunderstanding, a redundant and misleading kernel doc comment
> for usb_set_intfdata() was recently added which claimed that the driver
> data pointer must not be cleared during disconnect before "all actions
> [are] completed", which is both imprecise and incorrect.

OK, but is that a reason to remove all kerneldoc? Kerneldoc is generally
a good thing. And if a pointer is NULLed by driver core, that will need
to be in it. IMHO you'd better just remove the questionable part of the
kerneldoc.

	Regards
		Oliver