Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0017c9ce-7e92-6010-7bc9-716131a25ec5@suse.com>
Date:   Mon, 12 Dec 2022 12:29:02 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v2] module: Don't wait for GOING modules
Content-Language: en-US
To:     Luis Chamberlain <mcgrof@kernel.org>, david@redhat.com,
        Petr Mladek <pmladek@suse.com>
Cc:     prarit@redhat.com, mwilck@suse.com, linux-modules@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
References: <20221205103557.18363-1-petr.pavlu@suse.com>
 <Y45MXVrGNkY/bGSl@alley> <d528111b-4caa-e292-59f4-4ce1eab1f27c@suse.com>
 <Y5CuCVe02W5Ni/Fc@alley> <Y5FPkEgEbDlVXkRK@bombadil.infradead.org>
From:   Petr Pavlu <petr.pavlu@suse.com>
In-Reply-To: <Y5FPkEgEbDlVXkRK@bombadil.infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REZ1a1VPTDNzN3MwTmZzT0xxS0pTZEE0SzliMkNlNXdlazVQSG9EQmprd1lz?=
 =?utf-8?B?VlpZK045Zk4wOHltVWc1SWdUK0FZdzhsTUprUDZUaEIrYm10QTg0c1BrTm9N?=
 =?utf-8?B?RzR0bE1saWZwOEhCUkRpT0Q1T3BTckhIQVZEZUlnK0YwSmRsaWdJcVJKaHZt?=
 =?utf-8?B?ZTRxTkJsRXZwcUdaak9hZHQ2OTdDaFR3cGpPVkpSMjlPajNPbjlDR1ZLS1dD?=
 =?utf-8?B?TUJsM0RMMy82UXdzWm5VV2wvOC9Jelgwcmp3RXNnU3pNWnhhRkJFWEJKblNU?=
 =?utf-8?B?bG9iS0J4OEtYcGtXZUNiNEQ1cThlUjhDUEU5VjhQUCsyQS9oNm1kOWhTQU9w?=
 =?utf-8?B?QVd1YWFicGErMzRLRG96VHJlQ0dYZ0dYQS9JVmxyUkN2UWJER0dYeHpwVlBw?=
 =?utf-8?B?RzM4c2RJOEpDb2NHdy90UnFkVHlldWtDYW1rUmJwWis4enFyaXFWSlBWMXFR?=
 =?utf-8?B?elgrcXBTN2U1RTRHcE1VZGRCa0ZINEMvQklGYm1WQTdqTmhKTEI3NFUxUlQ1?=
 =?utf-8?B?ZDByQ2RRMGZNd1FTRlpJZXlBcmpiSG9FSlM0cFVMYk5GNmdnc3ZLV3BQQUZE?=
 =?utf-8?B?UWFBaGlFTVRQTERFSkh3ZTlKWkJNZlBEajh1by9KeTFpaHptMVRUUmpVSysv?=
 =?utf-8?B?dCtMa3JZbGxWcllwVTkvYU83ZzNSODAreTNWV1NOTDNjaFpqZEs4aVlkUHpr?=
 =?utf-8?B?aTRlbjBqNHBoRVBmdzlPVGtjWVcxWERERzIrZTVhUmJ4N29YU3BxT2hTZDNV?=
 =?utf-8?B?WHE5djdPVVBTZEI1UE82TGlCTS9HOWpJMlBvZjQyYUxYQjZ6QTh1bVhvZ1Uz?=
 =?utf-8?B?ZTJwWWhFczRjWktZazE4aThTQmpVOTBnd1djV3ZZMkt6d1ZhU244V2xxejhT?=
 =?utf-8?B?UFZ2VGQ0RW0raFNBZDAvY2tadTZXcFR3enU0QTU2ZVVIbGcwa3NQbXJMaGdP?=
 =?utf-8?B?SUpEN3VsS05wbVI5anFCYnRhaFhTbGxkcHNtTHNkZE5wcWhta3JCbCtSTm5G?=
 =?utf-8?B?b0pySXVlVlNReXZqaSt2TTl1c3Q0eElYcmRXWk1GMDRRSjhpeldEZkFzTGQw?=
 =?utf-8?B?N01XQ2I3WlZqR05UVmw0Uk9TMVpzM0RSanlFUHVPcEJmaTJnMjZtdVNudEo0?=
 =?utf-8?B?SVdXUnhEUDREUWM5RU1NZENPNGZyMm50dWg2bWtaNGpGRWRYenc1WUw5UVhT?=
 =?utf-8?B?eGxQR1huMCtTdXRDc0RycjlVNWhDTFdnTzNxMDluQkZ1Z0JRTHlML3A1YytT?=
 =?utf-8?B?SmhQVnBNVEZ4Z0ZCUGd3Kzh0SVJSeEhvVFpIN2dncWhEbUMvcjJ6L25iRUZv?=
 =?utf-8?B?dG9sNlFBcmw0ZEw3ZW14eDc0UklQQ3pZeStnQkpjZW9NR3JKS09HL2lRWTNF?=
 =?utf-8?B?Y044eUwwOUVndVFsMmlmLy93dEFxckgwMDd3TzBBaEdwK0lIczF0eVBEVG16?=
 =?utf-8?B?WTZHY0lXeFpxZys2SU9vcUpreTJBM1RXMUt2S2lxN1pJMnliMVFFMmdaZHFr?=
 =?utf-8?B?cXFiMDN5RHZ0V29TdmpsakNwU0JwcGJENUdtVkpHZmlURnBXRXpIbS95Y1JV?=
 =?utf-8?B?QmhQTHQrTTdBRlF2K0NwZHFhWFA2MnhoVzBxcFZyYWtMSjJiWE44aXRtbE1O?=
 =?utf-8?B?UmhTOGJ4MStyYlhFU1dTL2ZVRkJzV2FFL3I4YlBTczI3SnJaYnM0enlMRkZS?=
 =?utf-8?B?UlpjbG8wLzNlRDZiVlpmMTNQc1Arc0pySmtCbGRuRStIMEJXbis4NEtMWUZD?=
 =?utf-8?B?SzFJUFdWTm1TTkR1WTlCVXJ1ZUQ3SzVvZkk5K0s3YU8rRFFiS1d6VTZGNmdp?=
 =?utf-8?B?ZS9Bcms5UlN4dnFkOWk4KzRQTGtQWW1aZUYrZ1hzL2tRMHZrY0tGKzY1VFB3?=
 =?utf-8?B?SUFZNWlXL2hDd013NVVWcFRYK3crZUhyNjg4ZUtEcmdxOG41KzBmeTB3ZDRB?=
 =?utf-8?B?R2M3YmF5SWw3OFBwdTlhbisrL1pwZ3hOekFZZWhGS2lzWm4vc1ZyQ2l4Uzcw?=
 =?utf-8?B?RGhQTDBuWXUzQTZDU0ZONUxBMDVpNzVxcDkxa0F0dGw5RmRJd0tlUis1TnVn?=
 =?utf-8?B?UENKWE1tSVhYdDdtcFZGbHpwWDRzWktRWE1uK2p3V0lXVUREeDFERTRUVVcy?=
 =?utf-8?Q?m5MO1YH7NdDn3GttnRQ5401cO?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6abeb8ba-79ba-4098-d538-08dadc3412e6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3406.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2022 11:29:04.9404
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SWuryBier6gZrapXEDiACKQLuigGi3Ps9gtK8z86KII1XFkTBTq8iALqjAQs7/te7uDxrLK6KNGypKcCSNqwpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9642
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/8/22 03:44, Luis Chamberlain wrote:
> On Wed, Dec 07, 2022 at 04:15:21PM +0100, Petr Mladek wrote:
>> Reviewed-by: Petr Mladek <pmladek@suse.com>
> 
> Queued onto modules-next.

Thanks both.

>> Of course, the ideal solution would be to avoid the multiple
>> loads in the first place. AFAIK, everything starts in the kernel
>> that sends the same udev events for each CPU...
> 
> Fixes go first, *then we can address enhancements. I have some old
> fixes I can send after htis is merged. I believe folks have others.

This simpler fix should be sufficient and so the original more complex
approach can be scraped. My plan is then to only progress the additional
developed patches: a test case for the issue, minor clean-up patches, and an
ACPI change to load acpi_cpufreq/pcc_cpufreq only once.

Note that none of this work now addresses the problem that David Hildenbrand
encountered with vmap allocation issues [1]. That needs to be fixed
separately.

[1] https://lore.kernel.org/linux-modules/20221013180518.217405-1-david@redhat.com/

Cheers,
Petr