Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d7a0165c-39f6-87ce-f2ec-1f670541147a@huawei.com>
Date:   Mon, 12 Dec 2022 19:41:32 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH -next v2] mm: hwposion: support recovery from
 ksm_might_need_to_copy()
Content-Language: en-US
To:     Miaohe Lin <linmiaohe@huawei.com>
CC:     <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        HORIGUCHI NAOYA <naoya.horiguchi@nec.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux-MM <linux-mm@kvack.org>
References: <20221209021525.196276-1-wangkefeng.wang@huawei.com>
 <20221209072801.193221-1-wangkefeng.wang@huawei.com>
 <342f4d3f-7347-1615-7d63-cbdef4872629@huawei.com>
From:   Kefeng Wang <wangkefeng.wang@huawei.com>
In-Reply-To: <342f4d3f-7347-1615-7d63-cbdef4872629@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/12/12 10:36, Miaohe Lin wrote:
> On 2022/12/9 15:28, Kefeng Wang wrote:
>> When the kernel copy a page from ksm_might_need_to_copy(), but runs
>> into an uncorrectable error, it will crash since poisoned page is
>> consumed by kernel, this is similar to Copy-on-write poison recovery,
>> When an error is detected during the page copy, return VM_FAULT_HWPOISON,
>> which help us to avoid system crash. Note, memory failure on a KSM
>> page will be skipped, but still call memory_failure_queue() to be
>> consistent with general memory failure process.
...
>   
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 908a529bca12..d479811bc311 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -1767,7 +1767,7 @@ static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd,
>   
>   	swapcache = page;
>   	page = ksm_might_need_to_copy(page, vma, addr);
> -	if (unlikely(!page))
> +	if (IS_ERR_OR_NULL(page))
> IMHO, it might be better to install a hwpoison entry here. Or later swapoff ops will trigger
> the uncorrectable error again?
Thanks for you suggestion, will do in v3.
> Thanks,
> Miaohe Lin
>