Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Dec 2022 14:49:48 +0200 (EET)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Tony Lindgren <tony@atomide.com>
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andy Shevchenko <andriy.shevchenko@intel.com>,
        Jiri Slaby <jirislaby@kernel.org>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-serial <linux-serial@vger.kernel.org>,
        linux-omap@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v4 1/1] serial: core: Start managing serial controllers
 to enable runtime PM
In-Reply-To: <Y5bToLirsgA5NK/j@atomide.com>
Message-ID: <ced9e9ea-317e-f2a2-d42f-97c2cd39f11b@linux.intel.com>
References: <20221207124305.49943-1-tony@atomide.com> <7f105ff9-cdc3-f98e-2557-812361faa94@linux.intel.com> <Y5G5Udw6FAEFdAYi@atomide.com> <3c87186b-336f-6884-a2c-6ee3c9d70@linux.intel.com> <Y5HG2okzlqX+xfWv@atomide.com> <Y5bToLirsgA5NK/j@atomide.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1000174910-1670849393=:1743"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1000174910-1670849393=:1743
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT

On Mon, 12 Dec 2022, Tony Lindgren wrote:

> Hi Ilpo,
> 
> * Tony Lindgren <tony@atomide.com> [221208 11:13]:
> > * Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> [221208 10:48]:
> > > With the other patch on top of this, yes, I did see uninitialized 
> > > port->port_dev already in serial_core_add_one_port()->uart_configure_port().
> > > While that could be solved by removing the pm_runtime_*() calls from 
> > > there, I think it's a generic problem because after 
> > > serial_core_add_one_port() the port can have anything happening on it, no?
> > 
> > OK. Sounds like it should get sorted out by moving the call to
> > serial_core_add_one_port() to happen after the devices are created.
> 
> Can you give a try with the patch below and see if it works for you?

This one worked, yes.

-- 
 i.

--8323329-1000174910-1670849393=:1743--