Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Dec 2022 14:37:20 +0100
From:   Jan Kara <jack@suse.cz>
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     viro@zeniv.linux.org.uk, tytso@mit.edu, jack@suse.cz,
        axboe@kernel.dk, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] writeback: remove obsolete macro EXPIRE_DIRTY_ATIME
Message-ID: <20221212133720.xvnmz4nsfwknwqr4@quack3>
References: <20221210101042.2012931-1-linmiaohe@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221210101042.2012931-1-linmiaohe@huawei.com>
Precedence: bulk

On Sat 10-12-22 18:10:42, Miaohe Lin wrote:
> EXPIRE_DIRTY_ATIME is not used anymore. Remove it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Sure. Thanks! Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/fs-writeback.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 9958d4020771..6bad645ac36f 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -1345,8 +1345,6 @@ static bool inode_dirtied_after(struct inode *inode, unsigned long t)
>  	return ret;
>  }
>  
> -#define EXPIRE_DIRTY_ATIME 0x0001
> -
>  /*
>   * Move expired (dirtied before dirtied_before) dirty inodes from
>   * @delaying_queue to @dispatch_queue.
> -- 
> 2.27.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR