Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     jaegeuk@kernel.org, chao@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] f2fs: don't call f2fs_issue_discard_timeout() when discard_cmd_cnt is 0 in f2fs_put_super()
Date:   Mon, 12 Dec 2022 21:05:54 +0800
Message-Id: <20221212130554.79049-1-frank.li@vivo.com>
In-Reply-To: <3f2c81f8-7946-d2e0-8768-6f0b03282944@kernel.org>
References: <3f2c81f8-7946-d2e0-8768-6f0b03282944@kernel.org>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?16oUwSMmVmyA0bndqrb5uCflwGRU9HKb1RfY9vZ2dYgWD+XQJPjTMZxsHeFL?=
 =?us-ascii?Q?9J5tCuKeGvpK9kq0abMhWM/gR0nWdxurlCOC5HoZNp/sqVc/0NghE1Rk/OXz?=
 =?us-ascii?Q?Gk8rKG/DpZxfq6Kg/G/7hHbDM6WRUT+KoUWw2CHpAZTUZXAMWTLlLyCnm1NA?=
 =?us-ascii?Q?j6edx4Wkl1DvXj9nXjBRvQRruC3G9fj8a/supmNCDyNRdprMMsSX7UqxWcI7?=
 =?us-ascii?Q?butwn8PPgVhzsR94R69xck4/oiuLdaBhGKJ6jscnKnMM0RGBKkH2p7JQDUaw?=
 =?us-ascii?Q?a5HE/UGQYUf/M6HW4j6LUKpBR0f8VQjf1/5EyggvrriPI73+2zq2ADzajRJY?=
 =?us-ascii?Q?Vxnh+mIvM4R0vJO8J+6/RFje2aXjmYA8GSKBk2IhoaatSUo72wStfuRNKNKv?=
 =?us-ascii?Q?VX9RvB4kFn2t9E1OVcC0Lc7Oi4YdHxayMJuU3NcuOVbR2Q6F54GbxpE5kk8x?=
 =?us-ascii?Q?mz3YZvwpZbA6WlkSTO1NI8DRn+hFK4am340DOnEc4tZ0JEFYfaAc20IiRio8?=
 =?us-ascii?Q?jFJM/7LNYpwFTLLUUZfMgyfzTo3REHSoiZjqTsIM/Ddu8YWlOlTKaMYFH10d?=
 =?us-ascii?Q?HdwlEWK3nJftcO3rOwxv5tu2ZM1stcJ/43RUwD4boB1rd8Wyh+sggB8G+VzB?=
 =?us-ascii?Q?briYvujsPBd3iimpKTkyQqEnpaDYLoAxMRKln6+uTtBVsnNoAJatAj3Lspbn?=
 =?us-ascii?Q?+mms1CmehB48cz64AqrqJY3QC6hwr7/0uHTv51rrsElG+P/OhgpdOJNo/fyo?=
 =?us-ascii?Q?POy9o4ot8j4WXXZx8UyqTvrwHHo3YcnMYXU2O5lT/IeoeN+VhCyr0obBvf6E?=
 =?us-ascii?Q?/xDTx4W9SH4bu7/Cm1fbsUMqLNUocjl5zWsyB7KO7OD9J/ziYoVgOfyp/zK+?=
 =?us-ascii?Q?bMf2j6SQ+7lLpkWEiEhTSLSMqgRydVDdkESkLR3molRGot02D17Gzyq+j6u+?=
 =?us-ascii?Q?Y1sM+T42CkrCqjTm6UIdt9KU+mcS0CmvW+HTPRbd5LmfQdktnRXXlv+v3D+W?=
 =?us-ascii?Q?kbxH5aqHWiZH20GxgHQkRBNvRJie3ojYiKRCzJHWBJNfzBP0EKUF+x6zVkD5?=
 =?us-ascii?Q?TlM3M7ydSkBDdTKO/vth3nWfhmG+HGY7+qSCW/a7SSQPC7hXRKT3ezwoObRe?=
 =?us-ascii?Q?ppDOxMxjLVH0xCjeE7qfVogbtZFlsopUNWlzt5cWN5kifE+1NIu3Ou99JsCj?=
 =?us-ascii?Q?KoJum+JsugOye5R9FzCMdK6cwZ7lSErLFkPwyeb1EBZ2rhvn7iAIeBIh5Qos?=
 =?us-ascii?Q?KaIa9S/Imlup+ybWf0aL329yjtvTRhinXytb4eQCOXTdh3lJQ5HBRSYBeq6Z?=
 =?us-ascii?Q?1+39cHCnMg+O46X9S83ZKDYoUfTzrcuzv8JIDsygtzbSm1a62GbgY4DimT8m?=
 =?us-ascii?Q?Sak8CmdRBf/cdT+3m4OUd6H9WK23d9za0k4iU0NtALoHMm7b8wok6E/YLXLf?=
 =?us-ascii?Q?28sfL5wXY77lip1rYSTtrHLM1IYanTlSTeuyeSsRdPugngKUiTvkL8lUsIC+?=
 =?us-ascii?Q?6AvU6toWt6ssOGN8LvZHcwAeiszr4VjtVBz89EketgzS14xUZgz61Qn+4xZr?=
 =?us-ascii?Q?7DTadrVc43KiEz+o80i5v5RF5C84RmsMTGAnA2H4?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de9173fa-8fe6-4e50-d074-08dadc419f28
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2022 13:06:03.0095
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KD6uiWOp6dM2C9U0bkfkcco0a5tpsoBsjxfRULO96YYiTHa7seKPKkykMmTEzHLKniQ8q6MbNlwvZFaZt89PEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5698
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

> static inline bool f2fs_realtime_discard_enable(struct f2fs_sb_info *sbi) {
> 	return (test_opt(sbi, DISCARD) && f2fs_hw_support_discard(sbi)) ||
> 					f2fs_hw_should_discard(sbi);
> }

> It looks the logic is changed?

For a storage device that does not support discard, and we have not actually
issued any discard command. I don't think it is necessary and f2fs should not
be equipped with trim markers.

Thx,
Yangtao