Date: Tue, 14 Aug 2007 13:12:02 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: xemul@openvz.org
Cc: devel@openvz.org, linux-kernel@vger.kernel.org, containers@lists.osdl.org,
       oleg@tv-sign.ru, sukadev@us.ibm.com
Subject: Re: [PATCH 19/20] Changes to show virtual ids to user
Message-Id: <20070814131202.73b7d559.akpm@linux-foundation.org>
In-Reply-To: <46BC508C.mailGLJ118R5H@openvz.org>
References: <46BC508C.mailGLJ118R5H@openvz.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1523
Lines: 35

On Fri, 10 Aug 2007 15:48:28 +0400
xemul@openvz.org wrote:

> This is the largest patch in the set. Make all (I hope) the places where
> the pid is shown to or get from user operate on the virtual pids.
> 
> The idea is:
>  - all in-kernel data structures must store either struct pid itself
>    or the pid's global nr, obtained with pid_nr() call;
>  - when seeking the task from kernel code with the stored id one
>    should use find_task_by_pid() call that works with global pids;
>  - when showing pid's numerical value to the user the virtual one
>    should be used, but however when one shows task's pid outside this
>    task's namespace the global one is to be used;
>  - when getting the pid from userspace one need to consider this as
>    the virtual one and use appropriate task/pid-searching functions.
> 
> ...
>
> -	si.si_pid = current->pid;
> +	si.si_pid = task_pid_vnr(current);

This is going to be an ongoing maintenance problem: people will sneak
new references to current->pid into the tree and nobody will notice.

It'd be best to rename task_struct.pid to something else to catch such
problems and to force people to use the right accessors.  Is that feasible?

Generally this is a tactic which should be used whenever things like this
are virtualised.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/