Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Dec 2022 16:48:05 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_3/6=5D_arm64=3A_dts=3A_qcom=3A_sc7180=3A?= =?US-ASCII?Q?_move_QUP_and_QSPI_opp_tables_out_of_SoC_node?=
User-Agent: K-9 Mail for Android
In-Reply-To: <20221212100232.138519-3-krzysztof.kozlowski@linaro.org>
References: <20221212100232.138519-1-krzysztof.kozlowski@linaro.org> <20221212100232.138519-3-krzysztof.kozlowski@linaro.org>
Message-ID: <D0FE36DB-5A1A-493B-A909-C626467D7B3F@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 12 December 2022 13:02:29 GMT+03:00, Krzysztof Kozlowski <krzysztof=2Ek=
ozlowski@linaro=2Eorg> wrote:
>The SoC node is a simple-bus and its schema expect to have nodes only
>with unit addresses:
>
>  sc7180-trogdor-lazor-r3=2Edtb: soc@0: opp-table-qspi: {'compatible': ['=
operating-points-v2'], 'phandle': [[186]], 'opp-75000000':
>    =2E=2E=2E  'required-opps': [[47]]}} should not be valid under {'type=
': 'object'}
>
>Move to top-level OPP tables:
> - QUP which is shared between multiple nodes,
> - QSPI which cannot be placed in its node due to address/size cells=2E
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof=2Ekozlowski@linaro=2Eorg>
>Reviewed-by: Konrad Dybcio <konrad=2Edybcio@linaro=2Eorg>

Reviewed-by: Dmitry Baryshkov<dmitry=2Ebaryshkov@linaro=2Eorg>

>
>---
>
>Changes since v1:
>1=2E Only rebase due to node reorderings=2E
>2=2E Add Rb tag=2E
>---
> arch/arm64/boot/dts/qcom/sc7180=2Edtsi | 76 ++++++++++++++--------------
> 1 file changed, 38 insertions(+), 38 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/qcom/sc7180=2Edtsi b/arch/arm64/boot/dts=
/qcom/sc7180=2Edtsi
>index 6d3e86ce2936=2E=2Eeb1e1ea12ff6 100644
>--- a/arch/arm64/boot/dts/qcom/sc7180=2Edtsi
>+++ b/arch/arm64/boot/dts/qcom/sc7180=2Edtsi
>@@ -494,6 +494,44 @@ cpu6_opp16: opp-2553600000 {
> 		};
> 	};
>=20
>+	qspi_opp_table: opp-table-qspi {
>+		compatible =3D "operating-points-v2";
>+
>+		opp-75000000 {
>+			opp-hz =3D /bits/ 64 <75000000>;
>+			required-opps =3D <&rpmhpd_opp_low_svs>;
>+		};
>+
>+		opp-150000000 {
>+			opp-hz =3D /bits/ 64 <150000000>;
>+			required-opps =3D <&rpmhpd_opp_svs>;
>+		};
>+
>+		opp-300000000 {
>+			opp-hz =3D /bits/ 64 <300000000>;
>+			required-opps =3D <&rpmhpd_opp_nom>;
>+		};
>+	};
>+
>+	qup_opp_table: opp-table-qup {
>+		compatible =3D "operating-points-v2";
>+
>+		opp-75000000 {
>+			opp-hz =3D /bits/ 64 <75000000>;
>+			required-opps =3D <&rpmhpd_opp_low_svs>;
>+		};
>+
>+		opp-100000000 {
>+			opp-hz =3D /bits/ 64 <100000000>;
>+			required-opps =3D <&rpmhpd_opp_svs>;
>+		};
>+
>+		opp-128000000 {
>+			opp-hz =3D /bits/ 64 <128000000>;
>+			required-opps =3D <&rpmhpd_opp_nom>;
>+		};
>+	};
>+
> 	pmu {
> 		compatible =3D "arm,armv8-pmuv3";
> 		interrupts =3D <GIC_PPI 5 IRQ_TYPE_LEVEL_HIGH>;
>@@ -739,25 +777,6 @@ opp-384000000 {
> 			};
> 		};
>=20
>-		qup_opp_table: opp-table-qup {
>-			compatible =3D "operating-points-v2";
>-
>-			opp-75000000 {
>-				opp-hz =3D /bits/ 64 <75000000>;
>-				required-opps =3D <&rpmhpd_opp_low_svs>;
>-			};
>-
>-			opp-100000000 {
>-				opp-hz =3D /bits/ 64 <100000000>;
>-				required-opps =3D <&rpmhpd_opp_svs>;
>-			};
>-
>-			opp-128000000 {
>-				opp-hz =3D /bits/ 64 <128000000>;
>-				required-opps =3D <&rpmhpd_opp_nom>;
>-			};
>-		};
>-
> 		qupv3_id_0: geniqup@8c0000 {
> 			compatible =3D "qcom,geni-se-qup";
> 			reg =3D <0 0x008c0000 0 0x6000>;
>@@ -2655,25 +2674,6 @@ opp-202000000 {
> 			};
> 		};
>=20
>-		qspi_opp_table: opp-table-qspi {
>-			compatible =3D "operating-points-v2";
>-
>-			opp-75000000 {
>-				opp-hz =3D /bits/ 64 <75000000>;
>-				required-opps =3D <&rpmhpd_opp_low_svs>;
>-			};
>-
>-			opp-150000000 {
>-				opp-hz =3D /bits/ 64 <150000000>;
>-				required-opps =3D <&rpmhpd_opp_svs>;
>-			};
>-
>-			opp-300000000 {
>-				opp-hz =3D /bits/ 64 <300000000>;
>-				required-opps =3D <&rpmhpd_opp_nom>;
>-			};
>-		};
>-
> 		qspi: spi@88dc000 {
> 			compatible =3D "qcom,sc7180-qspi", "qcom,qspi-v1";
> 			reg =3D <0 0x088dc000 0 0x600>;

--=20
With best wishes
Dmitry