Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Dec 2022 16:48:26 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_5/6=5D_arm64=3A_dts=3A_qcom?= =?US-ASCII?Q?=3A_sdm845=3A_move_sound_node_out_of_soc?=
User-Agent: K-9 Mail for Android
In-Reply-To: <20221212100232.138519-5-krzysztof.kozlowski@linaro.org>
References: <20221212100232.138519-1-krzysztof.kozlowski@linaro.org> <20221212100232.138519-5-krzysztof.kozlowski@linaro.org>
Message-ID: <7B64882E-CBFE-487A-83D5-BE267FD0B120@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 12 December 2022 13:02:31 GMT+03:00, Krzysztof Kozlowski <krzysztof=2Ek=
ozlowski@linaro=2Eorg> wrote:
>The sound node is not property of the soc, but rather board as it
>describes the sound configuration=2E  It also does not have unit address:
>
>  sdm845-shift-axolotl=2Edtb: soc@0: sound: {} should not be valid under =
{'type': 'object'}
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof=2Ekozlowski@linaro=2Eorg>
>Reviewed-by: Konrad Dybcio <konrad=2Edybcio@linaro=2Eorg>

Reviewed-by: Dmitry Baryshkov<dmitry=2Ebaryshkov@linaro=2Eorg>

>
>---
>
>Changes since v1:
>1=2E Add Rb tag=2E
>---
> arch/arm64/boot/dts/qcom/sdm845=2Edtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/qcom/sdm845=2Edtsi b/arch/arm64/boot/dts=
/qcom/sdm845=2Edtsi
>index 8eeb3aa261d5=2E=2E5f1f7cb52c90 100644
>--- a/arch/arm64/boot/dts/qcom/sdm845=2Edtsi
>+++ b/arch/arm64/boot/dts/qcom/sdm845=2Edtsi
>@@ -3964,9 +3964,6 @@ lmh_cluster0: lmh@17d78800 {
> 			#interrupt-cells =3D <1>;
> 		};
>=20
>-		sound: sound {
>-		};
>-
> 		usb_1_hsphy: phy@88e2000 {
> 			compatible =3D "qcom,sdm845-qusb2-phy", "qcom,qusb2-v2-phy";
> 			reg =3D <0 0x088e2000 0 0x400>;
>@@ -5341,6 +5338,9 @@ wifi: wifi@18800000 {
> 		};
> 	};
>=20
>+	sound: sound {
>+	};
>+
> 	thermal-zones {
> 		cpu0-thermal {
> 			polling-delay-passive =3D <250>;

--=20
With best wishes
Dmitry