Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Dec 2022 16:48:39 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_6/6=5D_arm64=3A_dts=3A_qcom=3A_sm82?= =?US-ASCII?Q?50=3A_move_sound_and_codec_nodes_out_of_soc?=
User-Agent: K-9 Mail for Android
In-Reply-To: <20221212100232.138519-6-krzysztof.kozlowski@linaro.org>
References: <20221212100232.138519-1-krzysztof.kozlowski@linaro.org> <20221212100232.138519-6-krzysztof.kozlowski@linaro.org>
Message-ID: <7110E919-E87C-4AF8-BD23-D10251D769AC@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 12 December 2022 13:02:32 GMT+03:00, Krzysztof Kozlowski <krzysztof=2Ek=
ozlowski@linaro=2Eorg> wrote:
>The sound and on-board WCD9380 codec nodes are not properties of the
>soc, but rather board as it describes the sound configuration=2E  They al=
so
>does not have unit addresses:
>
>  sm8250-hdk=2Edtb: soc@0: sound: {} should not be valid under {'type': '=
object'}
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof=2Ekozlowski@linaro=2Eorg>
>Reviewed-by: Konrad Dybcio <konrad=2Edybcio@linaro=2Eorg>

Reviewed-by: Dmitry Baryshkov<dmitry=2Ebaryshkov@linaro=2Eorg>


>
>---
>
>Changes since v1:
>1=2E Add Rb tag=2E
>2=2E Rephrase commit msg=2E
>---
> arch/arm64/boot/dts/qcom/sm8250-mtp=2Edts | 40 ++++++++++++-------------
> arch/arm64/boot/dts/qcom/sm8250=2Edtsi    |  6 ++--
> 2 files changed, 22 insertions(+), 24 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/qcom/sm8250-mtp=2Edts b/arch/arm64/boot/=
dts/qcom/sm8250-mtp=2Edts
>index 3ed8c84e25b8=2E=2Eb741b7da1afc 100644
>--- a/arch/arm64/boot/dts/qcom/sm8250-mtp=2Edts
>+++ b/arch/arm64/boot/dts/qcom/sm8250-mtp=2Edts
>@@ -27,6 +27,25 @@ chosen {
> 		stdout-path =3D "serial0:115200n8";
> 	};
>=20
>+	wcd938x: codec {
>+		compatible =3D "qcom,wcd9380-codec";
>+		#sound-dai-cells =3D <1>;
>+		reset-gpios =3D <&tlmm 32 GPIO_ACTIVE_LOW>;
>+		vdd-buck-supply =3D <&vreg_s4a_1p8>;
>+		vdd-rxtx-supply =3D <&vreg_s4a_1p8>;
>+		vdd-io-supply =3D <&vreg_s4a_1p8>;
>+		vdd-mic-bias-supply =3D <&vreg_bob>;
>+		qcom,micbias1-microvolt =3D <1800000>;
>+		qcom,micbias2-microvolt =3D <1800000>;
>+		qcom,micbias3-microvolt =3D <1800000>;
>+		qcom,micbias4-microvolt =3D <1800000>;
>+		qcom,mbhc-buttons-vthreshold-microvolt =3D <75000 150000 237000 500000=
 500000 500000 500000 500000>;
>+		qcom,mbhc-headset-vthreshold-microvolt =3D <1700000>;
>+		qcom,mbhc-headphone-vthreshold-microvolt =3D <50000>;
>+		qcom,rx-device =3D <&wcd_rx>;
>+		qcom,tx-device =3D <&wcd_tx>;
>+	};
>+
> 	thermal-zones {
> 		camera-thermal {
> 			polling-delay-passive =3D <0>;
>@@ -631,27 +650,6 @@ &slpi {
> 	firmware-name =3D "qcom/sm8250/slpi=2Embn";
> };
>=20
>-&soc {
>-	wcd938x: codec {
>-		compatible =3D "qcom,wcd9380-codec";
>-		#sound-dai-cells =3D <1>;
>-		reset-gpios =3D <&tlmm 32 GPIO_ACTIVE_LOW>;
>-		vdd-buck-supply =3D <&vreg_s4a_1p8>;
>-		vdd-rxtx-supply =3D <&vreg_s4a_1p8>;
>-		vdd-io-supply =3D <&vreg_s4a_1p8>;
>-		vdd-mic-bias-supply =3D <&vreg_bob>;
>-		qcom,micbias1-microvolt =3D <1800000>;
>-		qcom,micbias2-microvolt =3D <1800000>;
>-		qcom,micbias3-microvolt =3D <1800000>;
>-		qcom,micbias4-microvolt =3D <1800000>;
>-		qcom,mbhc-buttons-vthreshold-microvolt =3D <75000 150000 237000 500000=
 500000 500000 500000 500000>;
>-		qcom,mbhc-headset-vthreshold-microvolt =3D <1700000>;
>-		qcom,mbhc-headphone-vthreshold-microvolt =3D <50000>;
>-		qcom,rx-device =3D <&wcd_rx>;
>-		qcom,tx-device =3D <&wcd_tx>;
>-	};
>-};
>-
> &sound {
> 	compatible =3D "qcom,sm8250-sndcard";
> 	model =3D "SM8250-MTP-WCD9380-WSA8810-VA-DMIC";
>diff --git a/arch/arm64/boot/dts/qcom/sm8250=2Edtsi b/arch/arm64/boot/dts=
/qcom/sm8250=2Edtsi
>index d517d6a80bdc=2E=2Efbbbae29e0c2 100644
>--- a/arch/arm64/boot/dts/qcom/sm8250=2Edtsi
>+++ b/arch/arm64/boot/dts/qcom/sm8250=2Edtsi
>@@ -2826,9 +2826,6 @@ compute-cb@8 {
> 			};
> 		};
>=20
>-		sound: sound {
>-		};
>-
> 		usb_1_hsphy: phy@88e3000 {
> 			compatible =3D "qcom,sm8250-usb-hs-phy",
> 				     "qcom,usb-snps-hs-7nm-phy";
>@@ -4910,6 +4907,9 @@ cpufreq_hw: cpufreq@18591000 {
> 		};
> 	};
>=20
>+	sound: sound {
>+	};
>+
> 	timer {
> 		compatible =3D "arm,armv8-timer";
> 		interrupts =3D <GIC_PPI 13

--=20
With best wishes
Dmitry