Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Dec 2022 22:33:05 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Yicong Yang <yangyicong@huawei.com>
CC:     <yangyicong@hisilicon.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Honglei Wang <wanghonglei@didichuxing.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "Tim Chen" <tim.c.chen@intel.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        "Juri Lelli" <juri.lelli@redhat.com>,
        Rik van Riel <riel@surriel.com>,
        Aaron Lu <aaron.lu@intel.com>,
        Abel Wu <wuyun.abel@bytedance.com>,
        K Prateek Nayak <kprateek.nayak@amd.com>,
        "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
        Ingo Molnar <mingo@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        Hillf Danton <hdanton@sina.com>,
        Len Brown <len.brown@intel.com>,
        Chen Yu <yu.chen.surf@gmail.com>,
        "Tianchen Ding" <dtcccc@linux.alibaba.com>,
        <linux-kernel@vger.kernel.org>, Josh Don <joshdon@google.com>
Subject: Re: [PATCH v3 1/2] sched/fair: Introduce short duration task check
Message-ID: <Y5c7oTIRIQYYkdW1@chenyu5-mobl1>
References: <Y4r/iuqyLG4MOK4d@chenyu5-mobl1>
 <3A5DA66F-4330-4FC4-9229-998CF98F663E@joelfernandes.org>
 <Y42uH5fglluWYOm7@chenyu5-mobl1>
 <CAKfTPtA61DDk-VbNDvAycp8Et5fTwaOS=Q3559rBF7QDHDpJfQ@mail.gmail.com>
 <CABk29Nuc+VVOpAwFsbBo+OppayszebT29Hadc8qK-xeyZpY6NQ@mail.gmail.com>
 <Y5CiN010QAwklahh@chenyu5-mobl1>
 <e0b20fe3-6528-41ca-f53f-d78e76cd122a@huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <e0b20fe3-6528-41ca-f53f-d78e76cd122a@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WpkidtiDLf8J+U3zIrK3Pk8+8Os1Zo1O869c0m66JBLGb8L/sMJ7XBfsec38?=
 =?us-ascii?Q?PoEcB873fSNTes+uWUKDveBpidDVMP4kw+IgHtc2M28i54bVLK9QQ9PnY9j2?=
 =?us-ascii?Q?e7wwd54L96xUIse+ZTE72hJOHeARNAsdaJYvGgmw4vb5j6w5kiP2TRp299YR?=
 =?us-ascii?Q?l/9ajV1mb5YAYjQPNrJhq+iHvyDYQXJlLwYjg1xEGcv59OYO48zZNFi+5sBr?=
 =?us-ascii?Q?ahV3fpTfQmj5jXtYgqdTGvKWoNGDvW8Z956WD0D0WHCivTbyO5nyZJ6mmDqT?=
 =?us-ascii?Q?fDYwgLyprle0M3WzJUn7R2foQNn6n8kxagJcf5R4/OOGmRRlhixn7d1X4Hfo?=
 =?us-ascii?Q?lRN8dmKtuRsTUMhTsVHqlRUzDwWKIz4erV8ykLyRBRy6mtt4nvnHOCO8UcFn?=
 =?us-ascii?Q?C3w4bFGAgkrTbTu1bbY2QcGE63i2/JubVzsn+RNWsTmMw950ouc7UY/nnnuu?=
 =?us-ascii?Q?kU46z8OJFbgPoB7xay+mPWyT8Ok5Ot08F+nUe8OY538QPoH2R9uGLoq2BVHZ?=
 =?us-ascii?Q?WZuAvMDaEKIhW/Hm4eXekqp15s//ciuXusmrr0AknKmb0vSXy2WMIYLkr4T4?=
 =?us-ascii?Q?eIVGXogf/cSaJsfLOmaZJrE5q1wD8W0j57sC0rs5iTtRvedF8Yd67LU6+t7T?=
 =?us-ascii?Q?2SgtqjqqQYWJzAxBk2v5S27XakbLe6uzM3A62aGp36FeOrM6PGiHOEEuc8Yx?=
 =?us-ascii?Q?ro+D+MBuVOHdFThN6ms5L6cs9JVyfV+YTjsYOIIL6TsVKRqcfyd6FhFfzPo+?=
 =?us-ascii?Q?4MVNKyV2ru/mS718H/Fq8UDYX7hicdkrNr3vz1g6yyBxZ4BQ72w5SHhlbylW?=
 =?us-ascii?Q?Tej7Lskl9HrtzuRZL/uKGVOtUZm9LkAPhcVFDf+ryWMSOr4j6bU7DzvYFywu?=
 =?us-ascii?Q?34Bz+dXSH774hsg7xy6kbv4vIvGZo4yL00Dp/NbRee/CKUjSm/Z1+C77gH3l?=
 =?us-ascii?Q?4DfP8IpK12LtN5//TFwBlOtvL0rkRoahnCmfqgorvyOkt7GX1eFMi+K7kYYs?=
 =?us-ascii?Q?CvHZI/q5LEyPlxWTgNu6HHz8bfz8F991j9+FcO6BTobGvEJ8X2P4nJm/lfZJ?=
 =?us-ascii?Q?c3GzWtcF10ZpmkHoJ1Q9utx7RpOIpvwzpvHoA2LQeRkt6eRvB4Dyuu/TVb6V?=
 =?us-ascii?Q?QHo2oUMxo1J0/VBZowjanegZHUwWHuO12MWlJogibcR/MLZzjGAasKZUKCN8?=
 =?us-ascii?Q?ibgA9IlfGoJQKvi8PJcUR8q+26MR4wG9opvc6SX+c1o6UpsLHFD2eu6+Zwsc?=
 =?us-ascii?Q?1wyKLbUFo4adtLHPD9GkYWYZUW+TNDUO6h01SxmX8hpRGKji9F+Q/KwUcDt6?=
 =?us-ascii?Q?/78JAb8HOJ/ke9IMMazG/mZwdb3X5I7wnL2f/cj53Bg8Dx+0/x8YD5q3vJ4d?=
 =?us-ascii?Q?Q4nMTqSDRR9VaF6sOGBZb9WqUQZsHKb5vAFm2CjsQ7OpNeckWyRnpy/W0UkG?=
 =?us-ascii?Q?sk4EkvbfiCQagv3y7d0v8t+F1AC0dnvD/ZvI1+2ZTbd4B4xiSOz6mZ/9k7KE?=
 =?us-ascii?Q?8lHK0ZGEL4xXlt3Eojz0MUEEGLLhI1sq4VG0uxil1S6u4m1xWCDF/DZHoWAR?=
 =?us-ascii?Q?QY1J1H2vxSU2ySyLdPjgsTtKmLxXRvlhKzaCaXaw?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fb74156-9ff7-4344-176f-08dadc4dd888
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2022 14:33:33.3032
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N4W6ghviyiHEbkV8rZZkXnoxqJ1xsxt1bn0NRK5qX+l4H5zQVn4NkIek9dPo1ylohZ5vskIbxNa1dsxNpLZ0Ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6872
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-12-12 at 19:22:48 +0800, Yicong Yang wrote:
> On 2022/12/7 22:24, Chen Yu wrote:
> > Hi Josh,
> > On 2022-12-06 at 18:23:47 -0800, Josh Don wrote:
> >>> We don't want to add more dedicated knobs. So using
> >>> sysctl_sched_min_granularity as you are doing in this patch looks ok
> >>
> >> If not a knob, then maybe at least a smaller hardcoded value? Several
> >> milliseconds seems like too long for this optimization; the
> >> opportunity cost of not doing the idle search likely doesn't make
> >> sense if the waker is going to be active for several additional
> >> milliseconds. I would have guessed something on the order of 100us.
> >>
> >> Chen, what is the run duration of tasks in your ping pong example?
> > OK, I'll measure the duration of all the tests and summarize the data later.
> > 
> 
> If we decide to use sysctl_sched_min_granularity as the threshold of a short
> task, can we also export p->se.dur_avg (somewhere like /proc/[pid]/sched)?
> It may be helpful to choose a proper value for sysctl_sched_min_granularity.
This looks reasonable, I can add one in next version.
BTW, I've changed the threshold to (sysctl_sched_min_granularity / 8) in my next
version, as this is the value that fit my previous test case and also not to break
the case Josh mentioned. Also I've changed the place where dur_avg is updated from
put_prev_task() to dequeue_task(), which could fix an issue in v3. Will send v4
out after the test finished.

thanks,
Chenyu
> 
> Thanks.