Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4ea86d83-610a-9a14-fda8-e25bd9d4addb@intel.com>
Date:   Mon, 12 Dec 2022 08:32:43 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.5.1
Subject: Re: [PATCH] dmaengine: idxd: Remove the unused function
 set_completion_address()
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        fenghua.yu@intel.com
Cc:     vkoul@kernel.org, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20221212033514.5831-1-jiapeng.chong@linux.alibaba.com>
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20221212033514.5831-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/11/2022 8:35 PM, Jiapeng Chong wrote:
> The function set_completion_address is defined in the dma.c file, but not
> called elsewhere, so remove this unused function.
> 
> drivers/dma/idxd/dma.c:66:20: warning: unused function 'set_completion_address'.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3416
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Acked-by: Dave Jiang <dave.jiang@intel.com>
Thanks for the cleanup
> ---
>   drivers/dma/idxd/dma.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/dma/idxd/dma.c b/drivers/dma/idxd/dma.c
> index e0874cb4721c..eb35ca313684 100644
> --- a/drivers/dma/idxd/dma.c
> +++ b/drivers/dma/idxd/dma.c
> @@ -63,12 +63,6 @@ static void op_flag_setup(unsigned long flags, u32 *desc_flags)
>   		*desc_flags |= IDXD_OP_FLAG_RCI;
>   }
>   
> -static inline void set_completion_address(struct idxd_desc *desc,
> -					  u64 *compl_addr)
> -{
> -		*compl_addr = desc->compl_dma;
> -}
> -
>   static inline void idxd_prep_desc_common(struct idxd_wq *wq,
>   					 struct dsa_hw_desc *hw, char opcode,
>   					 u64 addr_f1, u64 addr_f2, u64 len,