Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Dec 2022 16:24:58 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Nhat Pham <nphamcs@gmail.com>
Cc:     Al Viro <viro@zeniv.linux.org.uk>, akpm@linux-foundation.org,
        hannes@cmpxchg.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, bfoster@redhat.com,
        kernel-team@meta.com
Subject: Re: [PATCH v2 3/4] cachestat: implement cachestat syscall
Message-ID: <Y5dV2jrZGMvgIZCx@casper.infradead.org>
References: <20221205175140.1543229-1-nphamcs@gmail.com>
 <20221205175140.1543229-4-nphamcs@gmail.com>
 <Y5UbhBTB2nSMN4UD@ZenIV>
 <CAKEwX=NwUPShF3zud7kn_gyd4BZy8S6xzm6iFuw0eW=o=3A8nw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKEwX=NwUPShF3zud7kn_gyd4BZy8S6xzm6iFuw0eW=o=3A8nw@mail.gmail.com>
Precedence: bulk

On Mon, Dec 12, 2022 at 08:23:31AM -0800, Nhat Pham wrote:
> > It would be easier to read if you inverted the condition here.
> 
> Oh I think I tried
> 
> if (!f.file)
>        return -EBADF;
> 
> here, but there are some mixing-code-with-decl warnings.
> If I recall correctly, the problem is with this line:
> 
> XA_STATE(xas, &mapping->i_pages, first_index);
> 
> which is expanded into a declaration:
> 
> #define XA_STATE(name, array, index) \
> struct xa_state name = __XA_STATE(array, index, 0, 0)
> 
> It requires a valid mapping though, which is
> obtained from f.file:
> 
> struct address_space *mapping = f.file->f_mapping;
> 
> so it cannot be moved above the if(!f.file) check either...

Perhaps you're trying to do too much in a single function?