Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Dec 2022 11:52:00 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
CC:     <joonas.lahtinen@linux.intel.com>,
        <tvrtko.ursulin@linux.intel.com>,
        <intel-gfx@lists.freedesktop.org>,
        Abaci Robot <abaci@linux.alibaba.com>,
        <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/hwconfig: Modify mismatched function name
Message-ID: <Y5dcMKDZmMNJdiJu@intel.com>
References: <20221212032012.114253-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221212032012.114253-1-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yFZJekvSl92TNueAVH8l1++9QSd0P/zSSJei/wOVCao2IXVCTSSuCYfgiIlK?=
 =?us-ascii?Q?gbVxJNhT3y/AMTyz/XGyNrXgKlkk6ErByr1Mb0iSbndh/wMaOxuX7yJPBMAy?=
 =?us-ascii?Q?D0L3YRi6m5y2tMuDDg/phqpZGiCpG1X4A55ZM04kgCottdwsq50FfR+zMPOd?=
 =?us-ascii?Q?L8MDbSgZhBIzeuDXzrlxZnHEkf1LPBmcpaJ63ZZPS5fqpcg6tWufM4d9IftG?=
 =?us-ascii?Q?PjkNtoczIdmLmsd+AqXey5IUIBaPw2uD75S3pXqOGumsd+PSeL9Y7BXKS59G?=
 =?us-ascii?Q?gRLtON858ONNzBFuHS+C/BSpo34VTtnrnWMMmIrvt2KlLmmfwrL3WA45a766?=
 =?us-ascii?Q?omXqLd07EhBTlv+F1Ik8eyzT8drpnDbg9qHp45orl/y6g0YE4H9uzmLStv5V?=
 =?us-ascii?Q?IrfsKzhwAeiOzJTye8tp/lwZX/CYQiHbgKiPKtry+AgpwP13WL9J3sVVaGlS?=
 =?us-ascii?Q?KyecDjhI+cm1BEEbAxy6B2gqdu468CvvKPWSjnGhdKX59pI/Tk3n2N+se7r9?=
 =?us-ascii?Q?GsRKUQ8tTOBRl5cAeOkQ1QNTAVT2tOZKiy4o2ztI7nhOKdC7HO4VtxLDU/1v?=
 =?us-ascii?Q?mAQLAd/u9zdv4KSiAesVfHELibkMF+Me04UIf/1gVYus1yldB+v3wUdlr6ua?=
 =?us-ascii?Q?hx1NXRHYApq4FmiaSIgdvPuQGLCloKA6znW63jJ0T7pAVCFPMAJ0wu5ixa4g?=
 =?us-ascii?Q?tHdGmApN94nYuhQ5ZegktbwZoS7FCn4y3Lct6FujPcT1FNj7vDbkr5alM4A7?=
 =?us-ascii?Q?ZAb6sm2IzuKfWWqUg3Zke5cUrlZJzEQvWPoQ787tevuxWqhj4A6ubDKmej+e?=
 =?us-ascii?Q?v/oCKoEZ77Yvwc+hrZalh1zwKrHBJkQkEoaFoHKCimQzN0Kfwofhyny8ijXX?=
 =?us-ascii?Q?FmWwIZV3pWx85pcr4WPs/C9C22oNOBG4F8TVwjn9L15bP8fP3/3w5LaoY4+/?=
 =?us-ascii?Q?SzQMafjaqKMVJuLn6LZSumTOMX0RqrwqYDHZArylM3LVJz1zLXW9lsjme+G3?=
 =?us-ascii?Q?k10xsjiku0m98+2gDexrEnASpd7oHYQhY/SRt1AYmBHIzdra8MJQZ+ZJnwY5?=
 =?us-ascii?Q?+2xVEXe5LdJAQs+WcomEjd5D342cXVE/sgiWS54J7U/B7m6tIs5pC3t/3E+8?=
 =?us-ascii?Q?nnU/MxvAOSLiu0VPjdoDUOLaEtUDRLpDlu6hsA5cGR0jiAfZ+XaN/8l0giTt?=
 =?us-ascii?Q?tR+DRiO7c2tQ+snLbB04MVfg/6C8VQpFs/elL5UnwO2xwkHh24ofs/MpRu6q?=
 =?us-ascii?Q?7EZ38dBuGGPeDDQLwNBNfY6iGr4ccfhULBI9Oy2TxR/tI7sM0HN59addf0yP?=
 =?us-ascii?Q?0+lhEeOzk34m5+vBDAsAzuli90l7IwuS/5RCoQanFQhsZSh78gQYbG5IWfAw?=
 =?us-ascii?Q?dC4BOqkJSo70tPo9gnaRXYV8455d8a2HJpQxO2/GiQepxZS31N2Q4v07RliP?=
 =?us-ascii?Q?TG/MQJqW/Xf6XLfF9wv9cEvUPL7Wql51ebP5YSvfulAjMWrzFLtVgfdySXew?=
 =?us-ascii?Q?E7+XFxWONI17gMPf1xghax85NafoIy01bNfoob7wayvxRpYVYnoQ641G46TT?=
 =?us-ascii?Q?zssNZZQ9iHe2z1z0lkIe/bCwYEKPXKptvAIUYefY?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 68ceb758-6af0-4bfa-61b3-08dadc6132d6
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2022 16:52:05.1852
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kYzHFmIdSgbGGTRR4EtC6dfREgkKiHIXLI9/PQkx+xMnzSvgWSag0ngWDwh4FEgXfRW+MQZxDZPYMBQnqOzWbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6349
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 12, 2022 at 11:20:12AM +0800, Jiapeng Chong wrote:
> No functional modification involved.
> 
> drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:112: warning: expecting prototype for intel_guc_hwconfig_init(). Prototype was for guc_hwconfig_init() instead.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3414
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
> index 4781fccc2687..bdb20beb3e70 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
> @@ -103,7 +103,7 @@ static bool has_table(struct drm_i915_private *i915)
>  }
>  
>  /**
> - * intel_guc_hwconfig_init - Initialize the HWConfig
> + * guc_hwconfig_init - Initialize the HWConfig
>   *
>   * Retrieve the HWConfig table from the GuC and save it locally.
>   * It can then be queried on demand by other users later on.
> -- 

The name chaged when the function become static. And we shouldn't be
documenting internal static functions. So, could you please entirely
remove this comment block instead of fixing the name?

Thanks,
Rodrigo. 

> 2.20.1.7.g153144c
>