Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Yu, Fenghua" <fenghua.yu@intel.com>
To:     Jerry Snitselaar <jsnitsel@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "Jiang, Dave" <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Subject: RE: [PATCH] idxd: avoid deadlock in process_misc_interrupts()
Thread-Topic: [PATCH] idxd: avoid deadlock in process_misc_interrupts()
Thread-Index: AQHYtw0S0FsWXwDkFUuidHjlLK0eA65rRYpw
Date:   Mon, 12 Dec 2022 18:47:02 +0000
Message-ID: <IA1PR11MB6097183F44E96BE3FAF119DA9BE29@IA1PR11MB6097.namprd11.prod.outlook.com>
References: <20220823162435.2099389-1-jsnitsel@redhat.com>
In-Reply-To: <20220823162435.2099389-1-jsnitsel@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wzanKRluSm4+fCOHEcdVGofTyFRlsF7eVI1b69s8FNf1pCH8/3gaD1C5B8TE?=
 =?us-ascii?Q?L8fEApRiLtRZtv4Yu1RKk0sn5KexEdri5jaXS0jmNGDpzlsExLDsadJ0HUqQ?=
 =?us-ascii?Q?019o8slDjKQz3WilgUV0WF9irfWdKDpsvBrb3jEfCQRGkTmCX4IpslyAhUuG?=
 =?us-ascii?Q?l/tA2uMcoP1sz4/1hvB390Q5W5jMtZxoKjg+VPnKuxz4B/9cVsrWdbNCI7EW?=
 =?us-ascii?Q?OKba08qntlgvIGVElJrN8J2AzPcezpYljaWaupkpNk2B55hI06T8Q9NXTU/a?=
 =?us-ascii?Q?O2Qt1xQmtHWkVkGUc7JG3eMfnEcWj3Wz1u9PxxS5vW/KLx2jB8uILaAlntRt?=
 =?us-ascii?Q?7wcaQJIEykTulfOH/FseFZWbfiSFSpaKzKRonv51QGxnhi8APtGDKAn9ESUe?=
 =?us-ascii?Q?lz25NERQJWrY3W8ij4zO/rD0wfDU99HOf9CIwGbZPAT6pnEZ5dTWHh2U22+1?=
 =?us-ascii?Q?GjZqLcvhYFFk5x1wGfYclB+9Guom7+NGWkcx/Pyy+NIoa6RooJ7HGafyTQEd?=
 =?us-ascii?Q?yVQcIJ0pJ9piuj3vZac9DfdbXEKePVglamw+wpl84euvD+EGfLJzHQVbda48?=
 =?us-ascii?Q?gRa9DnAfCZ1qh4a0j3ASc9jtOcJazbH4ErS8E8y1moo53vAdNkb8f2g1k5AR?=
 =?us-ascii?Q?qFXVMx3My7Gtx8UNAWG0VrGESgjDUpzdWoN0mMUc6CtCvyh1TpdXkof3aJWq?=
 =?us-ascii?Q?xnUNJKV8mK8EfWsWmaP8Vb8PfXZj4TR92IzX/JOqz/9d5PNGRJ5tEKaOGi4j?=
 =?us-ascii?Q?dD6CqI0DaMbhlsBztkocqnLGeIWZcwQMt2G/VdUPU7I34oa+ckmWpRCfVasL?=
 =?us-ascii?Q?muhzeEvIGpmz8nJTofguym9wLVUmVMogSZSA+1W2vS0dOHzXFlreEOIS4aA+?=
 =?us-ascii?Q?2yV4ODnSmSBo766zcgNY91FJtR7Bsa+yoAE8iyGJy9IoX69yK+A1mCV9tFSB?=
 =?us-ascii?Q?3ietPzBpOBh+c5/YXDp8IDVgqp4MXC0V4hr0wSN5EiBibG32mpViGfYQQu7y?=
 =?us-ascii?Q?bfiVf32ujZK0x4kv36SwBUng4nchTn66sHoAAYiWu4Vk7K8Jx4ZBxSwplwc+?=
 =?us-ascii?Q?dyAdgrUTN1xKiDC0ED146Ct1BxwqcZ9NfOo7Zd+GbgpmfSDgkfIIrfPljqyJ?=
 =?us-ascii?Q?6VixH7g3D+T5K2VK/FF5Ywzjm5CmQuNtN8XRXLVVNLluNpSdbg03GLQbV0cV?=
 =?us-ascii?Q?jad6SYqD0WiPWDcLD32wTdOZGt8vKDLvb06ZG/Pq56y07fTEjPL6AYCBZN5P?=
 =?us-ascii?Q?pokkaTh+xO/uL3c4SoQ/2D8hdsbalrpFqWcWM95lKM9L0jnGrGtNX2oV+rAT?=
 =?us-ascii?Q?UXLh1Zjartx+NAIojmHQVi7m6FgUV5dA/+Wk1TY5cgw3dy8awEs981LkeCwT?=
 =?us-ascii?Q?CcAjvxriEA/r6Hnb2WQCtw7HwWH+EhKw3RGWmw5KBaAu5g9yDeiGZr8wQaat?=
 =?us-ascii?Q?wUYWOhbY7qNpYa64CzyOXH1M/N+VDbemOkwZRMtetMfO3lLCj8ncwPZ4lS+d?=
 =?us-ascii?Q?+qwEJgcQnbiP5iCXjSYkjQ0YBlIP3UuTl0TE3dIiKCvt2b+P3TecbZBSBH4D?=
 =?us-ascii?Q?hfC6ZJ3j6+RikqLpgLr5UEc5G8Wn4rhb6HDw3zTi?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48fc6700-6b99-45db-e552-08dadc714229
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2022 18:47:02.5334
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rhiMVZTIippWOcbZZZzMiNTped3lEMmRcdzYDlOoBTdYBiNRJV7FBE3KBFAwOxUpC5jTYuFYVDHnvFbV7ygJgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6052
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Jerry,

> idxd_device_clear_state() now grabs the idxd->dev_lock itself, so don't g=
rab the
> lock prior to calling it.
>=20
> This was seen in testing after dmar fault occurred on system, resulting i=
n lockup
> stack traces.
>=20

Please add Fixes: cf4ac3fef338 ...

> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: dmaengine@vger.kernel.org
> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
> ---
>  drivers/dma/idxd/irq.c | 2 --
>  1 file changed, 2 deletions(-)
>=20
> diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c index
> 743ead5ebc57..5b9921475be6 100644
> --- a/drivers/dma/idxd/irq.c
> +++ b/drivers/dma/idxd/irq.c
> @@ -324,13 +324,11 @@ static int process_misc_interrupts(struct idxd_devi=
ce
> *idxd, u32 cause)
>  			idxd->state =3D IDXD_DEV_HALTED;
>  			idxd_wqs_quiesce(idxd);
>  			idxd_wqs_unmap_portal(idxd);
> -			spin_lock(&idxd->dev_lock);
>  			idxd_device_clear_state(idxd);
>  			dev_err(&idxd->pdev->dev,
>  				"idxd halted, need %s.\n",
>  				gensts.reset_type =3D=3D IDXD_DEVICE_RESET_FLR ?
>  				"FLR" : "system reset");
> -			spin_unlock(&idxd->dev_lock);
>  			return -ENXIO;
>  		}
>  	}
> --
> 2.37.2

Thanks.

-Fenghua