Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Dec 2022 16:50:49 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     James Clark <james.clark@arm.com>
Cc:     linux-perf-users@vger.kernel.org, Al.Grant@arm.com,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        John Garry <john.g.garry@oracle.com>,
        Will Deacon <will@kernel.org>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        coresight@lists.linaro.org
Subject: Re: [PATCH 0/5] perf: cs-etm: Print auxtrace info even if OpenCSD
 isn't linked
Message-ID: <Y5eGGb28EAK43j26@kernel.org>
References: <20221212155513.2259623-1-james.clark@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221212155513.2259623-1-james.clark@arm.com>
Precedence: bulk

Em Mon, Dec 12, 2022 at 03:55:08PM +0000, James Clark escreveu:
> The auxtrace info header can be useful for debugging, and at the
> moment it's possible to record a file without OpenCSD linked but
> not view the header even though it should be possible to do.
> 
> This patchset tidies up some of the related functions and
> improves some of the error messages before making the above
> possible in the last commit.
> 
> Testing done:
> 
>  * Compiled on x86 and Arm both with and without CORESIGHT=1
>  * Ran the Coresight tests
> 
> Applies to perf/core (0c3852adae8)

Thanks, applied.

- Arnaldo

 
> James Clark (5):
>   perf: cs-etm: Print unknown header version as an error
>   perf: cs-etm: Remove unused stub methods
>   perf: cs-etm: Tidy up auxtrace info header printing
>   perf: cs-etm: Cleanup cs_etm__process_auxtrace_info()
>   perf: cs-etm: Print auxtrace info even if OpenCSD isn't linked
> 
>  tools/perf/util/Build         |   1 +
>  tools/perf/util/cs-etm-base.c | 174 ++++++++++++++++++++++++++++
>  tools/perf/util/cs-etm.c      | 208 +++-------------------------------
>  tools/perf/util/cs-etm.h      |  46 ++------
>  4 files changed, 200 insertions(+), 229 deletions(-)
>  create mode 100644 tools/perf/util/cs-etm-base.c
> 
> -- 
> 2.25.1

-- 

- Arnaldo