Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7311559rwb; Mon, 12 Dec 2022 12:59:11 -0800 (PST) X-Google-Smtp-Source: AA0mqf5u82vEyfHPVMyLkX1wzXg6oNNdBNzeq5J9b/C/tdW7CJwLf4v56z8Hyve0SKfQVVh9B5iP X-Received: by 2002:a17:90a:6bc5:b0:219:51f2:bdc8 with SMTP id w63-20020a17090a6bc500b0021951f2bdc8mr18206258pjj.24.1670878751359; Mon, 12 Dec 2022 12:59:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670878751; cv=none; d=google.com; s=arc-20160816; b=xRTDzC8F7DQrlX4OESE9LtP0aZcV92VLwQPSOi201wzJDUZUe10Jk6/t7xdmsPveR9 tv6hP/nFTNpa1nTRthYrHblQXcP257Vz7kbLg01fUC1HXy5URovFCOInF0YmpFBApkTb DyIX8alf6QN5oNMVcM3tjd4957jls/KIElJ/FmRKptJWbX2tq1DOyCkO2bRqcEuCczKp 16fMdMkYnd6Rniwkol0VJ2opjHE9xV1Q7KGdyF7cR43X4uJSFUU/N5ld3z0G7bsNVmeQ Vl+lYoOfnyT7R1dyXq3C3T9j8l8buy4SH3dCjzj5aRSxnGPc+R9Hcu3yOVW2IYHobEBm v6iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:mime-version:date :message-id:dkim-signature; bh=wWQtDne41YslnxEFplhPfMlTBxdVXXUjm16aep/qYYs=; b=ts88UvlXVSjNwr2Z5lJau6uvDjaSTkDWOkTheoh6HJ4XWFbnZlP+E+dfZbokABLq0H QF/fnmith+lWhQ/v0auoO2MNxZNFsjB74Nz256Dmc/vPU4MFcuQ10dp8OjNS33/BGSih ZfkcBjyRJb/skBGxJrHZCsrAle2a0bxXTmE9IWVcA/gwlycfbdLdexP8+JdAHVi5bIa8 fA/DlGxDRZeb31ZKLKj9FYEUo6p+W2uIiEvc+mZEuSR0OvAnan3kowbXhWFQMuKZkS71 8vx/OT0IEZphTHfKhknEW/sZQws10QhcXcbAFxClCLgxtHdpNdzeO/thri09S8JhsxQK gWtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@dorminy.me header.s=mail header.b=QzAwbEjq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=dorminy.me Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ls5-20020a17090b350500b002193189259csi11835908pjb.36.2022.12.12.12.59.00; Mon, 12 Dec 2022 12:59:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@dorminy.me header.s=mail header.b=QzAwbEjq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=dorminy.me Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233537AbiLLUfB (ORCPT + 74 others); Mon, 12 Dec 2022 15:35:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232180AbiLLUe5 (ORCPT ); Mon, 12 Dec 2022 15:34:57 -0500 X-Greylist: delayed 600 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 12 Dec 2022 12:34:55 PST Received: from box.fidei.email (box.fidei.email [71.19.144.250]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A685363FB; Mon, 12 Dec 2022 12:34:55 -0800 (PST) Received: from authenticated-user (box.fidei.email [71.19.144.250]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by box.fidei.email (Postfix) with ESMTPSA id F294082401; Mon, 12 Dec 2022 15:19:21 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=dorminy.me; s=mail; t=1670876362; bh=ahecorPcbaJ/V1nEf8Rhmh8ANZrO4Ll8XuwJ2YCDEyo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QzAwbEjqRfQkd1q8ZDPhTQa3TOCe3sD5s5C44ffESvgXjePe0C44GJd5dUOTIOOGo 5waDCzm1z4ovHXaCT7RHULCRkkFxRTWcliLvCOyEQtK7VwBO91Ahq/Cou9vERxK5qi 7wmed7YRrsAZ+tW8UK6YndeYSRd/DfZQAiGCgpKAIM75cSQXxXqNRbw+ws16RFQDfT 7CankfJpBO2iBgPOWqeZnuJejiFkA5ukypxWiQkoV90fMd/5nDHYWOmwx6J/L0+nlm bjVfgB2apKSr8xK2yK+2Z0yqwAsKoJRCUUcJGSmn+dHiroLWIbg0oRHZz9HknlbnDT Raa8viHJ1+ULg== Message-ID: Date: Mon, 12 Dec 2022 15:19:21 -0500 MIME-Version: 1.0 Subject: Re: [PATCH] btrfs: Fix an error handling path in btrfs_rename() Content-Language: en-US To: Christophe JAILLET , Chris Mason , Josef Bacik , David Sterba Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-btrfs@vger.kernel.org References: <943f0f360f221da954f5dd7f16e366d0e294ae72.1670876024.git.christophe.jaillet@wanadoo.fr> From: Sweet Tea Dorminy In-Reply-To: <943f0f360f221da954f5dd7f16e366d0e294ae72.1670876024.git.christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/22 15:14, Christophe JAILLET wrote: > If new_whiteout_inode() fails, some resources need to be freed. > Add the missing goto to the error handling path. > > Fixes: ab3c5c18e8fa ("btrfs: setup qstr from dentrys using fscrypt helper") > Signed-off-by: Christophe JAILLET Reviewed-by: Sweet Tea Dorminy Thanks for catching this.