Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7370432rwb; Mon, 12 Dec 2022 13:49:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf4bDcLSJZE/QdzK8d+zBdHix5Xx70Lb01JJvO3tdC0/5h/Ig5PfELDt4g/Yhkell1EEf91N X-Received: by 2002:a17:906:a3c1:b0:7ad:7d4a:ebfd with SMTP id ca1-20020a170906a3c100b007ad7d4aebfdmr14985651ejb.62.1670881795526; Mon, 12 Dec 2022 13:49:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670881795; cv=none; d=google.com; s=arc-20160816; b=Ni9V9Z6jNSMKhM56IE9XR79nBWLznJPG6cjFEdAkfk2lVLU5mbs1pJZ7MSnimeDnV7 bgATvXJLTwNnmAT7ryl1vS7jpX3BFFlTn8Umgg304gpc+7q+M+9d87o0GIt2nvJb19aS +zTYBPE1CDct6tUTXYEvLx9MtndQMnia03AZhkn8UIK2Twm6QxqBIrGRkDjsuehYfmJN FSXHvMJ94w+TrDdUA42cJD4zMdQwlRdgYiPQYYu46s0pWCPiMKuIByh1qGr0bBk39UcU 8riOgEcMNiorOphAC12XZLzXzXvz7344Dm7QtmyUrYePK2cTdoqFsxO4UFet6zEZHkNi 49kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=fgdFtMKBvdhUz64CtLzjyuEDQT7N20bZB802gQO3MgY=; b=jxw0mds1gQP/4SSxWbJ/Nx6BZPVci0YwR9Cxd3oplTxgRBv5GZMZHqclheAXuita9Z E4hjDciNFxG2LR6H4o5Gf7GiNd/Su6NsfyuYM7dsxVPUgATycs7T5PDIQsa2zMrAfdCO +UV+4eEcAm7OecWe1/KR6VZrkmOKlZcnqslcl6pp7QKseNS3Vr6S/HS89suJyH5ch389 gKXszaKrHHBSJADLRTUE5IETCgEFO701H7GbVaU+WcaTTOD/SXeUsUnQlZtTf0ggnmvp T+H+JW0poD1cgpER6LhO9mwwOYD1juS08gbzvsiDfk295zl/mMD2QplOlS0jS5kuEzKK 5ldA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hUN2Puvq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa17-20020a1709076d1100b007bc93454b3fsi200648ejc.953.2022.12.12.13.49.37; Mon, 12 Dec 2022 13:49:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hUN2Puvq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233594AbiLLVDw (ORCPT + 74 others); Mon, 12 Dec 2022 16:03:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233453AbiLLVD1 (ORCPT ); Mon, 12 Dec 2022 16:03:27 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CECA1A3A2; Mon, 12 Dec 2022 13:02:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0997E6122C; Mon, 12 Dec 2022 21:02:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1D7CC433D2; Mon, 12 Dec 2022 21:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670878945; bh=UYWCrX2SdeaGdrjephxWJSz8hd3vseMdWBi7qv9hc+c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hUN2PuvqGhiX1804SHPtWkR41XtzZ52cTWV+5ALL1jp2YMmvhQqwLW5uwI2uygFtT 4ATgsyhvJpUt1sce6VRMoOZ5nWFlxN/J4VHy43CDxOweWEyjShth8YYgpCs4+2NsVq 1NMtiUsEy8KYbAMVN12ZccuraMkTPiRnpcAqObDtrB0WvcDF128N6+kUxJSGc0iLkV dkQ0k39cJG9uHzURV4AyyCH4iBsRo+uw2CdtOy92iK5/XZpFTO4V2K6Wa6Jwosgomo LQyv4NnmxMHISkDF5Aw2qKX0I3HZrmFEmcqcACuFq+gvHkRFwNzhWUVyjze5B+bdiM aPlhoLdSoovhw== Date: Mon, 12 Dec 2022 13:02:24 -0800 From: Jakub Kicinski To: Horatiu Vultur Cc: , , , , , , , , , , kernel test robot , "Dan Carpenter" Subject: Re: [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask Message-ID: <20221212130224.19bf695f@kernel.org> In-Reply-To: <20221209120701.218937-1-horatiu.vultur@microchip.com> References: <20221209120701.218937-1-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Dec 2022 13:07:01 +0100 Horatiu Vultur wrote: > case VCAP_FIELD_U128: > + value = data->u128.value; > + mask = data->u128.value; If setting both to value is intentional - please mention in the commit message. Otherwise this looks odd.