Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7530292rwb; Mon, 12 Dec 2022 16:17:54 -0800 (PST) X-Google-Smtp-Source: AA0mqf49aFqUqZHWDfUmt8SS3T7BsjqAivoz0Cy2L53KfhZeOOtJfE28FGNd08+2ZdtiOvubVTE2 X-Received: by 2002:a05:6a20:441e:b0:ac:31c7:9d7 with SMTP id ce30-20020a056a20441e00b000ac31c709d7mr36739613pzb.52.1670890673855; Mon, 12 Dec 2022 16:17:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670890673; cv=none; d=google.com; s=arc-20160816; b=aFO2BeWiGVOWtFOra2UHkmAlGMDZqulBiMy38QO3PiS/YH9mFYn/DbW9jSkTx1KK+e kN4IdzfS1wPjFJE/7V1UoiwoX7041A2i443N+dLMAnQsWP/3cMBa3hH/lXDguvz4EWBr mm0SvXATtPzL9WLorSKkMkeAi+TIAYMQOUCxNSrdtMkZwYQteyBsVDTJ/4kvpBfaoMHi W/2a35EqPoMJqUFoI6xS3KCZH5CUpM1IxKEKTr20xraPdXkq0YKHWEBk2bqYlevUVzzv ygR0ZXS6yAP74Mv/5UuiagLL/o84gyCJAgpvuOOxakcPYuQwd1fA99jQOHDzPYRZi1+b gkRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9ePabqc+7cC0/UaZKrAYhyBgYRi0kbDxozWzURzMwUw=; b=UuIzO+zbRjJQCiRDW2Ubgv/9dz/oR0wJK5ki0+wVJhugbV/ypRl9tz6drL9VCLx4bl TswDVwDbsuyPti4IOZU4HnSe3ts+Y61WXc1alRtvXMYkHVRTlNc8+lxhR8dZI1U9rVkm yML2D3atFfIWH+0u1Y0yoPr9HOuh4L/iBUfRbYSawilf41R/nV3CBDjsZNJMADGDPrl6 mHwL+AKsr3W6Le8nGkJJ8iF0Unc/TdmCGPyfo9Z6HZykaPNM7qVXrjYWdbq1uOD7vnJ4 haQ3miRgLpOiqKZckPKvZ2Sn9yitatxR/bRE3aPuGr7OpK98ALDkAB7xEb+VBi95vpEE +Cpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=mmv5VaQM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n128-20020a632786000000b004776765cf3csi10939156pgn.605.2022.12.12.16.17.44; Mon, 12 Dec 2022 16:17:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=mmv5VaQM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233723AbiLLXzg (ORCPT + 74 others); Mon, 12 Dec 2022 18:55:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbiLLXz1 (ORCPT ); Mon, 12 Dec 2022 18:55:27 -0500 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D448514D16; Mon, 12 Dec 2022 15:55:26 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id EB5BA240005; Mon, 12 Dec 2022 23:55:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1670889325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9ePabqc+7cC0/UaZKrAYhyBgYRi0kbDxozWzURzMwUw=; b=mmv5VaQMh/vMpCRGByESBoQX2M3D239kNVz4lI1tZgEP+rsEbp+Wiq0ejw7ZrpuyFMZsQ9 xNCa1B+RWYZzFAdewbD8yK+JqfiMtqSjSjRHPBtnTfid9nKyPslIO9SxB8XmnMxprjJqmh wLHQRMqdcJAH52szUixa/36HCGBYsHl5gZCEJq5BlVqM+/GoN2P9FUgzvgnsuADpnjKnkp aZE41hbIYr6FsLJQCUF1e42y2C0LbBAi5loOVQRVdumJPwRza6QSl27Hihw74BJ2eDgL/y taR/zZNVaKGblP8CbfotOOQ1pWrYidvWv9j1oHxKz15NvEUURqH58rvh91lYZg== Date: Tue, 13 Dec 2022 00:55:24 +0100 From: Alexandre Belloni To: ye.xingchen@zte.com.cn Cc: a.zummo@towertech.it, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH linux-next] rtc: ds1307: use sysfs_emit() to instead of scnprintf() Message-ID: <167088930337.313278.11105022204603125591.b4-ty@bootlin.com> References: <202212051134455911470@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202212051134455911470@zte.com.cn> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Dec 2022 11:34:45 +0800 (CST), ye.xingchen@zte.com.cn wrote: > From: ye xingchen > > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. > > > [...] Applied, thanks! [1/1] rtc: ds1307: use sysfs_emit() to instead of scnprintf() commit: 20ff2be9cf5c1951e5a14e570129cf118039a25a Best regards, -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com