Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Dec 2022 16:25:48 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     James Houghton <jthoughton@google.com>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Peter Xu <peterx@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Zach O'Keefe <zokeefe@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Yang Shi <shy828301@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 09/47] hugetlb: make huge_pte_lockptr take an
 explicit shift argument.
Message-ID: <Y5fGjKPefweBQg+H@monkey>
References: <20221021163703.3218176-1-jthoughton@google.com>
 <20221021163703.3218176-10-jthoughton@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221021163703.3218176-10-jthoughton@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TOo/burlk4FpscA8RiAYMXCgouRMw393c7dhtdQjvVk3K+h0IMO70QhiCiAp?=
 =?us-ascii?Q?VBo64JuXCI/dBYjuCR6SbOkn1YDFCb4fgVnFdKyZPQ/hrk/dURYY8H0Ib/Dl?=
 =?us-ascii?Q?xufUmWi4s84Nn//e7TKbE+LGEQhRx1Sdk/2LNH+mrWhZABP3xECK9+Egah2Q?=
 =?us-ascii?Q?ulBtTwk9Of0yU5iKEjTgmJZweMDj7cGlKq4bEprvSNMwNQBBO3CxeqOLxYJY?=
 =?us-ascii?Q?M11ytNM8ru+KTsAQpkasYnfWmNW8uoxPQZWrcTOv3f81FOEjrMd+IKmNvsJp?=
 =?us-ascii?Q?FPLz1x+bOu/hnJwl543gfn3tHumSh40LRYizrV9vhQcWP5N0egYAHvc7JOjZ?=
 =?us-ascii?Q?bhK09Xm+pufAPtmlA4GxAbSWJSdYGC4XgSEfwLC0puC4lBGBaLJdeOhiQRbN?=
 =?us-ascii?Q?43aPbmCyFyajSavvIA6gsQlsE0zZP96IXUZ1XAjh/eHK57nwgWZdug3sFeau?=
 =?us-ascii?Q?V0sdqEf5DSK7iPcw5AiD/lNS6gNz0f0mhqbVwUdqXKQ7Opp9g1vqP+uwPfmp?=
 =?us-ascii?Q?OmW5G7Vh8Cy25w4gbo/LUdSb0130hRlwRj0iOPmJS6MmgZbOMa1Uyd6Va+Uf?=
 =?us-ascii?Q?s21qIwOEqcDZ3LzJDNfdGe6ChT6lacMzOz29y1QS02ce833CnzE04E3KeU0I?=
 =?us-ascii?Q?64ONHt9puE1z945zMPPB0xcAQPbCV9T+5lRIzWST6Idfd0VbHLBioHr6OodV?=
 =?us-ascii?Q?VHsbQflP00cZtyK5prhdiNJhza3YLXseOmHPXBq+KR+E3qXz4q1nvngE6PHh?=
 =?us-ascii?Q?q96BbjeOk6fH4yy/xrWo5bDWOFho2aLYToGg4zv/5NcUKBxvbsOEeBKCH6nA?=
 =?us-ascii?Q?YLpefE3IpXUd+ry+YYZBeFUQPEYicyMzhyAW/pQWP/0OJgpxYcBkJz1oijAI?=
 =?us-ascii?Q?SZ0mu1Lhriwr41tZ6Zh1GMpdDmBbb39tRHZP2Ru7YzUgj6UlyHAXJIOGSuVZ?=
 =?us-ascii?Q?RHFepM3RmqyiJaLrLMxYD0m1vtcOH2c7rYO5oQ3pu+y9roL2a7iM7iYzgKLH?=
 =?us-ascii?Q?22Xb+rKxfaoa6LkylZEGVKvK16tIUXWWfOpYZptwax3LhOa3ieM2WJEA4x+c?=
 =?us-ascii?Q?jCOD+MhwlL8f3fz7t0JbtubQIqeKsrD1MNf5Tf3p74OdetQDN86CGl4nKZiu?=
 =?us-ascii?Q?mbVsFG9j+YRWfBC4V+oS4V5CTZUpIXVHkQ32nSalEky3YLRBSRP58aC/wVxh?=
 =?us-ascii?Q?PuOSTdsF5kOQS1cogmQPYMDvSN4qhoX/gKNCYUBbOFkVea0ytj8/rhYUANeV?=
 =?us-ascii?Q?HURWUdh7BIgK32a5Dr8cwJEgzFYjYnCimaYa/Te5PBguWUqnnG7s3odLSJVp?=
 =?us-ascii?Q?mFyzyVteRdXA/EN6ja7Ublr7WAOgYHCp9HOFIMAtAiiyDIiaxjfa13akofTi?=
 =?us-ascii?Q?VKIeFWl8X0kW8BRpgWu/QuWDYyu6PVR5VSzlpuL2ByHp8MC/yuzCEXm1Vx5b?=
 =?us-ascii?Q?VDkuJniDEJuwFV9JOLxDsFF1h3dCisN2y36q8E7Pg0iomKhziWk7xinD/tLk?=
 =?us-ascii?Q?prNib7987Yb8dj9xfpin4C0CzFFZOqqyysk1OhgDRfXONAand0bllAEIIroG?=
 =?us-ascii?Q?4v/4Xm7l3dldgKrBPNS57+rSdlOHA6fBlj8o1vnbIHVYtSFWG68CDaFBU4z0?=
 =?us-ascii?Q?ZA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7abad69b-0097-4be4-1571-08dadca096d8
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2022 00:25:51.2758
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W4n7QUD5BjtAJF+D9PY69Rxiw0+HiRjobe9r7sDTpm8WKYw2TvX34JNb4Xmefrkxx8n91MZdChtuiMY0nME/pA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR10MB5954
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-12_02,2022-12-12_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0
 mlxlogscore=749 adultscore=0 malwarescore=0 phishscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2212130002
X-Proofpoint-ORIG-GUID: AbklzqLNnw0sXN1Lp3TMQxE6uAta_zRm
X-Proofpoint-GUID: AbklzqLNnw0sXN1Lp3TMQxE6uAta_zRm
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/21/22 16:36, James Houghton wrote:
> This is needed to handle PTL locking with high-granularity mapping. We
> won't always be using the PMD-level PTL even if we're using the 2M
> hugepage hstate. It's possible that we're dealing with 4K PTEs, in which
> case, we need to lock the PTL for the 4K PTE.
> 
> Signed-off-by: James Houghton <jthoughton@google.com>
> ---
>  arch/powerpc/mm/pgtable.c | 3 ++-
>  include/linux/hugetlb.h   | 9 ++++-----
>  mm/hugetlb.c              | 7 ++++---
>  mm/migrate.c              | 3 ++-
>  4 files changed, 12 insertions(+), 10 deletions(-)

Straight forward substitution,

Acked-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz